diff options
author | jackpoz <giacomopoz@gmail.com> | 2015-02-21 14:53:17 +0100 |
---|---|---|
committer | jackpoz <giacomopoz@gmail.com> | 2015-02-21 14:53:17 +0100 |
commit | d2396fb897a4a2f21a4b43f8c37f3a87c4285f2c (patch) | |
tree | 9d0432255f831df476e3e0b1ca945d22a548bf12 /src/server/game/Handlers/PetitionsHandler.cpp | |
parent | 68fceee10e6eede180ca444a2a7f2af2fe4ba5dc (diff) |
Core/Misc: Fix static analysis issues
Fix some static analysis issues reported by Coverity
Diffstat (limited to 'src/server/game/Handlers/PetitionsHandler.cpp')
-rw-r--r-- | src/server/game/Handlers/PetitionsHandler.cpp | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/src/server/game/Handlers/PetitionsHandler.cpp b/src/server/game/Handlers/PetitionsHandler.cpp index bb658612f25..6dd8d95bbf6 100644 --- a/src/server/game/Handlers/PetitionsHandler.cpp +++ b/src/server/game/Handlers/PetitionsHandler.cpp @@ -177,7 +177,9 @@ void WorldSession::HandlePetitionShowSignatures(WorldPackets::Petition::Petition signature.Choice = 0; signaturesPacket.Signatures.push_back(signature); - result->NextRow(); + // Checking the return value just to be double safe + if (!result->NextRow()) + break; } SendPacket(signaturesPacket.Write()); @@ -447,7 +449,9 @@ void WorldSession::HandleOfferPetition(WorldPackets::Petition::OfferPetition& pa signature.Choice = 0; signaturesPacket.Signatures.push_back(signature); - result->NextRow(); + // Checking the return value just to be double safe + if (!result->NextRow()) + break; } player->GetSession()->SendPacket(signaturesPacket.Write()); @@ -551,7 +555,10 @@ void WorldSession::HandleTurnInPetition(WorldPackets::Petition::TurnInPetition& { Field* fields = result->Fetch(); guild->AddMember(ObjectGuid::Create<HighGuid::Player>(fields[0].GetUInt64())); - result->NextRow(); + + // Checking the return value just to be double safe + if (!result->NextRow()) + break; } SQLTransaction trans = CharacterDatabase.BeginTransaction(); |