aboutsummaryrefslogtreecommitdiff
path: root/src/server/game/Maps/Map.cpp
diff options
context:
space:
mode:
authorShauren <shauren.trinity@gmail.com>2018-04-19 18:06:41 +0200
committerShauren <shauren.trinity@gmail.com>2018-04-19 18:06:41 +0200
commit2e84035125362f0942a7ffaf1de7f1e36c6155d2 (patch)
treecb2cde3e63d5fb4cfd9aaec349885ce3d510702f /src/server/game/Maps/Map.cpp
parentfcb1e3e6424ef86934132e1111052a6798d78bc9 (diff)
Core/Maps: Fixed uninitialized variable in Map::GetAreaId
Closes #21828
Diffstat (limited to 'src/server/game/Maps/Map.cpp')
-rw-r--r--src/server/game/Maps/Map.cpp34
1 files changed, 17 insertions, 17 deletions
diff --git a/src/server/game/Maps/Map.cpp b/src/server/game/Maps/Map.cpp
index 3a2157597a6..6233a2bf7f4 100644
--- a/src/server/game/Maps/Map.cpp
+++ b/src/server/game/Maps/Map.cpp
@@ -1801,7 +1801,7 @@ bool GridMap::loadData(char const* filename)
if (header.holesSize && !loadHolesData(in, header.holesOffset, header.holesSize))
{
TC_LOG_ERROR("maps", "Error loading map holes data\n");
- fclose(in);
+ fclose(in);
return false;
}
fclose(in);
@@ -2485,7 +2485,7 @@ uint32 Map::GetAreaId(float x, float y, float z) const
{
uint32 mogpFlags;
int32 adtId, rootId, groupId;
- float vmapZ;
+ float vmapZ = z;
bool hasVmapArea = VMAP::VMapFactory::createOrGetVMapManager()->getAreaInfo(GetId(), x, y, vmapZ, mogpFlags, adtId, rootId, groupId);
uint32 gridAreaId = 0;
@@ -2604,25 +2604,25 @@ ZLiquidStatus Map::GetLiquidStatus(float x, float y, float z, uint8 ReqLiquidTyp
if (useGridLiquid)
{
- if (GridMap* gmap = const_cast<Map*>(this)->GetGrid(x, y))
- {
- LiquidData map_data;
- ZLiquidStatus map_result = gmap->GetLiquidStatus(x, y, z, ReqLiquidType, &map_data, collisionHeight);
- // Not override LIQUID_MAP_ABOVE_WATER with LIQUID_MAP_NO_WATER:
- if (map_result != LIQUID_MAP_NO_WATER && (map_data.level > ground_level))
+ if (GridMap* gmap = const_cast<Map*>(this)->GetGrid(x, y))
{
- if (data)
+ LiquidData map_data;
+ ZLiquidStatus map_result = gmap->GetLiquidStatus(x, y, z, ReqLiquidType, &map_data, collisionHeight);
+ // Not override LIQUID_MAP_ABOVE_WATER with LIQUID_MAP_NO_WATER:
+ if (map_result != LIQUID_MAP_NO_WATER && (map_data.level > ground_level))
{
- // hardcoded in client like this
- if (GetId() == 530 && map_data.entry == 2)
- map_data.entry = 15;
+ if (data)
+ {
+ // hardcoded in client like this
+ if (GetId() == 530 && map_data.entry == 2)
+ map_data.entry = 15;
- *data = map_data;
+ *data = map_data;
+ }
+ return map_result;
}
- return map_result;
}
}
- }
return result;
}
@@ -2687,8 +2687,8 @@ void Map::GetFullTerrainStatusForPosition(float x, float y, float z, PositionFul
data.outdoors = (areaEntry->flags & (AREA_FLAG_INSIDE | AREA_FLAG_OUTSIDE)) != AREA_FLAG_INSIDE;
}
- if (!data.areaId)
- data.areaId = i_mapEntry->linked_zone;
+ if (!data.areaId)
+ data.areaId = i_mapEntry->linked_zone;
AreaTableEntry const* areaEntry = sAreaTableStore.LookupEntry(data.areaId);