Core/Realms: Realmlist refactors

* Removed global realm variable from World and use RealmList everywhere
* Match auth build key with client version
* Restored allowedSecurityLevel checks for realmlist packet building
* Restored updating population field, mysteriously removed 15 years ago in f20b25d1c90f608deab28c9957b3b376ab2a0d50

1 files changed, 5 insertions, 3 deletions

diff --git a/src/server/game/Server/Protocol/PacketLog.cpp b/src/server/game/Server/Protocol/PacketLog.cpp
index 595738330d3..c912114849d 100644
--- a/src/server/game/Server/Protocol/PacketLog.cpp
+++ b/src/server/game/Server/Protocol/PacketLog.cpp
@@ -19,9 +19,8 @@
 #include "Config.h"
 #include "GameTime.h"
 #include "IpAddress.h"
-#include "Realm.h"
+#include "RealmList.h"
 #include "Timer.h"
-#include "World.h"
 #include "WorldPacket.h"
 
 #pragma pack(push, 1)
@@ -98,7 +97,10 @@ void PacketLog::Initialize()
             header.Signature[0] = 'P'; header.Signature[1] = 'K'; header.Signature[2] = 'T';
             header.FormatVersion = 0x0301;
             header.SnifferId = 'T';
-            header.Build = realm.Build;
+            if (std::shared_ptr<Realm const> currentRealm = sRealmList->GetCurrentRealm())
+                header.Build = currentRealm->Build;
+            else
+                header.Build = 0;
             header.Locale[0] = 'e'; header.Locale[1] = 'n'; header.Locale[2] = 'U'; header.Locale[3] = 'S';
             std::memset(header.SessionKey, 0, sizeof(header.SessionKey));
             header.SniffStartUnixtime = GameTime::GetGameTime();