Core/Spell: fix target checks

- Aura will be applied at last moment possible (after damage) to prevent regressions on #18395
- Partial revert of 9b38a6352c0fe2499de54fd769aa1c721a410bda as it wasnt handling correctly checks without spells

Closes #21578
Closes #21579
Closes #21581

1 files changed, 0 insertions, 4 deletions

diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp
index e1a374596f8..96dec8e753b 100644
--- a/src/server/game/Spells/SpellEffects.cpp
+++ b/src/server/game/Spells/SpellEffects.cpp
@@ -1212,10 +1212,6 @@ void Spell::EffectApplyAura(SpellEffIndex effIndex)
         aurApp = unitTarget->_CreateAuraApplication(_spellAura, 1 << effIndex);
     else
         aurApp->UpdateApplyEffectMask(aurApp->GetEffectsToApply() | 1 << effIndex);
-
-    // apply effect on target (skip for reapply)
-    if (!aurApp->HasEffect(effIndex))
-        unitTarget->_ApplyAuraEffect(_spellAura, effIndex);
 }
 
 void Spell::EffectUnlearnSpecialization(SpellEffIndex effIndex)