Core/ChatCommands: Drop PlayerIdentifier's cast operators which could return nullptr (PR #25431)

1 files changed, 5 insertions, 9 deletions

diff --git a/src/server/game/Chat/ChatCommands/ChatCommandTags.h b/src/server/game/Chat/ChatCommands/ChatCommandTags.h
index 50a0d82edf9..011782a41cc 100644
--- a/src/server/game/Chat/ChatCommands/ChatCommandTags.h
+++ b/src/server/game/Chat/ChatCommands/ChatCommandTags.h
@@ -149,15 +149,11 @@ namespace Trinity::ChatCommands
         PlayerIdentifier() : _name(), _guid(), _player(nullptr) {}
         PlayerIdentifier(Player& player);
 
-        template <typename T>
-        operator std::enable_if_t<std::is_base_of_v<T, Player>, T*>() const { return static_cast<T*>(_player); }
-        operator value_type() const { return _player; }
-        operator ObjectGuid() { return _guid; }
-        Player* operator->() const { return _player; }
-        explicit operator bool() const { return (_player != nullptr); }
-        bool operator!() const { return (_player == nullptr); }
-
-        std::string const& GetName() { return _name; }
+        operator ObjectGuid() const { return _guid; }
+        operator std::string const&() const { return _name; }
+        operator std::string_view() const { return _name; }
+
+        std::string const& GetName() const { return _name; }
         ObjectGuid GetGUID() const { return _guid; }
         bool IsConnected() const { return (_player != nullptr); }
         Player* GetConnectedPlayer() const { return _player; }