aboutsummaryrefslogtreecommitdiff
path: root/src/server/scripts/Kalimdor
diff options
context:
space:
mode:
authorSubv <s.v.h21@hotmail.com>2013-05-17 21:11:18 -0500
committerSubv <s.v.h21@hotmail.com>2013-05-17 21:11:18 -0500
commit25acef257240edb7763eac043554ca7c7ac767eb (patch)
treee574a1a4936201d811a06eb132720eef68d99d99 /src/server/scripts/Kalimdor
parent7c18bbb95f896fa320e4f8a2b7808714b8ba270c (diff)
* Batch of fixes for issues found by static analysis.
Diffstat (limited to 'src/server/scripts/Kalimdor')
-rw-r--r--src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjal_trash.cpp2
-rw-r--r--src/server/scripts/Kalimdor/zone_winterspring.cpp6
2 files changed, 3 insertions, 5 deletions
diff --git a/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjal_trash.cpp b/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjal_trash.cpp
index 630c379e71e..87a09749724 100644
--- a/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjal_trash.cpp
+++ b/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjal_trash.cpp
@@ -773,7 +773,7 @@ public:
void JustSummoned(Creature* summon)
{
Unit* target = SelectTarget(SELECT_TARGET_RANDOM, 0, 30, true);
- if (target && summon)
+ if (target)
summon->Attack(target, false);
summons.Summon(summon);
}
diff --git a/src/server/scripts/Kalimdor/zone_winterspring.cpp b/src/server/scripts/Kalimdor/zone_winterspring.cpp
index 2b68c0a2cb6..c523cfba952 100644
--- a/src/server/scripts/Kalimdor/zone_winterspring.cpp
+++ b/src/server/scripts/Kalimdor/zone_winterspring.cpp
@@ -182,10 +182,8 @@ public:
}
if (!found)
- {
return;
- }
-
+
DoNextDialogueStep();
}
@@ -210,7 +208,7 @@ private:
void DoNextDialogueStep()
{
// Last Dialogue Entry done?
- if (_currentEntry && !_currentEntry->TextEntry)
+ if (!_currentEntry || !_currentEntry->TextEntry)
{
_actionTimer = 0;
return;