Fix various warnings. The core, the scripts and the tools now compile without warnings with -Wall -Wextra -pedantic.

-Fix warnings from -Woverflow on implicit constant conversion.
-Fix warnings from -pedantic.
-Fix warnings from -pedantic.
-Fix warnings from -Wformat.

Two minor changes in addition :

-Replace a defined value equal to 2^31 - 1 by std::numeric_limits<int>::max().
-Remove useless null-check on pointer returned by new. New doesn't returns nullptr on failure, it throws std::bad_alloc.

8 files changed, 11 insertions, 11 deletions

diff --git a/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_kazrogal.cpp b/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_kazrogal.cpp
index 193b8bfe483..0ba6ead0742 100644
--- a/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_kazrogal.cpp
+++ b/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_kazrogal.cpp
@@ -181,7 +181,7 @@ class spell_mark_of_kazrogal : public SpellScriptLoader
 
         class spell_mark_of_kazrogal_SpellScript : public SpellScript
         {
-            PrepareSpellScript(spell_mark_of_kazrogal_SpellScript);
+            PrepareSpellScript(spell_mark_of_kazrogal_SpellScript)
 
             void FilterTargets(std::list<WorldObject*>& targets)
             {
@@ -196,7 +196,7 @@ class spell_mark_of_kazrogal : public SpellScriptLoader
 
         class spell_mark_of_kazrogal_AuraScript : public AuraScript
         {
-            PrepareAuraScript(spell_mark_of_kazrogal_AuraScript);
+            PrepareAuraScript(spell_mark_of_kazrogal_AuraScript)
 
             bool Validate(SpellInfo const* /*spell*/) override
             {
diff --git a/src/server/scripts/Kalimdor/RazorfenKraul/razorfen_kraul.cpp b/src/server/scripts/Kalimdor/RazorfenKraul/razorfen_kraul.cpp
index 835fd6228e1..7a6a5969783 100644
--- a/src/server/scripts/Kalimdor/RazorfenKraul/razorfen_kraul.cpp
+++ b/src/server/scripts/Kalimdor/RazorfenKraul/razorfen_kraul.cpp
@@ -257,7 +257,7 @@ class spell_snufflenose_command : public SpellScriptLoader
 
         class spell_snufflenose_commandSpellScript : public SpellScript
         {
-            PrepareSpellScript(spell_snufflenose_commandSpellScript);
+            PrepareSpellScript(spell_snufflenose_commandSpellScript)
 
             bool Load() override
             {
diff --git a/src/server/scripts/Kalimdor/RuinsOfAhnQiraj/boss_buru.cpp b/src/server/scripts/Kalimdor/RuinsOfAhnQiraj/boss_buru.cpp
index ac490b1440d..822e4356202 100644
--- a/src/server/scripts/Kalimdor/RuinsOfAhnQiraj/boss_buru.cpp
+++ b/src/server/scripts/Kalimdor/RuinsOfAhnQiraj/boss_buru.cpp
@@ -247,7 +247,7 @@ class spell_egg_explosion : public SpellScriptLoader
 
         class spell_egg_explosion_SpellScript : public SpellScript
         {
-            PrepareSpellScript(spell_egg_explosion_SpellScript);
+            PrepareSpellScript(spell_egg_explosion_SpellScript)
 
             void HandleAfterCast()
             {
diff --git a/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_skeram.cpp b/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_skeram.cpp
index 51384cc117d..efb814dac73 100644
--- a/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_skeram.cpp
+++ b/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_skeram.cpp
@@ -215,7 +215,7 @@ class spell_skeram_arcane_explosion : public SpellScriptLoader
 
         class spell_skeram_arcane_explosion_SpellScript : public SpellScript
         {
-            PrepareSpellScript(spell_skeram_arcane_explosion_SpellScript);
+            PrepareSpellScript(spell_skeram_arcane_explosion_SpellScript)
 
             void FilterTargets(std::list<WorldObject*>& targets)
             {
diff --git a/src/server/scripts/Kalimdor/boss_azuregos.cpp b/src/server/scripts/Kalimdor/boss_azuregos.cpp
index db41213e94e..42d432f1642 100644
--- a/src/server/scripts/Kalimdor/boss_azuregos.cpp
+++ b/src/server/scripts/Kalimdor/boss_azuregos.cpp
@@ -178,7 +178,7 @@ class spell_mark_of_frost : public SpellScriptLoader
 
         class spell_mark_of_frost_SpellScript : public SpellScript
         {
-            PrepareSpellScript(spell_mark_of_frost_SpellScript);
+            PrepareSpellScript(spell_mark_of_frost_SpellScript)
 
             bool Validate(SpellInfo const* /*spellInfo*/) override
             {
diff --git a/src/server/scripts/Kalimdor/zone_dustwallow_marsh.cpp b/src/server/scripts/Kalimdor/zone_dustwallow_marsh.cpp
index aa9774bfd62..a96133dad16 100644
--- a/src/server/scripts/Kalimdor/zone_dustwallow_marsh.cpp
+++ b/src/server/scripts/Kalimdor/zone_dustwallow_marsh.cpp
@@ -610,7 +610,7 @@ class spell_ooze_zap : public SpellScriptLoader
 
         class spell_ooze_zap_SpellScript : public SpellScript
         {
-            PrepareSpellScript(spell_ooze_zap_SpellScript);
+            PrepareSpellScript(spell_ooze_zap_SpellScript)
 
             bool Validate(SpellInfo const* /*spellInfo*/) override
             {
@@ -657,7 +657,7 @@ class spell_ooze_zap_channel_end : public SpellScriptLoader
 
         class spell_ooze_zap_channel_end_SpellScript : public SpellScript
         {
-            PrepareSpellScript(spell_ooze_zap_channel_end_SpellScript);
+            PrepareSpellScript(spell_ooze_zap_channel_end_SpellScript)
 
             bool Validate(SpellInfo const* /*spellInfo*/) override
             {
@@ -693,7 +693,7 @@ class spell_energize_aoe : public SpellScriptLoader
 
         class spell_energize_aoe_SpellScript : public SpellScript
         {
-            PrepareSpellScript(spell_energize_aoe_SpellScript);
+            PrepareSpellScript(spell_energize_aoe_SpellScript)
 
             bool Validate(SpellInfo const* /*spellInfo*/) override
             {
diff --git a/src/server/scripts/Kalimdor/zone_feralas.cpp b/src/server/scripts/Kalimdor/zone_feralas.cpp
index fa5336df1f3..8baa02e72b3 100644
--- a/src/server/scripts/Kalimdor/zone_feralas.cpp
+++ b/src/server/scripts/Kalimdor/zone_feralas.cpp
@@ -215,7 +215,7 @@ class spell_gordunni_trap : public SpellScriptLoader
 
         class spell_gordunni_trap_SpellScript : public SpellScript
         {
-            PrepareSpellScript(spell_gordunni_trap_SpellScript);
+            PrepareSpellScript(spell_gordunni_trap_SpellScript)
 
             void HandleDummy()
             {
diff --git a/src/server/scripts/Kalimdor/zone_silithus.cpp b/src/server/scripts/Kalimdor/zone_silithus.cpp
index 3f4fb31a11d..42ab3d8d9cf 100644
--- a/src/server/scripts/Kalimdor/zone_silithus.cpp
+++ b/src/server/scripts/Kalimdor/zone_silithus.cpp
@@ -1006,7 +1006,7 @@ void npc_qiraj_war_spawn::npc_qiraj_war_spawnAI::JustDied(Unit* /*slayer*/)
         if (npc_anachronos_quest_trigger::npc_anachronos_quest_triggerAI* triggerAI = CAST_AI(npc_anachronos_quest_trigger::npc_anachronos_quest_triggerAI, mob->AI()))
             triggerAI->LiveCounter();
 
-};
+}
 
 /*#####
 # go_crystalline_tear