diff options
| author | Shauren <shauren.trinity@gmail.com> | 2017-04-02 23:29:26 +0200 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2017-04-02 23:29:26 +0200 |
| commit | 2a8294031b9ec73f1f082bd0137d9431545808ff (patch) | |
| tree | 5b81787abdc35730e480512a9e76fbf4cfa1fa34 /src/server/scripts/Spells | |
| parent | cbc8a0e4dd5590e053b059f68989127c484bdbf0 (diff) | |
Core/Spells: Removed most uses of SpellIcon to identify spells
Diffstat (limited to 'src/server/scripts/Spells')
| -rw-r--r-- | src/server/scripts/Spells/spell_generic.cpp | 18 | ||||
| -rw-r--r-- | src/server/scripts/Spells/spell_item.cpp | 2 | ||||
| -rw-r--r-- | src/server/scripts/Spells/spell_mage.cpp | 308 | ||||
| -rw-r--r-- | src/server/scripts/Spells/spell_paladin.cpp | 68 | ||||
| -rw-r--r-- | src/server/scripts/Spells/spell_pet.cpp | 29 |
5 files changed, 21 insertions, 404 deletions
diff --git a/src/server/scripts/Spells/spell_generic.cpp b/src/server/scripts/Spells/spell_generic.cpp index 80774c37171..6557711a160 100644 --- a/src/server/scripts/Spells/spell_generic.cpp +++ b/src/server/scripts/Spells/spell_generic.cpp @@ -627,7 +627,7 @@ enum BreakShieldSpells SPELL_BREAK_SHIELD_TRIGGER_UNK = 66480 }; -class spell_gen_break_shield: public SpellScriptLoader +class spell_gen_break_shield : public SpellScriptLoader { public: spell_gen_break_shield(const char* name) : SpellScriptLoader(name) { } @@ -636,6 +636,11 @@ class spell_gen_break_shield: public SpellScriptLoader { PrepareSpellScript(spell_gen_break_shield_SpellScript); + bool Validate(SpellInfo const* spellInfo) override + { + return ValidateSpellInfo({ 62552, 62719, 64100, 66482 }); + } + void HandleScriptEffect(SpellEffIndex effIndex) { Unit* target = GetHitUnit(); @@ -672,8 +677,7 @@ class spell_gen_break_shield: public SpellScriptLoader { if (Aura* aura = itr->second->GetBase()) { - SpellInfo const* auraInfo = aura->GetSpellInfo(); - if (auraInfo && auraInfo->SpellIconID == 2007 && aura->HasEffectType(SPELL_AURA_MOD_DAMAGE_PERCENT_TAKEN)) + if (aura->GetId() == 62552 || aura->GetId() == 62719 || aura->GetId() == 64100 || aura->GetId() == 66482) { aura->ModStackAmount(-1, AURA_REMOVE_BY_ENEMY_SPELL); // Remove dummys from rider (Necessary for updating visual shields) @@ -2008,6 +2012,11 @@ class spell_gen_mounted_charge: public SpellScriptLoader { PrepareSpellScript(spell_gen_mounted_charge_SpellScript); + bool Validate(SpellInfo const* spellInfo) override + { + return ValidateSpellInfo({ 62552, 62719, 64100, 66482 }); + } + void HandleScriptEffect(SpellEffIndex effIndex) { Unit* target = GetHitUnit(); @@ -2048,8 +2057,7 @@ class spell_gen_mounted_charge: public SpellScriptLoader { if (Aura* aura = itr->second->GetBase()) { - SpellInfo const* auraInfo = aura->GetSpellInfo(); - if (auraInfo && auraInfo->SpellIconID == 2007 && aura->HasEffectType(SPELL_AURA_MOD_DAMAGE_PERCENT_TAKEN)) + if (aura->GetId() == 62552 || aura->GetId() == 62719 || aura->GetId() == 64100 || aura->GetId() == 66482) { aura->ModStackAmount(-1, AURA_REMOVE_BY_ENEMY_SPELL); // Remove dummys from rider (Necessary for updating visual shields) diff --git a/src/server/scripts/Spells/spell_item.cpp b/src/server/scripts/Spells/spell_item.cpp index 85a6335b485..ad22ed56433 100644 --- a/src/server/scripts/Spells/spell_item.cpp +++ b/src/server/scripts/Spells/spell_item.cpp @@ -175,7 +175,7 @@ class spell_item_blessing_of_ancient_kings : public SpellScriptLoader PreventDefaultAction(); int32 absorb = int32(CalculatePct(eventInfo.GetHealInfo()->GetHeal(), 15.0f)); - if (AuraEffect* protEff = eventInfo.GetProcTarget()->GetAuraEffect(SPELL_PROTECTION_OF_ANCIENT_KINGS, 0, eventInfo.GetActor()->GetGUID())) + if (AuraEffect* protEff = eventInfo.GetProcTarget()->GetAuraEffect(SPELL_PROTECTION_OF_ANCIENT_KINGS, EFFECT_0, eventInfo.GetActor()->GetGUID())) { // The shield can grow to a maximum size of 20,000 damage absorbtion protEff->SetAmount(std::min<int32>(protEff->GetAmount() + absorb, 20000)); diff --git a/src/server/scripts/Spells/spell_mage.cpp b/src/server/scripts/Spells/spell_mage.cpp index 1eb02d094e2..f375de663ff 100644 --- a/src/server/scripts/Spells/spell_mage.cpp +++ b/src/server/scripts/Spells/spell_mage.cpp @@ -36,20 +36,15 @@ enum MageSpells SPELL_ARCANCE_POTENCY_TRIGGER_RANK_1 = 57529, SPELL_ARCANCE_POTENCY_TRIGGER_RANK_2 = 57531, SPELL_MAGE_BLAZING_BARRIER_TRIGGER = 235314, - SPELL_MAGE_BLAZING_SPEED = 31643, - SPELL_MAGE_BURNOUT = 29077, SPELL_MAGE_COLD_SNAP = 11958, SPELL_MAGE_CONJURE_REFRESHMENT = 116136, SPELL_MAGE_CONJURE_REFRESHMENT_TABLE = 167145, + SPELL_MAGE_FINGERS_OF_FROST = 44544, SPELL_MAGE_FOCUS_MAGIC_PROC = 54648, SPELL_MAGE_FROST_NOVA = 122, - SPELL_MAGE_FROST_WARDING_R1 = 11189, - SPELL_MAGE_FROST_WARDING_TRIGGERED = 57776, SPELL_MAGE_IMPROVED_POLYMORPH_RANK_1 = 11210, SPELL_MAGE_IMPROVED_POLYMORPH_STUN_RANK_1 = 83046, SPELL_MAGE_IMPROVED_POLYMORPH_MARKER = 87515, - SPELL_MAGE_INCANTERS_ABSORBTION_R1 = 44394, - SPELL_MAGE_INCANTERS_ABSORBTION_TRIGGERED = 44413, SPELL_MAGE_IGNITE = 12654, SPELL_MAGE_MASTER_OF_ELEMENTS_ENERGIZE = 29077, SPELL_MAGE_PERMAFROST = 91394, @@ -60,38 +55,17 @@ enum MageSpells SPELL_MAGE_DRAGONHAWK_FORM = 32818, SPELL_MAGE_WORGEN_FORM = 32819, SPELL_MAGE_SHEEP_FORM = 32820, - SPELL_MAGE_GLYPH_OF_ETERNAL_WATER = 70937, - SPELL_MAGE_SUMMON_WATER_ELEMENTAL_PERMANENT = 70908, - SPELL_MAGE_SUMMON_WATER_ELEMENTAL_TEMPORARY = 70907, - SPELL_MAGE_GLYPH_OF_BLAST_WAVE = 62126, - - SPELL_MAGE_FLAMESTRIKE = 2120, - SPELL_MAGE_CONE_OF_COLD_AURA_R1 = 11190, SPELL_MAGE_CONE_OF_COLD_AURA_R2 = 12489, SPELL_MAGE_CONE_OF_COLD_TRIGGER_R1 = 83301, SPELL_MAGE_CONE_OF_COLD_TRIGGER_R2 = 83302, - - SPELL_MAGE_IMPROVED_MANA_GEM_TRIGGERED = 83098, - SPELL_MAGE_RING_OF_FROST_SUMMON = 82676, SPELL_MAGE_RING_OF_FROST_FREEZE = 82691, SPELL_MAGE_RING_OF_FROST_DUMMY = 91264, - - SPELL_MAGE_FINGERS_OF_FROST = 44544, SPELL_MAGE_TEMPORAL_DISPLACEMENT = 80354, SPELL_PET_NETHERWINDS_FATIGUED = 160455, }; -enum MageIcons -{ - ICON_MAGE_SHATTER = 976, - ICON_MAGE_IMPROVED_FLAMESTRIKE = 37, - ICON_MAGE_IMPROVED_FREEZE = 94, - ICON_MAGE_INCANTER_S_ABSORPTION = 2941, - ICON_MAGE_IMPROVED_MANA_GEM = 1036 -}; - enum MiscSpells { SPELL_HUNTER_INSANITY = 95809, @@ -149,85 +123,6 @@ class spell_mage_arcane_potency : public SpellScriptLoader } }; -// Incanter's Absorbtion -class spell_mage_incanters_absorbtion_base_AuraScript : public AuraScript -{ - public: - bool Validate(SpellInfo const* /*spellInfo*/) override - { - if (!sSpellMgr->GetSpellInfo(SPELL_MAGE_INCANTERS_ABSORBTION_TRIGGERED)) - return false; - if (!sSpellMgr->GetSpellInfo(SPELL_MAGE_INCANTERS_ABSORBTION_R1)) - return false; - return true; - } - - void Trigger(AuraEffect* aurEff, DamageInfo& /*dmgInfo*/, uint32& absorbAmount) - { - Unit* target = GetTarget(); - - if (AuraEffect* talentAurEff = target->GetAuraEffectOfRankedSpell(SPELL_MAGE_INCANTERS_ABSORBTION_R1, EFFECT_0)) - { - int32 bp = CalculatePct(absorbAmount, talentAurEff->GetAmount()); - target->CastCustomSpell(target, SPELL_MAGE_INCANTERS_ABSORBTION_TRIGGERED, &bp, NULL, NULL, true, NULL, aurEff); - } - } -}; - -// 11113 - Blast Wave -class spell_mage_blast_wave : public SpellScriptLoader -{ - public: - spell_mage_blast_wave() : SpellScriptLoader("spell_mage_blast_wave") { } - - class spell_mage_blast_wave_SpellScript : public SpellScript - { - PrepareSpellScript(spell_mage_blast_wave_SpellScript); - - bool Validate(SpellInfo const* /*spellInfo*/) override - { - if (!sSpellMgr->GetSpellInfo(SPELL_MAGE_FLAMESTRIKE)) - return false; - return true; - } - - void CountTargets(std::list<WorldObject*>& targetList) - { - _targetCount = targetList.size(); - } - - void HandleImprovedFlamestrike() - { - if (_targetCount >= 2) - if (AuraEffect* aurEff = GetCaster()->GetAuraEffect(SPELL_AURA_DUMMY, SPELLFAMILY_MAGE, ICON_MAGE_IMPROVED_FLAMESTRIKE, EFFECT_0)) - if (roll_chance_i(aurEff->GetAmount())) - { - float x, y, z; - WorldLocation const* loc = GetExplTargetDest(); - if (!loc) - return; - - loc->GetPosition(x, y, z); - GetCaster()->CastSpell(x, y, z, SPELL_MAGE_FLAMESTRIKE, true); - } - } - - void Register() override - { - OnObjectAreaTargetSelect += SpellObjectAreaTargetSelectFn(spell_mage_blast_wave_SpellScript::CountTargets, EFFECT_0, TARGET_UNIT_DEST_AREA_ENEMY); - AfterCast += SpellCastFn(spell_mage_blast_wave_SpellScript::HandleImprovedFlamestrike); - } - - private: - uint32 _targetCount = 0; - }; - - SpellScript* GetSpellScript() const override - { - return new spell_mage_blast_wave_SpellScript(); - } -}; - // 235313 - Blazing Barrier class spell_mage_blazing_barrier : public SpellScriptLoader { @@ -391,71 +286,6 @@ public: } }; -// 543 - Fire War -class spell_mage_fire_frost_ward : public SpellScriptLoader -{ - public: - spell_mage_fire_frost_ward() : SpellScriptLoader("spell_mage_fire_frost_ward") { } - - class spell_mage_fire_frost_ward_AuraScript : public spell_mage_incanters_absorbtion_base_AuraScript - { - PrepareAuraScript(spell_mage_fire_frost_ward_AuraScript); - - bool Validate(SpellInfo const* /*spellInfo*/) override - { - if (!sSpellMgr->GetSpellInfo(SPELL_MAGE_FROST_WARDING_TRIGGERED) || - !sSpellMgr->GetSpellInfo(SPELL_MAGE_FROST_WARDING_R1)) - return false; - return true; - } - - void CalculateAmount(AuraEffect const* /*aurEff*/, int32& amount, bool& canBeRecalculated) - { - canBeRecalculated = false; - if (Unit* caster = GetCaster()) - { - // +80.68% from sp bonus - float bonus = 0.8068f; - - bonus *= caster->SpellBaseHealingBonusDone(GetSpellInfo()->GetSchoolMask()); - bonus *= caster->CalculateLevelPenalty(GetSpellInfo()); - - amount += int32(bonus); - } - } - - void Absorb(AuraEffect* /*aurEff*/, DamageInfo& /*dmgInfo*/, uint32& /*absorbAmount*/) - { - /*Unit* target = GetTarget(); - if (AuraEffect* talentAurEff = target->GetAuraEffectOfRankedSpell(SPELL_MAGE_FROST_WARDING_R1, EFFECT_0)) - { - int32 chance = talentAurEff->GetSpellInfo()->Effects[EFFECT_1].CalcValue(); // SPELL_EFFECT_DUMMY with NO_TARGET - - if (roll_chance_i(chance)) - { - int32 bp = dmgInfo.GetDamage(); - dmgInfo.AbsorbDamage(bp); - target->CastCustomSpell(target, SPELL_MAGE_FROST_WARDING_TRIGGERED, &bp, NULL, NULL, true, NULL, aurEff); - absorbAmount = 0; - PreventDefaultAction(); - } - }*/ - } - - void Register() override - { - DoEffectCalcAmount += AuraEffectCalcAmountFn(spell_mage_fire_frost_ward_AuraScript::CalculateAmount, EFFECT_0, SPELL_AURA_SCHOOL_ABSORB); - OnEffectAbsorb += AuraEffectAbsorbFn(spell_mage_fire_frost_ward_AuraScript::Absorb, EFFECT_0); - AfterEffectAbsorb += AuraEffectAbsorbFn(spell_mage_fire_frost_ward_AuraScript::Trigger, EFFECT_0); - } - }; - - AuraScript* GetAuraScript() const override - { - return new spell_mage_fire_frost_ward_AuraScript(); - } -}; - // 54646 - Focus Magic class spell_mage_focus_magic : public SpellScriptLoader { @@ -754,77 +584,6 @@ class spell_mage_ignite : public SpellScriptLoader } }; -// 543 - Mage Ward -/// Updated 4.3.4 -class spell_mage_mage_ward : public SpellScriptLoader -{ - public: - spell_mage_mage_ward() : SpellScriptLoader("spell_mage_mage_ward") { } - - class spell_mage_mage_ward_AuraScript : public AuraScript - { - PrepareAuraScript(spell_mage_mage_ward_AuraScript); - - void HandleAbsorb(AuraEffect* /*aurEff*/, DamageInfo & /*dmgInfo*/, uint32 & absorbAmount) - { - if (AuraEffect* aurEff = GetTarget()->GetAuraEffect(SPELL_AURA_DUMMY, SPELLFAMILY_GENERIC, ICON_MAGE_INCANTER_S_ABSORPTION, EFFECT_0)) - { - int32 bp = CalculatePct(absorbAmount, aurEff->GetAmount()); - GetTarget()->CastCustomSpell(GetTarget(), SPELL_MAGE_INCANTERS_ABSORBTION_TRIGGERED, &bp, NULL, NULL, true); - } - } - - void Register() override - { - AfterEffectAbsorb += AuraEffectAbsorbFn(spell_mage_mage_ward_AuraScript::HandleAbsorb, EFFECT_0); - } - }; - - AuraScript* GetAuraScript() const override - { - return new spell_mage_mage_ward_AuraScript(); - } -}; - -// 1463 - Mana Shield -/// Updated 4.3.4 -class spell_mage_mana_shield : public SpellScriptLoader -{ - public: - spell_mage_mana_shield() : SpellScriptLoader("spell_mage_mana_shield") { } - - class spell_mage_mana_shield_AuraScript : public AuraScript - { - PrepareAuraScript(spell_mage_mana_shield_AuraScript); - - void HandleAbsorb(AuraEffect* /*aurEff*/, DamageInfo & /*dmgInfo*/, uint32 & absorbAmount) - { - if (AuraEffect* aurEff = GetTarget()->GetAuraEffect(SPELL_AURA_DUMMY, SPELLFAMILY_GENERIC, ICON_MAGE_INCANTER_S_ABSORPTION, EFFECT_0)) - { - int32 bp = CalculatePct(absorbAmount, aurEff->GetAmount()); - GetTarget()->CastCustomSpell(GetTarget(), SPELL_MAGE_INCANTERS_ABSORBTION_TRIGGERED, &bp, NULL, NULL, true); - } - } - - void AfterRemove(AuraEffect const* /*aurEff*/, AuraEffectHandleModes /*mode*/) - { - if (GetTargetApplication()->GetRemoveMode() == AURA_REMOVE_BY_ENEMY_SPELL) - GetTarget()->CastSpell(GetTarget(), SPELL_MAGE_INCANTERS_ABSORBTION_R1, true); - } - - void Register() override - { - AfterEffectManaShield += AuraEffectManaShieldFn(spell_mage_mana_shield_AuraScript::HandleAbsorb, EFFECT_0); - AfterEffectRemove += AuraEffectRemoveFn(spell_mage_mana_shield_AuraScript::AfterRemove, EFFECT_0, SPELL_AURA_MANA_SHIELD, AURA_EFFECT_HANDLE_REAL); - } - }; - - AuraScript* GetAuraScript() const override - { - return new spell_mage_mana_shield_AuraScript(); - } -}; - // -29074 - Master of Elements class spell_mage_master_of_elements : public SpellScriptLoader { @@ -1103,45 +862,6 @@ class spell_mage_prismatic_barrier : public SpellScriptLoader } }; -// 5405 - Replenish Mana (Mana Gem) -/// Updated 4.3.4 -class spell_mage_replenish_mana : public SpellScriptLoader -{ - public: - spell_mage_replenish_mana() : SpellScriptLoader("spell_mage_replenish_mana") { } - - class spell_mage_replenish_mana_SpellScript : public SpellScript - { - PrepareSpellScript(spell_mage_replenish_mana_SpellScript); - - bool Validate(SpellInfo const* /*spellInfo*/) override - { - if (!sSpellMgr->GetSpellInfo(SPELL_MAGE_IMPROVED_MANA_GEM_TRIGGERED)) - return false; - return true; - } - - void HandleImprovedManaGem() - { - if (AuraEffect* aurEff = GetCaster()->GetAuraEffect(SPELL_AURA_DUMMY, SPELLFAMILY_MAGE, ICON_MAGE_IMPROVED_MANA_GEM, EFFECT_0)) - { - int32 bp = CalculatePct(GetCaster()->GetMaxPower(POWER_MANA), aurEff->GetAmount()); - GetCaster()->CastCustomSpell(GetCaster(), SPELL_MAGE_IMPROVED_MANA_GEM_TRIGGERED, &bp, &bp, NULL, true); - } - } - - void Register() override - { - AfterCast += SpellCastFn(spell_mage_replenish_mana_SpellScript::HandleImprovedManaGem); - } - }; - - SpellScript* GetSpellScript() const override - { - return new spell_mage_replenish_mana_SpellScript(); - } -}; - // 82676 - Ring of Frost /// Updated 4.3.4 class spell_mage_ring_of_frost : public SpellScriptLoader @@ -1381,7 +1101,6 @@ class spell_mage_trigger_chilled : public SpellScriptLoader }; // 33395 Water Elemental's Freeze -/// Updated 4.3.4 class spell_mage_water_elemental_freeze : public SpellScriptLoader { public: @@ -1398,35 +1117,19 @@ class spell_mage_water_elemental_freeze : public SpellScriptLoader return true; } - void CountTargets(std::list<WorldObject*>& targetList) - { - _didHit = !targetList.empty(); - } - void HandleImprovedFreeze() { - if (!_didHit) - return; - Unit* owner = GetCaster()->GetOwner(); if (!owner) return; - if (AuraEffect* aurEff = owner->GetAuraEffect(SPELL_AURA_DUMMY, SPELLFAMILY_MAGE, ICON_MAGE_IMPROVED_FREEZE, EFFECT_0)) - { - if (roll_chance_i(aurEff->GetAmount())) - owner->CastCustomSpell(SPELL_MAGE_FINGERS_OF_FROST, SPELLVALUE_AURA_STACK, 2, owner, true); - } + owner->CastSpell(owner, SPELL_MAGE_FINGERS_OF_FROST, true); } void Register() override { - OnObjectAreaTargetSelect += SpellObjectAreaTargetSelectFn(spell_mage_water_elemental_freeze_SpellScript::CountTargets, EFFECT_0, TARGET_UNIT_DEST_AREA_ENEMY); - AfterCast += SpellCastFn(spell_mage_water_elemental_freeze_SpellScript::HandleImprovedFreeze); + AfterHit += SpellHitFn(spell_mage_water_elemental_freeze_SpellScript::HandleImprovedFreeze); } - - private: - bool _didHit = false; }; SpellScript* GetSpellScript() const override @@ -1438,12 +1141,10 @@ class spell_mage_water_elemental_freeze : public SpellScriptLoader void AddSC_mage_spell_scripts() { new spell_mage_arcane_potency(); - new spell_mage_blast_wave(); new spell_mage_blazing_barrier(); new spell_mage_cold_snap(); new spell_mage_cone_of_cold(); new spell_mage_conjure_refreshment(); - new spell_mage_fire_frost_ward(); new spell_mage_focus_magic(); new spell_mage_ice_barrier(); new spell_mage_ignite(); @@ -1451,15 +1152,12 @@ void AddSC_mage_spell_scripts() new spell_mage_glyph_of_icy_veins(); new spell_mage_glyph_of_polymorph(); new spell_mage_living_bomb(); - new spell_mage_mage_ward(); - new spell_mage_mana_shield(); new spell_mage_master_of_elements(); new spell_mage_nether_vortex(); new spell_mage_permafrost(); new spell_mage_polymorph(); new spell_mage_polymorph_cast_visual(); new spell_mage_prismatic_barrier(); - new spell_mage_replenish_mana(); new spell_mage_ring_of_frost(); new spell_mage_ring_of_frost_freeze(); new spell_mage_time_warp(); diff --git a/src/server/scripts/Spells/spell_paladin.cpp b/src/server/scripts/Spells/spell_paladin.cpp index 195ead6b4ab..56f90d612fd 100644 --- a/src/server/scripts/Spells/spell_paladin.cpp +++ b/src/server/scripts/Spells/spell_paladin.cpp @@ -30,7 +30,7 @@ enum PaladinSpells { - SPELL_PALADIN_AVENGERS_SHIELD = 31935, + SPELL_PALADIN_AVENGERS_SHIELD = 31935, SPELL_PALADIN_AURA_MASTERY_IMMUNE = 64364, SPELL_PALADIN_BEACON_OF_LIGHT = 53563, SPELL_PALADIN_BEACON_OF_LIGHT_HEAL = 53652, @@ -40,7 +40,6 @@ enum PaladinSpells SPELL_PALADIN_BLESSING_OF_LOWER_CITY_SHAMAN = 37881, SPELL_PALADIN_CONCENTRACTION_AURA = 19746, SPELL_PALADIN_DIVINE_PURPOSE_PROC = 90174, - SPELL_PALADIN_DIVINE_SACRIFICE = 64205, SPELL_PALADIN_DIVINE_STEED_HUMAN = 221883, SPELL_PALADIN_DIVINE_STEED_DRAENEI = 221887, SPELL_PALADIN_DIVINE_STEED_BLOODELF = 221886, @@ -49,35 +48,17 @@ enum PaladinSpells SPELL_PALADIN_EYE_FOR_AN_EYE_RANK_1 = 9799, SPELL_PALADIN_EYE_FOR_AN_EYE_DAMAGE = 25997, SPELL_PALADIN_FORBEARANCE = 25771, - SPELL_PALADIN_GLYPH_OF_SALVATION = 63225, SPELL_PALADIN_HAND_OF_SACRIFICE = 6940, - SPELL_PALADIN_HOLY_LIGHT = 635, SPELL_PALADIN_HOLY_SHOCK_R1 = 20473, SPELL_PALADIN_HOLY_SHOCK_R1_DAMAGE = 25912, SPELL_PALADIN_HOLY_SHOCK_R1_HEALING = 25914, SPELL_PALADIN_IMMUNE_SHIELD_MARKER = 61988, - SPELL_PALADIN_IMPROVED_CONCENTRACTION_AURA = 63510, - SPELL_PALADIN_IMPROVED_DEVOTION_AURA = 63514, SPELL_PALADIN_ITEM_HEALING_TRANCE = 37706, SPELL_PALADIN_JUDGEMENT_DAMAGE = 54158, SPELL_PALADIN_RIGHTEOUS_DEFENSE_TAUNT = 31790, - SPELL_PALADIN_SANCTIFIED_RETRIBUTION_AURA = 63531, - SPELL_PALADIN_SANCTIFIED_RETRIBUTION_R1 = 31869, SPELL_PALADIN_SANCTIFIED_WRATH = 57318, SPELL_PALADIN_SANCTIFIED_WRATH_TALENT_R1 = 53375, - SPELL_PALADIN_SEAL_OF_RIGHTEOUSNESS = 25742, - SPELL_PALADIN_SWIFT_RETRIBUTION_R1 = 53379 -}; - -enum MiscSpells -{ - SPELL_GENERIC_ARENA_DAMPENING = 74410, - SPELL_GENERIC_BATTLEGROUND_DAMPENING = 74411 -}; - -enum PaladinSpellIcons -{ - PALADIN_ICON_ID_RETRIBUTION_AURA = 555 + SPELL_PALADIN_SEAL_OF_RIGHTEOUSNESS = 25742 }; enum PaladinSpellVisualKit @@ -720,48 +701,6 @@ class spell_pal_holy_shock : public SpellScriptLoader } }; -// 63510 - Improved Concentraction Aura (Area Aura) -// 63514 - Improved Devotion Aura (Area Aura) -// 63531 - Sanctified Retribution (Area Aura) -class spell_pal_improved_aura_effect : public SpellScriptLoader -{ - public: - spell_pal_improved_aura_effect(char const* name) : SpellScriptLoader(name) { } - - class spell_pal_improved_aura_effect_AuraScript : public AuraScript - { - PrepareAuraScript(spell_pal_improved_aura_effect_AuraScript); - - bool CheckAreaTarget(Unit* target) - { - Unit::AuraApplicationMap& appliedAuras = target->GetAppliedAuras(); - for (Unit::AuraApplicationMap::iterator itr = appliedAuras.begin(); itr != appliedAuras.end(); ++itr) - { - Aura const* aura = itr->second->GetBase(); - if (aura->GetSpellInfo()->GetSpellSpecific() == SPELL_SPECIFIC_AURA && aura->GetCasterGUID() == GetCasterGUID()) - { - // Not allow for Retribution Aura (prevent stacking) - Retribution Aura Overflow and Retribution Aura has same spell effects - if (GetSpellInfo()->Id == SPELL_PALADIN_SANCTIFIED_RETRIBUTION_AURA && aura->GetSpellInfo()->SpellIconID == PALADIN_ICON_ID_RETRIBUTION_AURA) - return false; - return true; - } - } - - return false; - } - - void Register() override - { - DoCheckAreaTarget += AuraCheckAreaTargetFn(spell_pal_improved_aura_effect_AuraScript::CheckAreaTarget); - } - }; - - AuraScript* GetAuraScript() const override - { - return new spell_pal_improved_aura_effect_AuraScript(); - } -}; - // 37705 - Healing Discount class spell_pal_item_healing_discount : public SpellScriptLoader { @@ -1238,9 +1177,6 @@ void AddSC_paladin_spell_scripts() new spell_pal_grand_crusader(); new spell_pal_hand_of_sacrifice(); new spell_pal_holy_shock(); - new spell_pal_improved_aura_effect("spell_pal_improved_concentraction_aura_effect"); - new spell_pal_improved_aura_effect("spell_pal_improved_devotion_aura_effect"); - new spell_pal_improved_aura_effect("spell_pal_sanctified_retribution_effect"); new spell_pal_item_healing_discount(); new spell_pal_judgement(); new spell_pal_lay_on_hands(); diff --git a/src/server/scripts/Spells/spell_pet.cpp b/src/server/scripts/Spells/spell_pet.cpp index 7f50469679b..0915feb6100 100644 --- a/src/server/scripts/Spells/spell_pet.cpp +++ b/src/server/scripts/Spells/spell_pet.cpp @@ -67,7 +67,6 @@ enum DKPetCalculate SPELL_DEATH_KNIGHT_PET_SCALING_03 = 61697, SPELL_NIGHT_OF_THE_DEAD = 55620, ENTRY_ARMY_OF_THE_DEAD_GHOUL = 24207, - SPELL_DEATH_KNIGHT_GLYPH_OF_GHOUL = 58686, }; enum ShamanPetCalculate @@ -1458,17 +1457,7 @@ public: { if (Unit* owner = pet->GetOwner()) { - float mod = 0.3f; - - // Ravenous Dead. Check just if owner has Ravenous Dead since it's effect is not an aura - if (AuraEffect const* aurEff = owner->GetAuraEffect(SPELL_AURA_MOD_TOTAL_STAT_PERCENTAGE, SPELLFAMILY_DEATHKNIGHT, 3010, 0)) - mod += aurEff->GetSpellInfo()->GetEffect(EFFECT_1)->CalcValue()/100; // Ravenous Dead edits the original scale - - // Glyph of the Ghoul - if (AuraEffect const* aurEff = owner->GetAuraEffect(SPELL_DEATH_KNIGHT_GLYPH_OF_GHOUL, 0)) - mod += aurEff->GetAmount()/100; - - float ownerBonus = float(owner->GetStat(STAT_STAMINA)) * mod; + float ownerBonus = float(owner->GetStat(STAT_STAMINA)) * 0.3f; amount += ownerBonus; } } @@ -1499,21 +1488,7 @@ public: if (!owner) return; - float mod = 0.7f; - - // Ravenous Dead - AuraEffect const* aurEff = NULL; - // Check just if owner has Ravenous Dead since it's effect is not an aura - aurEff = owner->GetAuraEffect(SPELL_AURA_MOD_TOTAL_STAT_PERCENTAGE, SPELLFAMILY_DEATHKNIGHT, 3010, 0); - if (aurEff) - { - mod += CalculatePct(mod, aurEff->GetSpellInfo()->GetEffect(EFFECT_1)->CalcValue()); // Ravenous Dead edits the original scale - } - // Glyph of the Ghoul - aurEff = owner->GetAuraEffect(58686, 0); - if (aurEff) - mod += CalculatePct(1.0f, aurEff->GetAmount()); // Glyph of the Ghoul adds a flat value to the scale mod - float ownerBonus = float(owner->GetStat(STAT_STRENGTH)) * mod; + float ownerBonus = float(owner->GetStat(STAT_STRENGTH)) * 0.7f; amount += ownerBonus; } } |
