aboutsummaryrefslogtreecommitdiff
path: root/src/server/scripts
diff options
context:
space:
mode:
authorGiacomo Pozzoni <giacomopoz@gmail.com>2019-01-01 15:00:27 +0100
committerGitHub <noreply@github.com>2019-01-01 15:00:27 +0100
commit20ea24bf5ccf165ce19139d1f7ec7c650719eb68 (patch)
treefbc5d2f93f15fca7b26a712fdd08c5e56f9823e9 /src/server/scripts
parent3b5014fdae1b57add7fd204a9f9f10f3c2092b83 (diff)
Scripts/Commands: Fix crash caused by .set npc model (#22877)
* Scripts/Commands: Fix crash caused by .set npc model Fix crash caused by .set npc model with invalid model id
Diffstat (limited to 'src/server/scripts')
-rw-r--r--src/server/scripts/Commands/cs_modify.cpp2
-rw-r--r--src/server/scripts/Commands/cs_npc.cpp7
2 files changed, 8 insertions, 1 deletions
diff --git a/src/server/scripts/Commands/cs_modify.cpp b/src/server/scripts/Commands/cs_modify.cpp
index 814d25fe7a1..f4f31cf4cad 100644
--- a/src/server/scripts/Commands/cs_modify.cpp
+++ b/src/server/scripts/Commands/cs_modify.cpp
@@ -770,7 +770,7 @@ public:
}
if (r >= MAX_REPUTATION_RANK)
{
- handler->PSendSysMessage(LANG_COMMAND_FACTION_INVPARAM, rankTxt);
+ handler->PSendSysMessage(LANG_COMMAND_INVALID_PARAM, rankTxt);
handler->SetSentErrorMessage(true);
return false;
}
diff --git a/src/server/scripts/Commands/cs_npc.cpp b/src/server/scripts/Commands/cs_npc.cpp
index cc972f6e23f..0f8e28a6942 100644
--- a/src/server/scripts/Commands/cs_npc.cpp
+++ b/src/server/scripts/Commands/cs_npc.cpp
@@ -837,6 +837,13 @@ public:
handler->SetSentErrorMessage(true);
return false;
}
+
+ if (!sCreatureDisplayInfoStore.LookupEntry(displayId))
+ {
+ handler->PSendSysMessage(LANG_COMMAND_INVALID_PARAM, args);
+ handler->SetSentErrorMessage(true);
+ return false;
+ }
creature->SetDisplayId(displayId);
creature->SetNativeDisplayId(displayId);