diff options
| author | jackpoz <giacomopoz@gmail.com> | 2019-02-05 21:10:39 +0100 |
|---|---|---|
| committer | jackpoz <giacomopoz@gmail.com> | 2019-02-05 21:10:39 +0100 |
| commit | 2fda1572d214d0b114e0291106363f49c2d3179e (patch) | |
| tree | f71ee252e6dc3c59d1d7b694f12b1a4d7fc88d69 /src/server/scripts | |
| parent | 9942047c721110b4d2135028ec4c17060e0301bc (diff) | |
Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan
Diffstat (limited to 'src/server/scripts')
4 files changed, 5 insertions, 3 deletions
diff --git a/src/server/scripts/Commands/cs_go.cpp b/src/server/scripts/Commands/cs_go.cpp index 1f0f0c8317a..8ea58e407c2 100644 --- a/src/server/scripts/Commands/cs_go.cpp +++ b/src/server/scripts/Commands/cs_go.cpp @@ -461,7 +461,7 @@ public: return true; } - handler->PSendSysMessage(LANG_COMMAND_GO_INSTANCE_FAILED, mapid, scriptname, exit->target_mapId); + handler->PSendSysMessage(LANG_COMMAND_GO_INSTANCE_FAILED, mapid, scriptname, exit ? exit->target_mapId : uint32(-1)); handler->SetSentErrorMessage(true); return false; } diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_algalon_the_observer.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_algalon_the_observer.cpp index bc15a119bf6..be00921d2b9 100644 --- a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_algalon_the_observer.cpp +++ b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_algalon_the_observer.cpp @@ -1159,7 +1159,7 @@ class spell_algalon_big_bang : public SpellScript AfterCast += SpellCastFn(spell_algalon_big_bang::CheckTargets); } private: - uint32 _targetCount; + uint32 _targetCount = 0; }; // 64445 - Remove Player from Phase diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp index e7e2a6d2b49..a51a3ce8cd2 100644 --- a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp +++ b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp @@ -955,7 +955,7 @@ class spell_xt002_exposed_heart : public AuraScript } private: - uint32 _damageAmount; + uint32 _damageAmount = 0; }; class achievement_nerf_engineering : public AchievementCriteriaScript diff --git a/src/server/scripts/Northrend/zone_dragonblight.cpp b/src/server/scripts/Northrend/zone_dragonblight.cpp index e06807b4b5b..8b7948e9088 100644 --- a/src/server/scripts/Northrend/zone_dragonblight.cpp +++ b/src/server/scripts/Northrend/zone_dragonblight.cpp @@ -565,9 +565,11 @@ class npc_wyrmrest_defender : public CreatureScript bool GossipSelect(Player* player, uint32 menuId, uint32 gossipListId) override { if (menuId == MENU_ID && gossipListId == GOSSIP_OPTION_ID) + { // Makes player cast trigger spell for 49207 on self player->CastSpell(player, SPELL_CHARACTER_SCRIPT, true); CloseGossipMenuFor(player); + } return true; } |
