diff options
| author | jackpoz <giacomopoz@gmail.com> | 2017-12-25 15:50:21 +0100 |
|---|---|---|
| committer | jackpoz <giacomopoz@gmail.com> | 2017-12-25 16:34:36 +0100 |
| commit | ad56299846a92c2cda84ebcc2d37d9aa6e3e8024 (patch) | |
| tree | 4ad77259e6b3cb1b5be227f425f710a75a045beb /src/server/scripts | |
| parent | cbc7642edd4a45068636adb98d74332837ab4c71 (diff) | |
Core/Misc: Fix static analysis issues
Diffstat (limited to 'src/server/scripts')
3 files changed, 2 insertions, 5 deletions
diff --git a/src/server/scripts/Northrend/zone_borean_tundra.cpp b/src/server/scripts/Northrend/zone_borean_tundra.cpp index 3e7c03becb8..e4b1dc046f9 100644 --- a/src/server/scripts/Northrend/zone_borean_tundra.cpp +++ b/src/server/scripts/Northrend/zone_borean_tundra.cpp @@ -2309,7 +2309,6 @@ public: charGossipItem = GOSSIP_ITEM_GUARD_MITCHELLS; break; default: - charGossipItem = ""; return false; } diff --git a/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_lurker_below.cpp b/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_lurker_below.cpp index 48123c81778..71408b14ddb 100644 --- a/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_lurker_below.cpp +++ b/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_lurker_below.cpp @@ -204,8 +204,7 @@ public: Submerged = false; WaitTimer2 = 500; } - - if (!Submerged && WaitTimer2 <= diff) // wait 500ms before emerge anim + else if (WaitTimer2 <= diff) // wait 500ms before emerge anim { me->RemoveAllAuras(); me->SetUInt32Value(UNIT_NPC_EMOTESTATE, 0); diff --git a/src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_omor_the_unscarred.cpp b/src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_omor_the_unscarred.cpp index 6da7007d42c..bcad390af06 100644 --- a/src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_omor_the_unscarred.cpp +++ b/src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_omor_the_unscarred.cpp @@ -204,8 +204,7 @@ class boss_omor_the_unscarred : public CreatureScript { if (Unit* target = SelectTarget(SELECT_TARGET_RANDOM, 0)) { - if (target) - target = me->GetVictim(); + target = me->GetVictim(); DoCast(target, SPELL_SHADOW_BOLT); Shadowbolt_Timer = 4000 + rand32() % 2500; |