aboutsummaryrefslogtreecommitdiff
path: root/src/server/scripts
diff options
context:
space:
mode:
authorShauren <shauren.trinity@gmail.com>2014-10-21 19:23:32 +0200
committerShauren <shauren.trinity@gmail.com>2025-09-28 21:38:32 +0200
commitd144724e2fd8a74a3e896751dc9c866b3932f815 (patch)
treee1f3c155560705bbd0f7dea15351b14602354454 /src/server/scripts
parent3059fcd70a01bccdf8ea6dd1ae7bedefd737d558 (diff)
Core/Entities: First batch of removing implicit conversions of ObjectGuid to uint64
(cherry picked from commit 9cc7044546eaaaf4fd7a999c5e074ad0ea3d47ef)
Diffstat (limited to 'src/server/scripts')
-rw-r--r--src/server/scripts/Battlefield/BattlefieldWG.cpp2
-rw-r--r--src/server/scripts/Commands/cs_character.cpp2
-rw-r--r--src/server/scripts/Commands/cs_debug.cpp8
-rw-r--r--src/server/scripts/Commands/cs_gobject.cpp3
-rw-r--r--src/server/scripts/Commands/cs_misc.cpp2
-rw-r--r--src/server/scripts/Commands/cs_npc.cpp2
-rw-r--r--src/server/scripts/Commands/cs_pet.cpp2
-rw-r--r--src/server/scripts/Commands/cs_reset.cpp2
-rw-r--r--src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/blackrock_depths.cpp2
-rw-r--r--src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/instance_blackrock_depths.cpp6
-rw-r--r--src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/instance_molten_core.cpp2
-rw-r--r--src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp2
-rw-r--r--src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp5
-rw-r--r--src/server/scripts/EasternKingdoms/ScarletEnclave/chapter2.cpp4
-rw-r--r--src/server/scripts/Events/childrens_week.cpp6
-rw-r--r--src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjalAI.cpp2
-rw-r--r--src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_cthun.cpp2
-rw-r--r--src/server/scripts/Kalimdor/TempleOfAhnQiraj/mob_anubisath_sentinel.cpp2
-rw-r--r--src/server/scripts/Kalimdor/zone_the_barrens.cpp4
-rw-r--r--src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheChampion/boss_grand_champions.cpp10
-rw-r--r--src/server/scripts/Northrend/IcecrownCitadel/boss_blood_prince_council.cpp2
-rw-r--r--src/server/scripts/Northrend/IcecrownCitadel/boss_blood_queen_lana_thel.cpp2
-rw-r--r--src/server/scripts/Northrend/Naxxramas/boss_maexxna.cpp2
-rw-r--r--src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp2
-rw-r--r--src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp2
-rw-r--r--src/server/scripts/OutdoorPvP/OutdoorPvPZM.cpp4
-rw-r--r--src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp2
-rw-r--r--src/server/scripts/Spells/spell_hunter.cpp4
-rw-r--r--src/server/scripts/World/npcs_special.cpp4
29 files changed, 49 insertions, 45 deletions
diff --git a/src/server/scripts/Battlefield/BattlefieldWG.cpp b/src/server/scripts/Battlefield/BattlefieldWG.cpp
index 9aa93d76ca1..559aa8c7d46 100644
--- a/src/server/scripts/Battlefield/BattlefieldWG.cpp
+++ b/src/server/scripts/Battlefield/BattlefieldWG.cpp
@@ -650,7 +650,7 @@ void BattlefieldWG::UpdateCounterVehicle(bool init)
void BattlefieldWG::OnBattleEnd(bool endByTimer)
{
// Remove relic
- if (m_titansRelicGUID)
+ if (!m_titansRelicGUID.IsEmpty())
if (GameObject* relic = GetGameObject(m_titansRelicGUID))
relic->RemoveFromWorld();
m_titansRelicGUID.Clear();
diff --git a/src/server/scripts/Commands/cs_character.cpp b/src/server/scripts/Commands/cs_character.cpp
index 6b8fa1b2093..5d33e5d6e98 100644
--- a/src/server/scripts/Commands/cs_character.cpp
+++ b/src/server/scripts/Commands/cs_character.cpp
@@ -218,7 +218,7 @@ public:
return;
}
- if (sCharacterCache->GetCharacterGuidByName(delInfo.name))
+ if (!sCharacterCache->GetCharacterGuidByName(delInfo.name).IsEmpty())
{
handler->PSendSysMessage(LANG_CHARACTER_DELETED_SKIP_NAME, delInfo.name.c_str(), delInfo.guid.GetCounter(), delInfo.accountId);
return;
diff --git a/src/server/scripts/Commands/cs_debug.cpp b/src/server/scripts/Commands/cs_debug.cpp
index cdd03bea274..b4331ce67bd 100644
--- a/src/server/scripts/Commands/cs_debug.cpp
+++ b/src/server/scripts/Commands/cs_debug.cpp
@@ -192,7 +192,7 @@ public:
return false;
}
- if (player->GetTarget())
+ if (!player->GetTarget().IsEmpty())
unit->PlayDistanceSound(soundId, player);
else
unit->PlayDirectSound(soundId, player);
@@ -421,15 +421,15 @@ public:
handler->SetSentErrorMessage(true);
return false;
}
- data << uint64(obj->GetGUID());
+ data << obj->GetGUID();
}
else if (type == "myguid")
{
- data << uint64(player->GetGUID());
+ data << player->GetGUID();
}
else if (type == "itsguid")
{
- data << uint64(unit->GetGUID());
+ data << unit->GetGUID();
}
else if (type == "itspos")
{
diff --git a/src/server/scripts/Commands/cs_gobject.cpp b/src/server/scripts/Commands/cs_gobject.cpp
index 38861797e85..0012bec5156 100644
--- a/src/server/scripts/Commands/cs_gobject.cpp
+++ b/src/server/scripts/Commands/cs_gobject.cpp
@@ -302,7 +302,8 @@ public:
if (GameObject* object = handler->GetObjectFromPlayerMapByDbGuid(spawnId))
{
Player const* const player = handler->GetSession()->GetPlayer();
- if (ObjectGuid ownerGuid = object->GetOwnerGUID())
+ ObjectGuid ownerGuid = object->GetOwnerGUID();
+ if (!ownerGuid.IsEmpty())
{
Unit* owner = ObjectAccessor::GetUnit(*player, ownerGuid);
if (!owner || !ownerGuid.IsPlayer())
diff --git a/src/server/scripts/Commands/cs_misc.cpp b/src/server/scripts/Commands/cs_misc.cpp
index 2f64f2b8f9d..f6df2fdec40 100644
--- a/src/server/scripts/Commands/cs_misc.cpp
+++ b/src/server/scripts/Commands/cs_misc.cpp
@@ -1954,7 +1954,7 @@ public:
Player* player = handler->GetSession()->GetPlayer();
// accept only explicitly selected target (not implicitly self targeting case)
- Creature* target = player->GetTarget() ? handler->getSelectedCreature() : nullptr;
+ Creature* target = !player->GetTarget().IsEmpty() ? handler->getSelectedCreature() : nullptr;
if (target)
{
if (target->IsPet())
diff --git a/src/server/scripts/Commands/cs_npc.cpp b/src/server/scripts/Commands/cs_npc.cpp
index 15150eea1c5..99a5a524a2c 100644
--- a/src/server/scripts/Commands/cs_npc.cpp
+++ b/src/server/scripts/Commands/cs_npc.cpp
@@ -1024,7 +1024,7 @@ public:
Player* player = handler->GetSession()->GetPlayer();
- if (player->GetPetGUID())
+ if (!player->GetPetGUID().IsEmpty())
{
handler->SendSysMessage (LANG_YOU_ALREADY_HAVE_PET);
handler->SetSentErrorMessage (true);
diff --git a/src/server/scripts/Commands/cs_pet.cpp b/src/server/scripts/Commands/cs_pet.cpp
index 072cc68db78..f7d29622604 100644
--- a/src/server/scripts/Commands/cs_pet.cpp
+++ b/src/server/scripts/Commands/cs_pet.cpp
@@ -86,7 +86,7 @@ public:
return false;
}
- if (player->GetPetGUID())
+ if (!player->GetPetGUID().IsEmpty())
{
handler->PSendSysMessage("You already have a pet");
handler->SetSentErrorMessage(true);
diff --git a/src/server/scripts/Commands/cs_reset.cpp b/src/server/scripts/Commands/cs_reset.cpp
index 3b357fcde23..a6ef3c57b15 100644
--- a/src/server/scripts/Commands/cs_reset.cpp
+++ b/src/server/scripts/Commands/cs_reset.cpp
@@ -250,7 +250,7 @@ public:
target->SendTalentsInfoData(true);
return true;
}
- else if (targetGuid)
+ else if (!targetGuid.IsEmpty())
{
CharacterDatabasePreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_UPD_ADD_AT_LOGIN_FLAG);
stmt->setUInt16(0, uint16(AT_LOGIN_NONE | AT_LOGIN_RESET_PET_TALENTS));
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/blackrock_depths.cpp b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/blackrock_depths.cpp
index 38a066f751c..23d89a2ec1e 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/blackrock_depths.cpp
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/blackrock_depths.cpp
@@ -247,7 +247,7 @@ public:
{
MobDeath_Timer = 2500;
- if (RingBossGUID)
+ if (!RingBossGUID.IsEmpty())
{
Creature* boss = ObjectAccessor::GetCreature(*me, RingBossGUID);
if (boss && !boss->IsAlive() && boss->isDead())
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/instance_blackrock_depths.cpp b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/instance_blackrock_depths.cpp
index a7c359818e1..9b49430b5c4 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/instance_blackrock_depths.cpp
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/BlackrockDepths/instance_blackrock_depths.cpp
@@ -374,7 +374,7 @@ public:
void TombOfSevenEvent()
{
- if (GhostKillCount < TOMB_OF_SEVEN_BOSS_NUM && TombBossGUIDs[TombEventCounter])
+ if (GhostKillCount < TOMB_OF_SEVEN_BOSS_NUM && !TombBossGUIDs[TombEventCounter].IsEmpty())
{
if (Creature* boss = instance->GetCreature(TombBossGUIDs[TombEventCounter]))
{
@@ -425,7 +425,7 @@ public:
void Update(uint32 diff) override
{
- if (TombEventStarterGUID && GhostKillCount < TOMB_OF_SEVEN_BOSS_NUM)
+ if (!TombEventStarterGUID.IsEmpty() && GhostKillCount < TOMB_OF_SEVEN_BOSS_NUM)
{
if (TombTimer <= diff)
{
@@ -449,7 +449,7 @@ public:
}
} else TombTimer -= diff;
}
- if (GhostKillCount >= TOMB_OF_SEVEN_BOSS_NUM && TombEventStarterGUID)
+ if (GhostKillCount >= TOMB_OF_SEVEN_BOSS_NUM && !TombEventStarterGUID.IsEmpty())
TombOfSevenEnd();
}
};
diff --git a/src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/instance_molten_core.cpp b/src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/instance_molten_core.cpp
index 970b55aafe9..c5492c7ef91 100644
--- a/src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/instance_molten_core.cpp
+++ b/src/server/scripts/EasternKingdoms/BlackrockMountain/MoltenCore/instance_molten_core.cpp
@@ -141,7 +141,7 @@ class instance_molten_core : public InstanceMapScript
void SummonMajordomoExecutus()
{
_executusSchedule = false;
- if (_majordomoExecutusGUID)
+ if (!_majordomoExecutusGUID.IsEmpty())
return;
if (GetBossState(BOSS_MAJORDOMO_EXECUTUS) != DONE)
diff --git a/src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp b/src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp
index 03b3373179e..d7d44e016bc 100644
--- a/src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp
+++ b/src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp
@@ -260,7 +260,7 @@ class instance_deadmines : public InstanceMapScript
switch (type)
{
case EVENT_STATE:
- if (DefiasCannonGUID && IronCladDoorGUID)
+ if (!DefiasCannonGUID.IsEmpty() && !IronCladDoorGUID.IsEmpty())
State = data;
break;
}
diff --git a/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp b/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp
index a67d266d288..de53991fef5 100644
--- a/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp
+++ b/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter1.cpp
@@ -336,9 +336,12 @@ class go_acherus_soul_prison : public GameObjectScript
bool OnGossipHello(Player* player) override
{
if (Creature* anchor = me->FindNearestCreature(29521, 15))
- if (ObjectGuid prisonerGUID = anchor->AI()->GetGUID())
+ {
+ ObjectGuid prisonerGUID = anchor->AI()->GetGUID();
+ if (!prisonerGUID.IsEmpty())
if (Creature* prisoner = ObjectAccessor::GetCreature(*player, prisonerGUID))
ENSURE_AI(npc_unworthy_initiate::npc_unworthy_initiateAI, prisoner->AI())->EventStart(anchor, player);
+ }
return false;
}
diff --git a/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter2.cpp b/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter2.cpp
index f50d6c03f3a..cba23ee98e0 100644
--- a/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter2.cpp
+++ b/src/server/scripts/EasternKingdoms/ScarletEnclave/chapter2.cpp
@@ -531,7 +531,7 @@ public:
void MoveInLineOfSight(Unit* who) override
{
- if (PlayerGUID || who->GetTypeId() != TYPEID_PLAYER || !who->IsWithinDist(me, INTERACTION_DISTANCE))
+ if (!PlayerGUID.IsEmpty() || who->GetTypeId() != TYPEID_PLAYER || !who->IsWithinDist(me, INTERACTION_DISTANCE))
return;
if (MeetQuestCondition(who->ToPlayer()))
@@ -540,7 +540,7 @@ public:
void UpdateAI(uint32 diff) override
{
- if (PlayerGUID && !me->GetVictim() && me->IsAlive())
+ if (!PlayerGUID.IsEmpty() && !me->GetVictim() && me->IsAlive())
{
if (ExecuteSpeech_Timer <= diff)
{
diff --git a/src/server/scripts/Events/childrens_week.cpp b/src/server/scripts/Events/childrens_week.cpp
index 1f06eb6bb82..c283c3bd40e 100644
--- a/src/server/scripts/Events/childrens_week.cpp
+++ b/src/server/scripts/Events/childrens_week.cpp
@@ -982,7 +982,7 @@ class at_bring_your_orphan_to : public AreaTriggerScript
break;
}
- if (questId && orphanId && getOrphanGUID(player, orphanId) && player->GetQuestStatus(questId) == QUEST_STATUS_INCOMPLETE)
+ if (questId && orphanId && !getOrphanGUID(player, orphanId).IsEmpty() && player->GetQuestStatus(questId) == QUEST_STATUS_INCOMPLETE)
player->AreaExploredOrEventHappens(questId);
return true;
@@ -1043,7 +1043,7 @@ class npc_cw_area_trigger : public CreatureScript
orphanId = ORPHAN_BLOOD_ELF;
break;
case NPC_SILVERMOON_01_CW_TRIGGER:
- if (player->GetQuestStatus(QUEST_NOW_WHEN_I_GROW_UP) == QUEST_STATUS_INCOMPLETE && getOrphanGUID(player, ORPHAN_BLOOD_ELF))
+ if (player->GetQuestStatus(QUEST_NOW_WHEN_I_GROW_UP) == QUEST_STATUS_INCOMPLETE && !getOrphanGUID(player, ORPHAN_BLOOD_ELF).IsEmpty())
{
player->AreaExploredOrEventHappens(QUEST_NOW_WHEN_I_GROW_UP);
if (player->GetQuestStatus(QUEST_NOW_WHEN_I_GROW_UP) == QUEST_STATUS_COMPLETE)
@@ -1062,7 +1062,7 @@ class npc_cw_area_trigger : public CreatureScript
}
break;
}
- if (questId && orphanId && getOrphanGUID(player, orphanId) && player->GetQuestStatus(questId) == QUEST_STATUS_INCOMPLETE)
+ if (questId && orphanId && !getOrphanGUID(player, orphanId).IsEmpty() && player->GetQuestStatus(questId) == QUEST_STATUS_INCOMPLETE)
player->AreaExploredOrEventHappens(questId);
}
}
diff --git a/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjalAI.cpp b/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjalAI.cpp
index b60826b64c1..ebb2495d95b 100644
--- a/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjalAI.cpp
+++ b/src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/hyjalAI.cpp
@@ -939,7 +939,7 @@ void hyjalAI::WaypointReached(uint32 waypointId, uint32 /*pathId*/)
TeleportTimer = 20000;
if (me->GetEntry() == JAINA)
DoCast(me, SPELL_MASS_TELEPORT, false);
- if (me->GetEntry() == THRALL && DummyGuid)
+ if (me->GetEntry() == THRALL && !DummyGuid.IsEmpty())
{
if (Creature* creature = ObjectAccessor::GetCreature(*me, DummyGuid))
{
diff --git a/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_cthun.cpp b/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_cthun.cpp
index 5eda5bcbd93..7497a5b3318 100644
--- a/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_cthun.cpp
+++ b/src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_cthun.cpp
@@ -757,7 +757,7 @@ public:
StomachEnterTimer = 13800;
} else StomachEnterTimer -= diff;
- if (StomachEnterVisTimer && StomachEnterTarget)
+ if (StomachEnterVisTimer && !StomachEnterTarget.IsEmpty())
{
if (StomachEnterVisTimer <= diff)
{
diff --git a/src/server/scripts/Kalimdor/TempleOfAhnQiraj/mob_anubisath_sentinel.cpp b/src/server/scripts/Kalimdor/TempleOfAhnQiraj/mob_anubisath_sentinel.cpp
index f6af15361ac..a7c085ee9ad 100644
--- a/src/server/scripts/Kalimdor/TempleOfAhnQiraj/mob_anubisath_sentinel.cpp
+++ b/src/server/scripts/Kalimdor/TempleOfAhnQiraj/mob_anubisath_sentinel.cpp
@@ -124,7 +124,7 @@ public:
{
aqsentinelAI* cai = ENSURE_AI(aqsentinelAI, (c)->AI());
for (int32 i = 0; i < 3; ++i)
- if (NearbyGUID[i] && NearbyGUID[i] != c->GetGUID())
+ if (!NearbyGUID[i].IsEmpty() && NearbyGUID[i] != c->GetGUID())
cai->AddBuddyToList(NearbyGUID[i]);
cai->AddBuddyToList(me->GetGUID());
}
diff --git a/src/server/scripts/Kalimdor/zone_the_barrens.cpp b/src/server/scripts/Kalimdor/zone_the_barrens.cpp
index 798ee849699..3019c728530 100644
--- a/src/server/scripts/Kalimdor/zone_the_barrens.cpp
+++ b/src/server/scripts/Kalimdor/zone_the_barrens.cpp
@@ -413,7 +413,7 @@ public:
if (WaveTimer <= diff)
{
- if (Wave < 6 && AffrayChallenger[Wave] && !EventBigWill)
+ if (Wave < 6 && !AffrayChallenger[Wave].IsEmpty() && !EventBigWill)
{
Talk(SAY_TWIGGY_FLATHEAD_FRAY);
Creature* creature = ObjectAccessor::GetCreature(*me, AffrayChallenger[Wave]);
@@ -441,7 +441,7 @@ public:
WaveTimer = 1000;
}
}
- else if (Wave >= 6 && EventBigWill && BigWill)
+ else if (Wave >= 6 && EventBigWill && !BigWill.IsEmpty())
{
Creature* creature = ObjectAccessor::GetCreature(*me, BigWill);
if (!creature || !creature->IsAlive())
diff --git a/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheChampion/boss_grand_champions.cpp b/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheChampion/boss_grand_champions.cpp
index 2a32a48fcfb..3a789907f56 100644
--- a/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheChampion/boss_grand_champions.cpp
+++ b/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheChampion/boss_grand_champions.cpp
@@ -395,7 +395,7 @@ public:
}
}else uiPhaseTimer -= uiDiff;
- if (!UpdateVictim() || me->HasUnitMovementFlag(MOVEMENTFLAG_ONTRANSPORT))
+ if (!UpdateVictim() || !me->m_movementInfo.transport.guid.IsEmpty())
return;
if (uiInterceptTimer <= uiDiff)
@@ -544,7 +544,7 @@ public:
uiFireBallTimer = 5000;
} else uiFireBallTimer -= uiDiff;
- if (!UpdateVictim() || me->HasUnitMovementFlag(MOVEMENTFLAG_ONTRANSPORT))
+ if (!UpdateVictim() || !me->m_movementInfo.transport.guid.IsEmpty())
return;
if (uiFireBallTimer <= uiDiff)
@@ -687,7 +687,7 @@ public:
}
}else uiPhaseTimer -= uiDiff;
- if (!UpdateVictim() || me->HasUnitMovementFlag(MOVEMENTFLAG_ONTRANSPORT))
+ if (!UpdateVictim() || !me->m_movementInfo.transport.guid.IsEmpty())
return;
if (uiChainLightningTimer <= uiDiff)
@@ -838,7 +838,7 @@ public:
}
}else uiPhaseTimer -= uiDiff;
- if (!UpdateVictim() || me->HasUnitMovementFlag(MOVEMENTFLAG_ONTRANSPORT))
+ if (!UpdateVictim() || !me->m_movementInfo.transport.guid.IsEmpty())
return;
if (uiLightningArrowsTimer <= uiDiff)
@@ -991,7 +991,7 @@ public:
}
} else uiPhaseTimer -= uiDiff;
- if (!UpdateVictim() || me->HasUnitMovementFlag(MOVEMENTFLAG_ONTRANSPORT))
+ if (!UpdateVictim() || !me->m_movementInfo.transport.guid.IsEmpty())
return;
if (uiEviscerateTimer <= uiDiff)
diff --git a/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_prince_council.cpp b/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_prince_council.cpp
index c75a4f5ba0a..23db90dff61 100644
--- a/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_prince_council.cpp
+++ b/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_prince_council.cpp
@@ -932,7 +932,7 @@ struct npc_ball_of_flame : public ScriptedAI
void MovementInform(uint32 type, uint32 id) override
{
- if (type == CHASE_MOTION_TYPE && id == _chaseGUID.GetCounter() && _chaseGUID)
+ if (type == CHASE_MOTION_TYPE && id == _chaseGUID.GetCounter() && !_chaseGUID.IsEmpty())
{
me->RemoveAurasDueToSpell(SPELL_BALL_OF_FLAMES_PERIODIC);
DoCastSelf(SPELL_FLAMES);
diff --git a/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_queen_lana_thel.cpp b/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_queen_lana_thel.cpp
index b1cba9ac525..f8f58bc7172 100644
--- a/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_queen_lana_thel.cpp
+++ b/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_queen_lana_thel.cpp
@@ -401,7 +401,7 @@ struct boss_blood_queen_lana_thel : public BossAI
break;
}
case EVENT_DELIRIOUS_SLASH:
- if (_offtankGUID && me->GetAnimTier() != AnimTier::Fly)
+ if (!_offtankGUID.IsEmpty() && me->GetAnimTier() != AnimTier::Fly)
if (Player* _offtank = ObjectAccessor::GetPlayer(*me, _offtankGUID))
DoCast(_offtank, SPELL_DELIRIOUS_SLASH);
events.ScheduleEvent(EVENT_DELIRIOUS_SLASH, 20s, 24s, EVENT_GROUP_NORMAL);
diff --git a/src/server/scripts/Northrend/Naxxramas/boss_maexxna.cpp b/src/server/scripts/Northrend/Naxxramas/boss_maexxna.cpp
index a0824886d4a..3ec7c8f8325 100644
--- a/src/server/scripts/Northrend/Naxxramas/boss_maexxna.cpp
+++ b/src/server/scripts/Northrend/Naxxramas/boss_maexxna.cpp
@@ -219,7 +219,7 @@ struct npc_webwrap : public NullCreatureAI
void JustDied(Unit* /*killer*/) override
{
- if (victimGUID)
+ if (!victimGUID.IsEmpty())
if (Unit* victim = ObjectAccessor::GetUnit(*me, victimGUID))
victim->RemoveAurasDueToSpell(SPELL_WEB_WRAP, me->GetGUID());
diff --git a/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp b/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp
index d39fe832d1d..21e2f236b8e 100644
--- a/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp
+++ b/src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp
@@ -1781,7 +1781,7 @@ class spell_scion_of_eternity_arcane_barrage : public SpellScript
// in longer terms this means if spell picks target X then 2nd cast of this spell will pick smth else
// and if 3rd picks X again 4th will pick smth else (by not limiting the cast to certain caster).
if (targets.size() > 1)
- if (malygos && malygos->AI()->GetGUID(DATA_LAST_TARGET_BARRAGE_GUID))
+ if (malygos && !malygos->AI()->GetGUID(DATA_LAST_TARGET_BARRAGE_GUID).IsEmpty())
targets.remove_if(Trinity::ObjectGUIDCheck(malygos->AI()->GetGUID(DATA_LAST_TARGET_BARRAGE_GUID)));
// Remove players not on Hover Disk from second list
diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp
index 518ff37bfeb..a2bfddfa98e 100644
--- a/src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp
+++ b/src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp
@@ -940,7 +940,7 @@ class instance_ulduar : public InstanceMapScript
data << ColossusData << ' ' << _algalonTimer << ' ' << uint32(_algalonSummoned ? 1 : 0);
for (uint8 i = 0; i < 4; ++i)
- data << ' ' << uint32(KeeperGUIDs[i] ? 1 : 0);
+ data << ' ' << uint32(!KeeperGUIDs[i].IsEmpty() ? 1 : 0);
data << ' ' << _CoUAchivePlayerDeathMask;
}
diff --git a/src/server/scripts/OutdoorPvP/OutdoorPvPZM.cpp b/src/server/scripts/OutdoorPvP/OutdoorPvPZM.cpp
index 2fa84167245..f65c00fcbb1 100644
--- a/src/server/scripts/OutdoorPvP/OutdoorPvPZM.cpp
+++ b/src/server/scripts/OutdoorPvP/OutdoorPvPZM.cpp
@@ -335,7 +335,7 @@ void OPvPCapturePointZM_Graveyard::SetBeaconState(uint32 controlling_faction)
if (m_GraveyardState & ZM_GRAVEYARD_N)
{
// gy was neutral, thus neutral banner was spawned, it is possible that someone was taking the flag to the gy
- if (m_FlagCarrierGUID)
+ if (!m_FlagCarrierGUID.IsEmpty())
{
// remove flag from carrier, reset flag carrier guid
Player* p = ObjectAccessor::FindPlayer(m_FlagCarrierGUID);
@@ -374,7 +374,7 @@ bool OPvPCapturePointZM_Graveyard::HandleGossipOption(Player* player, Creature*
if (itr != m_CreatureTypes.end())
{
// if the flag is already taken, then return
- if (m_FlagCarrierGUID)
+ if (!m_FlagCarrierGUID.IsEmpty())
return true;
if (itr->second == ZM_ALLIANCE_FIELD_SCOUT)
{
diff --git a/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp b/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp
index 1b73683d0a5..fe9bd6da08f 100644
--- a/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp
+++ b/src/server/scripts/Outland/CoilfangReservoir/SerpentShrine/boss_leotheras_the_blind.cpp
@@ -306,7 +306,7 @@ struct boss_leotheras_the_blind : public BossAI
// and reseting equipment
me->LoadEquipment();
- if (instance->GetGuidData(DATA_LEOTHERAS_EVENT_STARTER))
+ if (!instance->GetGuidData(DATA_LEOTHERAS_EVENT_STARTER).IsEmpty())
{
if (Unit* victim = ObjectAccessor::GetUnit(*me, instance->GetGuidData(DATA_LEOTHERAS_EVENT_STARTER)))
AddThreat(victim, 1);
diff --git a/src/server/scripts/Spells/spell_hunter.cpp b/src/server/scripts/Spells/spell_hunter.cpp
index 623822f112c..db48a98343e 100644
--- a/src/server/scripts/Spells/spell_hunter.cpp
+++ b/src/server/scripts/Spells/spell_hunter.cpp
@@ -1175,10 +1175,10 @@ class spell_hun_tame_beast : public SpellScript
}
}
- if (caster->GetCharmedGUID())
+ if (!caster->GetCharmedGUID().IsEmpty())
return SPELL_FAILED_ALREADY_HAVE_CHARM;
- if (target->GetOwnerGUID())
+ if (!target->GetOwnerGUID().IsEmpty())
{
caster->SendTameFailure(PETTAME_CREATUREALREADYOWNED);
return SPELL_FAILED_DONT_REPORT;
diff --git a/src/server/scripts/World/npcs_special.cpp b/src/server/scripts/World/npcs_special.cpp
index df0e4b1e3e8..992162938c0 100644
--- a/src/server/scripts/World/npcs_special.cpp
+++ b/src/server/scripts/World/npcs_special.cpp
@@ -803,7 +803,7 @@ public:
return;
if (player->GetQuestStatus(6624) == QUEST_STATUS_INCOMPLETE || player->GetQuestStatus(6622) == QUEST_STATUS_INCOMPLETE)
- if (DoctorGUID)
+ if (!DoctorGUID.IsEmpty())
if (Creature* doctor = ObjectAccessor::GetCreature(*me, DoctorGUID))
ENSURE_AI(npc_doctor::npc_doctorAI, doctor->AI())->PatientSaved(me, player, Coord);
@@ -849,7 +849,7 @@ public:
me->setDeathState(JUST_DIED);
me->SetDynamicFlag(32);
- if (DoctorGUID)
+ if (!DoctorGUID.IsEmpty())
if (Creature* doctor = ObjectAccessor::GetCreature((*me), DoctorGUID))
ENSURE_AI(npc_doctor::npc_doctorAI, doctor->AI())->PatientDied(Coord);
}