diff options
author | jackpoz <giacomopoz@gmail.com> | 2014-03-22 14:54:32 +0100 |
---|---|---|
committer | jackpoz <giacomopoz@gmail.com> | 2014-03-22 14:54:32 +0100 |
commit | 6dcd8c8545a65a7bfbd0daaa16f650d8c3a90262 (patch) | |
tree | 522298afe00a5e52f0013de09b740818112f06d5 /src/server/shared/Database/AdhocStatement.cpp | |
parent | 409f4bffd59af41e1d75b4fb4d2bef038eea9552 (diff) |
Core/Misc: Fix some static analysis issues
Fix some static analysis issues about:
- uninitialized values, most of which are false positives, always initialized before being accessed
- unchecked return values
- dead code never executed
- bad formatting leading to wrong behavior
Please ensure EventMap is never used with event id set to 0 or those events will never execute.
Diffstat (limited to 'src/server/shared/Database/AdhocStatement.cpp')
-rw-r--r-- | src/server/shared/Database/AdhocStatement.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/server/shared/Database/AdhocStatement.cpp b/src/server/shared/Database/AdhocStatement.cpp index 15732f20849..896fefde5b7 100644 --- a/src/server/shared/Database/AdhocStatement.cpp +++ b/src/server/shared/Database/AdhocStatement.cpp @@ -42,13 +42,13 @@ bool BasicStatementTask::Execute() if (m_has_result) { ResultSet* result = m_conn->Query(m_sql); - if (!result || !result->GetRowCount()) + if (!result || !result->GetRowCount() || !result->NextRow()) { delete result; m_result.set(QueryResult(NULL)); return false; } - result->NextRow(); + m_result.set(QueryResult(result)); return true; } |