aboutsummaryrefslogtreecommitdiff
path: root/src/server/shared/Database/QueryHolder.cpp
diff options
context:
space:
mode:
authorjackpoz <giacomopoz@gmail.com>2014-03-22 14:54:32 +0100
committerjackpoz <giacomopoz@gmail.com>2014-03-22 14:54:32 +0100
commit6dcd8c8545a65a7bfbd0daaa16f650d8c3a90262 (patch)
tree522298afe00a5e52f0013de09b740818112f06d5 /src/server/shared/Database/QueryHolder.cpp
parent409f4bffd59af41e1d75b4fb4d2bef038eea9552 (diff)
Core/Misc: Fix some static analysis issues
Fix some static analysis issues about: - uninitialized values, most of which are false positives, always initialized before being accessed - unchecked return values - dead code never executed - bad formatting leading to wrong behavior Please ensure EventMap is never used with event id set to 0 or those events will never execute.
Diffstat (limited to 'src/server/shared/Database/QueryHolder.cpp')
-rw-r--r--src/server/shared/Database/QueryHolder.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/server/shared/Database/QueryHolder.cpp b/src/server/shared/Database/QueryHolder.cpp
index 0c80f70acd2..7b4105ee076 100644
--- a/src/server/shared/Database/QueryHolder.cpp
+++ b/src/server/shared/Database/QueryHolder.cpp
@@ -89,10 +89,9 @@ QueryResult SQLQueryHolder::GetResult(size_t index)
if (index < m_queries.size())
{
ResultSet* result = m_queries[index].second.qresult;
- if (!result || !result->GetRowCount())
+ if (!result || !result->GetRowCount() || !result->NextRow())
return QueryResult(NULL);
- result->NextRow();
return QueryResult(result);
}
else