DB Layer:

- Make SQL Transactions actual objects used in code. (Thanks to Derex for the idea)
* Uncommitted transactions will be automatically rolled back and cleaned up using ACE_Refcounted_Auto_Ptr, so no need to call Rollback() in the code.
* Prevents recursive transactions and makes developers aware of transactions going on.
* Gets rid of unneccesary overhead iterating over a concurrent map.
- Some cleanups in affected code, including better usage of transaction control in AH / mail related code to prevent data loss.

*** Experimental, use at own risk, recommended to backup your DBs. ***

--HG--
branch : trunk

1 files changed, 59 insertions, 0 deletions

diff --git a/src/server/shared/Database/Transaction.h b/src/server/shared/Database/Transaction.h
new file mode 100644
index 00000000000..e94ca053e32
--- /dev/null
+++ b/src/server/shared/Database/Transaction.h
@@ -0,0 +1,59 @@
+/*
+ * Copyright (C) 2008-2010 Trinity <http://www.trinitycore.org/>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ */
+
+#ifndef _TRANSACTION_H
+#define _TRANSACTION_H
+
+/*! Transactions, high level class. */
+class Transaction
+{
+    friend class TransactionTask;
+    public:
+        ~Transaction() { Cleanup(); }
+
+        void Append(const char* sql);
+        void PAppend(const char* sql, ...);
+    
+        size_t GetSize() { return m_queries.size(); }
+
+    protected:
+        void Cleanup();
+        std::queue<char*> m_queries;
+
+    private:
+        bool m_actioned;
+};
+typedef ACE_Refcounted_Auto_Ptr<Transaction, ACE_Null_Mutex> SQLTransaction;
+
+/*! Low level class*/
+class TransactionTask : public SQLOperation
+{
+    friend class DatabaseWorkerPool;
+    friend class DatabaseWorker;
+
+    public:
+        TransactionTask(SQLTransaction trans) : m_trans(trans) {} ;
+        ~TransactionTask(){};
+
+    protected:
+        bool Execute();
+
+        SQLTransaction m_trans;
+};
+
+#endif
\ No newline at end of file