Scripts/ScarletMonastery: instance script cleanup (#23889)

Adapt InstanceScript into newer structure and style
Adapt existing boss scripts into newer structure and style
Improve existing boss related definitions

Should make each boss more functionally reliable, but nothing new has been added

(cherry picked from commit 06c6b30ed484850228c57313dc2c024c38e2055f)

1 files changed, 20 insertions, 18 deletions

diff --git a/src/server/shared/Dynamic/LinkedReference/RefManager.h b/src/server/shared/Dynamic/LinkedReference/RefManager.h
index abacf4923b4..5661b5dc95e 100644
--- a/src/server/shared/Dynamic/LinkedReference/RefManager.h
+++ b/src/server/shared/Dynamic/LinkedReference/RefManager.h
@@ -17,7 +17,6 @@
 
 #ifndef _REFMANAGER_H
 #define _REFMANAGER_H
-//=====================================================
 
 #include "Dynamic/LinkedList.h"
 #include "Dynamic/LinkedReference/Reference.h"
@@ -25,28 +24,31 @@
 template <class TO, class FROM>
 class RefManager : public LinkedListHead
 {
-    public:
-        typedef LinkedListHead::Iterator<Reference<TO, FROM>> iterator;
-        RefManager() { }
+public:
+    typedef LinkedListHead::Iterator<Reference<TO, FROM>> iterator;
+    typedef LinkedListHead::Iterator<Reference<TO, FROM> const> const_iterator;
+    RefManager() { }
 
-        Reference<TO, FROM>* getFirst()             { return static_cast<Reference<TO, FROM>*>(LinkedListHead::getFirst()); }
+    Reference<TO, FROM>* getFirst() { return static_cast<Reference<TO, FROM>*>(LinkedListHead::getFirst()); }
 
-        Reference<TO, FROM> const* getFirst() const { return static_cast<Reference<TO, FROM> const*>(LinkedListHead::getFirst()); }
+    Reference<TO, FROM> const* getFirst() const { return static_cast<Reference<TO, FROM> const*>(LinkedListHead::getFirst()); }
 
-        iterator begin() { return iterator(getFirst()); }
-        iterator end()   { return iterator(nullptr); }
+    iterator begin() { return iterator(getFirst()); }
+    iterator end() { return iterator(nullptr); }
 
-        virtual ~RefManager()
-        {
-            clearReferences();
-        }
+    const_iterator begin() const { return const_iterator(getFirst()); }
+    const_iterator end() const { return const_iterator(nullptr); }
 
-        void clearReferences()
-        {
-            while (Reference<TO, FROM>* ref = getFirst())
-                ref->invalidate();
-        }
+    virtual ~RefManager()
+    {
+        clearReferences();
+    }
+
+    void clearReferences()
+    {
+        while (Reference<TO, FROM>* ref = getFirst())
+            ref->invalidate();
+    }
 };
 
-//=====================================================
 #endif