diff options
author | jackpoz <giacomopoz@gmail.com> | 2015-03-02 22:16:44 +0100 |
---|---|---|
committer | Nayd <dnpd.dd@gmail.com> | 2015-03-18 00:10:02 +0000 |
commit | 064b6a4c84cb153e6d03aa5f7d2157baa98ec909 (patch) | |
tree | 14a82a61b92825b6eddfbbf9f44304d7d3c1d6e6 /src/server/shared/Logging/Log.h | |
parent | 034dbe267df49b98448e9000c7c534619612bdbc (diff) |
Shared/Logs: Improve log performances
Improve Log::ShouldLog() performances by saving the lowest log level across all loggers and discarding any log with lower level than that.
(cherry picked from commit 003d67708b9a279da3d37e5ef06eb32ceab53964)
Diffstat (limited to 'src/server/shared/Logging/Log.h')
-rw-r--r-- | src/server/shared/Logging/Log.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/server/shared/Logging/Log.h b/src/server/shared/Logging/Log.h index 1d67ff87f76..408381620f7 100644 --- a/src/server/shared/Logging/Log.h +++ b/src/server/shared/Logging/Log.h @@ -82,6 +82,7 @@ class Log AppenderMap appenders; LoggerMap loggers; uint8 AppenderId; + LogLevel lowestLogLevel; std::string m_logsDir; std::string m_logsTimestamp; @@ -113,6 +114,10 @@ inline bool Log::ShouldLog(std::string const& type, LogLevel level) const // Speed up in cases where requesting "Type.sub1.sub2" but only configured // Logger "Type" + // Don't even look for a logger if the LogLevel is lower than lowest log levels across all loggers + if (level < lowestLogLevel) + return false; + Logger const* logger = GetLoggerByType(type); if (!logger) return false; |