Core/Logging: Remove recently added "outOpCode" with outInfo(LOG_FILTER_OPCODE... (There is no need to create new function)

Also, set config options to behave like old log system by default

3 files changed, 14 insertions, 16 deletions

diff --git a/src/server/shared/Logging/Appender.cpp b/src/server/shared/Logging/Appender.cpp
index 7950e045201..348ec4b3c7c 100644
--- a/src/server/shared/Logging/Appender.cpp
+++ b/src/server/shared/Logging/Appender.cpp
@@ -98,7 +98,7 @@ void Appender::write(LogMessage& message)
             message.prefix.push_back(' ');
 
         char text[MAX_QUERY_LEN];
-        snprintf(text, MAX_QUERY_LEN, "[%-15s]", Appender::getLogFilterTypeString(message.type));
+        snprintf(text, MAX_QUERY_LEN, "[%s]", Appender::getLogFilterTypeString(message.type));
         message.prefix.append(text);
     }
 
@@ -172,13 +172,13 @@ char const* Appender::getLogFilterTypeString(LogFilterType type)
         case LOG_FILTER_PLAYER:
             return "PLAYER";
         case LOG_FILTER_PLAYER_LOADING:
-            return "PLAYER_LOADING";
+            return "PLAYER LOADING";
         case LOG_FILTER_PLAYER_ITEMS:
-            return "PLAYER_ITEMS";
+            return "PLAYER ITEMS";
         case LOG_FILTER_PLAYER_SKILLS:
-            return "PLAYER_SKILLS";
+            return "PLAYER SKILLS";
         case LOG_FILTER_PLAYER_CHATLOG:
-            return "PLAYER_CHATLOG";
+            return "PLAYER CHATLOG";
         case LOG_FILTER_LOOT:
             return "LOOT";
         case LOG_FILTER_GUILD:
@@ -209,8 +209,14 @@ char const* Appender::getLogFilterTypeString(LogFilterType type)
             return "SQL DRIVER";
         case LOG_FILTER_SQL_DEV:
             return "SQL DEV";
+        case LOG_FILTER_PLAYER_DUMP:
+            return "PLAYER DUMP";
+        case LOG_FILTER_BATTLEFIELD:
+            return "BATTLEFIELD";
+        case LOG_FILTER_SERVER_LOADING:
+            return "SERVER LOADING";
         case LOG_FILTER_OPCODES:
-            return "OPCODES";
+            return "OPCODE";
         default:
             break;
     }
diff --git a/src/server/shared/Logging/Appender.h b/src/server/shared/Logging/Appender.h
index 56662bbee15..09ec8bfd081 100644
--- a/src/server/shared/Logging/Appender.h
+++ b/src/server/shared/Logging/Appender.h
@@ -65,12 +65,12 @@ enum LogFilterType
     LOG_FILTER_SQL_DEV,
     LOG_FILTER_PLAYER_DUMP,
     LOG_FILTER_BATTLEFIELD,
-    LOG_FILTER_OPCODES,
+    LOG_FILTER_SERVER_LOADING,
+    LOG_FILTER_OPCODES
 };
 
 const uint8 MaxLogFilter = uint8(LOG_FILTER_OPCODES) + 1;
 
-
 // Values assigned have their equivalent in enum ACE_Log_Priority
 enum LogLevel
 {
diff --git a/src/server/shared/Logging/Log.cpp b/src/server/shared/Logging/Log.cpp
index 82fb5b9461e..8e740ba83b8 100644
--- a/src/server/shared/Logging/Log.cpp
+++ b/src/server/shared/Logging/Log.cpp
@@ -486,14 +486,6 @@ void Log::outCommand(uint32 account, const char * str, ...)
     write(msg);
 }
 
-void Log::outOpCode(uint32 op, const char* name, bool smsg)
-{
-    if (!ShouldLog(LOG_FILTER_OPCODES, LOG_LEVEL_DEBUG))
-        return;
-
-    outInfo(LOG_FILTER_OPCODES, "%s: %s 0x%.4X (%u)", smsg ? "S->C" : "C->S", name, op, op);
-}
-
 void Log::SetRealmID(uint32 id)
 {
     realm = id;