Fix a possible crash in SqlTransaction::Execute(), using post-iterating on the LockedQueue instead of pre-iterating.

Thanks to click for the insight and Spp for testing.

--HG--
branch : trunk

1 files changed, 14 insertions, 1 deletions

diff --git a/src/shared/LockedQueue.h b/src/shared/LockedQueue.h
index fd0a0d5d22d..9f8afae6c14 100644
--- a/src/shared/LockedQueue.h
+++ b/src/shared/LockedQueue.h
@@ -87,7 +87,6 @@ namespace ACE_Based
             {
                 lock();
 
-
                 T& result = _queue.front();
 
                 return result;
@@ -121,6 +120,20 @@ namespace ACE_Based
             {
                 this->_lock.release();
             }
+            
+            ///! Calls pop_front of the queue
+            void pop_front()
+            {
+                ACE_GUARD (LockType, g, this->_lock);
+                _queue.pop_front();
+            }
+            
+            ///! Checks if we're empty or not with locks held
+            bool empty()
+            {
+                ACE_GUARD_RETURN (LockType, g, this->_lock, false);
+                return _queue.empty();
+            }
     };
 }
 #endif