aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorariel- <ariel-@users.noreply.github.com>2021-06-19 23:55:03 +0200
committerShauren <shauren.trinity@gmail.com>2021-06-19 23:55:03 +0200
commit18780206bc6470e5a3c1adf4f917766fedbd1c17 (patch)
tree7f287471efb2f1f24a0f681c5333019fc3be974d /src
parent3582bacc4a3550725d288b55fb16311dee0ae0df (diff)
Core/Spells: Do not apply SpellModOp::CritChance to spells that can't crit
Diffstat (limited to 'src')
-rw-r--r--src/server/game/Entities/Player/Player.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp
index e6cc4328837..b2bd8469268 100644
--- a/src/server/game/Entities/Player/Player.cpp
+++ b/src/server/game/Entities/Player/Player.cpp
@@ -22232,6 +22232,10 @@ bool Player::IsAffectedBySpellmod(SpellInfo const* spellInfo, SpellModifier* mod
if (mod->op == SpellModOp::Duration && spellInfo->GetDuration() == -1)
return false;
+ // mod crit to spells that can't crit
+ if (mod->op == SpellModOp::CritChance && !spellInfo->HasAttribute(SPELL_ATTR0_CU_CAN_CRIT))
+ return false;
+
return spellInfo->IsAffectedBySpellMod(mod);
}