Core/CrashHandler: Remove sensible data from crashlogs

2 files changed, 20 insertions, 14 deletions

diff --git a/src/common/Debugging/WheatyExceptionReport.cpp b/src/common/Debugging/WheatyExceptionReport.cpp
index ff8ec2629f1..4f091c19143 100644
--- a/src/common/Debugging/WheatyExceptionReport.cpp
+++ b/src/common/Debugging/WheatyExceptionReport.cpp
@@ -1490,4 +1490,23 @@ void WheatyExceptionReport::PrintSymbolDetail()
     return;
 }
 
+std::string SymbolDetail::ToString()
+{
+    Logged = true;
+    std::string formatted = Prefix + Type + Suffix;
+    if (!Name.empty())
+    {
+        if (!formatted.empty())
+            formatted += " ";
+        formatted += Name;
+    }
+    if (!Value.empty())
+    {
+        if (Name == "passwd" || Name == "password")
+            Value = "<sensible data>";
+        formatted += " = " + Value;
+    }
+    return formatted;
+}
+
 #endif  // _WIN32
diff --git a/src/common/Debugging/WheatyExceptionReport.h b/src/common/Debugging/WheatyExceptionReport.h
index a6f871bfb13..54cc836e7b7 100644
--- a/src/common/Debugging/WheatyExceptionReport.h
+++ b/src/common/Debugging/WheatyExceptionReport.h
@@ -115,20 +115,7 @@ struct SymbolDetail
 {
     SymbolDetail() : Prefix(), Type(), Suffix(), Name(), Value(), Logged(false), HasChildren(false) {}
 
-    std::string ToString()
-    {
-        Logged = true;
-        std::string formatted = Prefix + Type + Suffix;
-        if (!Name.empty())
-        {
-            if (!formatted.empty())
-                formatted += " ";
-            formatted += Name;
-        }
-        if (!Value.empty())
-            formatted += " = " + Value;
-        return formatted;
-    }
+    std::string ToString();
 
     bool empty() const
     {