Core/Crypto: Removed unneccessary std::reverse in Ed25519::Sign

2 files changed, 3 insertions, 8 deletions

diff --git a/src/common/Cryptography/Ed25519.cpp b/src/common/Cryptography/Ed25519.cpp
index bbe053fa3b2..ce706594057 100644
--- a/src/common/Cryptography/Ed25519.cpp
+++ b/src/common/Cryptography/Ed25519.cpp
@@ -20,15 +20,11 @@
 #include "Memory.h"
 #include <ed25519/ed25519.h>
 #include <openssl/pem.h>
-#include <algorithm>
 #include <memory>
-#include <vector>
 
 namespace Trinity::Crypto
 {
-Ed25519::Ed25519()
-{
-}
+Ed25519::Ed25519() = default;
 
 Ed25519::Ed25519(Ed25519 const& right)
 {
@@ -133,7 +129,6 @@ bool Ed25519::Sign(uint8 const* message, std::size_t messageLength, std::vector<
 
     output.resize(64);
     int result = ED25519_sign(output.data(), message, messageLength, publicKey, privateKey);
-    std::reverse(output.begin(), output.end());
     return result != 0;
 }
 
diff --git a/src/common/Cryptography/Ed25519.h b/src/common/Cryptography/Ed25519.h
index 7d7f56bb905..fe9f8365550 100644
--- a/src/common/Cryptography/Ed25519.h
+++ b/src/common/Cryptography/Ed25519.h
@@ -32,8 +32,8 @@ class TC_COMMON_API Ed25519
 {
 public:
     Ed25519();
-    Ed25519(Ed25519 const& other);
-    Ed25519(Ed25519&& other) noexcept;
+    Ed25519(Ed25519 const& right);
+    Ed25519(Ed25519&& right) noexcept;
     ~Ed25519();
 
     Ed25519& operator=(Ed25519 const& right);