diff options
| author | jackpoz <giacomopoz@gmail.com> | 2015-05-30 23:09:34 +0200 |
|---|---|---|
| committer | DDuarte <dnpd.dd@gmail.com> | 2015-06-01 00:57:41 +0100 |
| commit | 986deaa9773c45b614d064cc88181789db3cd7f9 (patch) | |
| tree | 24cccd63fa852e8875b728e724e18df3940da825 /src | |
| parent | 65dc69c17b11c7298c39960e981d0891566655d1 (diff) | |
Core/Misc: Fix issues reported by static analysis
Coverity defect IDs: 1022861, 1022862, 1022863, 1302435, 1302439, 1302440
(cherry picked from commit 25881ca95fd3c8e6c8aecb93739d1642c7a4d9c8)
Conflicts:
src/server/scripts/Outland/HellfireCitadel/ShatteredHalls/shattered_halls.cpp
src/server/scripts/Outland/zone_hellfire_peninsula.cpp
Diffstat (limited to 'src')
| -rw-r--r-- | src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp index 134783ccf07..6a1ff6d4eea 100644 --- a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp +++ b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp @@ -903,17 +903,15 @@ class boss_yogg_saron : public CreatureScript DoCast(me, SPELL_KNOCK_AWAY); me->ResetLootMode(); - switch (_instance->GetData(DATA_KEEPERS_COUNT)) - { - case 0: - me->AddLootMode(LOOT_MODE_HARD_MODE_4); - case 1: - me->AddLootMode(LOOT_MODE_HARD_MODE_3); - case 2: - me->AddLootMode(LOOT_MODE_HARD_MODE_2); - case 3: - me->AddLootMode(LOOT_MODE_HARD_MODE_1); - } + uint32 keepersCount = _instance->GetData(DATA_KEEPERS_COUNT); + if (keepersCount == 0) + me->AddLootMode(LOOT_MODE_HARD_MODE_4); + if (keepersCount <= 1) + me->AddLootMode(LOOT_MODE_HARD_MODE_3); + if (keepersCount <= 2) + me->AddLootMode(LOOT_MODE_HARD_MODE_2); + if (keepersCount <= 3) + me->AddLootMode(LOOT_MODE_HARD_MODE_1); } void SpellHit(Unit* /*caster*/, SpellInfo const* spell) override |