aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorKeader <keader.android@gmail.com>2019-01-05 11:26:29 -0300
committerKeader <keader.android@gmail.com>2019-01-05 11:26:29 -0300
commita0de602d38ffd1ddd9efdde62b24207709979739 (patch)
tree72acaa74f2573b7395b783d54d73b37fb9882d43 /src
parent5a46faf17637315d98ed4431b0c4b655d0090243 (diff)
Core/Spell: Fixed some negative spells showing as positive
Closes #22840 Revert 9ecce3319216ca2156441e661a0d7a3a120f4ab9 and 7611242530e7037ecab9bc8a619628128b22fb6f Update #22757
Diffstat (limited to 'src')
-rw-r--r--src/server/game/Spells/SpellInfo.cpp11
1 files changed, 3 insertions, 8 deletions
diff --git a/src/server/game/Spells/SpellInfo.cpp b/src/server/game/Spells/SpellInfo.cpp
index 77108b64ca4..8f32f011e28 100644
--- a/src/server/game/Spells/SpellInfo.cpp
+++ b/src/server/game/Spells/SpellInfo.cpp
@@ -3406,10 +3406,6 @@ bool _isPositiveEffectImpl(SpellInfo const* spellInfo, uint8 effIndex, std::unor
case 64412: // Phase Punch, Algalon the Observer, Ulduar
case 72410: // Rune of Blood, Saurfang, Icecrown Citadel
case 71204: // Touch of Insignificance, Lady Deathwhisper, Icecrown Citadel
- case 70853: // Malleable Goo, Professor Putricide (10 normal)
- case 72458: // Malleable Goo, Professor Putricide (25 normal)
- case 72873: // Malleable Goo, Professor Putricide (10 heroic)
- case 72874: // Malleable Goo, Professor Putricide (25 heroic)
return false;
case 24732: // Bat Costume
case 30877: // Tag Murloc
@@ -3438,9 +3434,6 @@ bool _isPositiveEffectImpl(SpellInfo const* spellInfo, uint8 effIndex, std::unor
// Arcane Missiles
if (spellInfo->SpellFamilyFlags[0] == 0x00000800)
return false;
- // Mage Slow
- if (spellInfo->Id == 31589)
- return false;
break;
case SPELLFAMILY_WARRIOR:
// Slam, Execute
@@ -3639,12 +3632,14 @@ bool _isPositiveEffectImpl(SpellInfo const* spellInfo, uint8 effIndex, std::unor
break;
case SPELL_AURA_MOD_ATTACKSPEED: // some buffs have negative bp, check both target and bp
case SPELL_AURA_MOD_MELEE_HASTE:
+ case SPELL_AURA_HASTE_RANGED:
case SPELL_AURA_MOD_RESISTANCE_PCT:
case SPELL_AURA_MOD_RATING:
case SPELL_AURA_MOD_ATTACK_POWER:
case SPELL_AURA_MOD_RANGED_ATTACK_POWER:
case SPELL_AURA_MOD_DAMAGE_PERCENT_DONE:
- if (!_isPositiveTarget(spellInfo, effIndex) && bp < 0)
+ case SPELL_AURA_MOD_SPEED_SLOW_ALL:
+ if (!_isPositiveTarget(spellInfo, effIndex) || bp < 0)
return false;
break;
case SPELL_AURA_MOD_DAMAGE_TAKEN: // dependent from basepoint sign (positive -> negative)