aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorariel- <ariel-@users.noreply.github.com>2017-03-01 19:35:39 -0300
committerShauren <shauren.trinity@gmail.com>2019-08-17 20:04:14 +0200
commitaaefda61009f9375e82ee63cf0610adcd19b5d8d (patch)
treea14c8e29652cc69e8c27d7cb0f000ea71c85fca9 /src
parentf087fbbcc69d01d95ada45263294505aceddc5a5 (diff)
Core/Scripts: Change null-check to assert
- ToPlayer() should never be null in this context (cherrypicked from 12c680f9b1f1068099c3b19443d93d456690ac56)
Diffstat (limited to 'src')
-rw-r--r--src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp b/src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp
index 0de1bc53f73..7a880f05150 100644
--- a/src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp
+++ b/src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp
@@ -1098,10 +1098,8 @@ class spell_sindragosa_s_fury : public SpellScriptLoader
{
targets.remove_if([](WorldObject* obj) -> bool
{
- if (Player* target = obj->ToPlayer())
- if (target->IsGameMaster())
- return true;
- return false;
+ // SPELL_ATTR3_ONLY_TARGET_PLAYERS present on the spell, we can safely cast to Player
+ return ASSERT_NOTNULL(obj->ToPlayer())->IsGameMaster();
});
_targetCount = targets.size();