diff options
| author | Vincent-Michael <Vincent_Michael@gmx.de> | 2013-08-12 01:31:28 +0200 |
|---|---|---|
| committer | Vincent-Michael <Vincent_Michael@gmx.de> | 2013-08-12 01:31:28 +0200 |
| commit | c18b347c61dc13c11e81db60cc7cd736fe5ef5d6 (patch) | |
| tree | bca9b2ea39ebe01ebe05f4dcdc8edb315bf91713 /src | |
| parent | ca78aff37f8ef9ef9a68bebafbe6375048557a8e (diff) | |
Core/Battleground: Small code optimization
Diffstat (limited to 'src')
| -rw-r--r-- | src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp | 3 | ||||
| -rw-r--r-- | src/server/game/Battlegrounds/Zones/BattlegroundWS.cpp | 4 |
2 files changed, 2 insertions, 5 deletions
diff --git a/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp b/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp index d13fc6d697b..03c4b84b817 100644 --- a/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp +++ b/src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp @@ -973,8 +973,7 @@ bool BattlegroundSA::CheckAchievementCriteriaMeet(uint32 criteriaId, Player cons case BG_CRITERIA_CHECK_NOT_EVEN_A_SCRATCH: return _allVehiclesAlive[GetTeamIndexByTeamId(source->GetTeam())]; case BG_CRITERIA_CHECK_DEFENSE_OF_THE_ANCIENTS: - if (source->GetTeamId() != Attackers && !gateDestroyed) - return true; + return source->GetTeamId() != Attackers && !gateDestroyed; } return Battleground::CheckAchievementCriteriaMeet(criteriaId, source, target, miscValue); diff --git a/src/server/game/Battlegrounds/Zones/BattlegroundWS.cpp b/src/server/game/Battlegrounds/Zones/BattlegroundWS.cpp index 419a4eff84c..5e0cade9b37 100644 --- a/src/server/game/Battlegrounds/Zones/BattlegroundWS.cpp +++ b/src/server/game/Battlegrounds/Zones/BattlegroundWS.cpp @@ -877,9 +877,7 @@ bool BattlegroundWS::CheckAchievementCriteriaMeet(uint32 criteriaId, Player cons switch (criteriaId) { case BG_CRITERIA_CHECK_SAVE_THE_DAY: - if (GetFlagState(player->GetTeam()) == BG_WS_FLAG_STATE_ON_BASE) - return true; - break; + return GetFlagState(player->GetTeam()) == BG_WS_FLAG_STATE_ON_BASE; } return Battleground::CheckAchievementCriteriaMeet(criteriaId, player, target, miscValue); |