diff options
author | Trisjdc <trisjdc@gmail.com> | 2014-06-25 01:03:24 +0100 |
---|---|---|
committer | Trisjdc <trisjdc@gmail.com> | 2014-06-25 01:03:24 +0100 |
commit | cac491bef8c60be0a8b20e6d49480224e50ba0a1 (patch) | |
tree | 2ba35d84a78e949193a5b63d6d4fea875cbf14d2 /src | |
parent | c2d1a36966d11ddb9da30117bc2a947a95167c06 (diff) |
Fix a warning picked by static code analysis (assignment of a temporary variable before destruction)
Diffstat (limited to 'src')
-rw-r--r-- | src/server/game/Entities/Player/Player.cpp | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index 9733c0f2b52..6548b2dffde 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -2920,11 +2920,10 @@ void Player::UninviteFromGroup() void Player::RemoveFromGroup(Group* group, uint64 guid, RemoveMethod method /* = GROUP_REMOVEMETHOD_DEFAULT*/, uint64 kicker /* = 0 */, const char* reason /* = NULL */) { - if (group) - { - group->RemoveMember(guid, method, kicker, reason); - group = NULL; - } + if (!group) + return; + + group->RemoveMember(guid, method, kicker, reason); } void Player::SendLogXPGain(uint32 GivenXP, Unit* victim, uint32 BonusXP, bool recruitAFriend, float /*group_rate*/) |