diff options
| author | Shauren <shauren.trinity@gmail.com> | 2013-03-21 21:01:52 +0100 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2013-03-21 21:01:52 +0100 |
| commit | d05aac03ae4b4b9df765ed89adef25235c9639e9 (patch) | |
| tree | 19c772709b50069738a8fcd4c6f7eb4ae718fae9 /src | |
| parent | cf1c1cf99222c8e1e260f14977c207306faff273 (diff) | |
Core/Players: Cleanup code in SendPreparedQuest (checks doing nothing...)
Diffstat (limited to 'src')
| -rw-r--r-- | src/server/game/Entities/Player/Player.cpp | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index 4b3adf6fba7..49d210fca2c 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -14729,22 +14729,16 @@ void Player::SendPreparedQuest(uint64 guid) if (questMenu.Empty()) return; - QuestMenuItem const& qmi0 = questMenu.GetItem(0); - - uint32 icon = qmi0.QuestIcon; - // single element case if (questMenu.GetMenuItemCount() == 1) { - // Auto open -- maybe also should verify there is no greeting + QuestMenuItem const& qmi0 = questMenu.GetItem(0); uint32 questId = qmi0.QuestId; - Quest const* quest = sObjectMgr->GetQuestTemplate(questId); - if (quest) + // Auto open -- maybe also should verify there is no greeting + if (Quest const* quest = sObjectMgr->GetQuestTemplate(questId)) { - if (icon == 4 && !GetQuestRewardStatus(questId)) - PlayerTalkClass->SendQuestGiverRequestItems(quest, guid, CanRewardQuest(quest, false), true); - else if (icon == 4) + if (qmi0.QuestIcon == 4) PlayerTalkClass->SendQuestGiverRequestItems(quest, guid, CanRewardQuest(quest, false), true); // Send completable on repeatable and autoCompletable quest if player don't have quest /// @todo verify if check for !quest->IsDaily() is really correct (possibly not) |