diff options
Diffstat (limited to 'src')
| -rw-r--r-- | src/server/game/DataStores/DBCEnums.h | 3 | ||||
| -rw-r--r-- | src/server/game/Spells/SpellInfo.cpp | 6 | ||||
| -rw-r--r-- | src/server/scripts/Spells/spell_shaman.cpp | 31 |
3 files changed, 36 insertions, 4 deletions
diff --git a/src/server/game/DataStores/DBCEnums.h b/src/server/game/DataStores/DBCEnums.h index 6e2c3806d8a..dc68d9fc594 100644 --- a/src/server/game/DataStores/DBCEnums.h +++ b/src/server/game/DataStores/DBCEnums.h @@ -2287,7 +2287,8 @@ enum SpellProcsPerMinuteModType SPELL_PPM_MOD_SPEC = 4, SPELL_PPM_MOD_RACE = 5, SPELL_PPM_MOD_ITEM_LEVEL = 6, - SPELL_PPM_MOD_BATTLEGROUND = 7 + SPELL_PPM_MOD_BATTLEGROUND = 7, + SPELL_PPM_MOD_AURA = 8 }; constexpr std::size_t MAX_POWERS_PER_SPELL = 5; diff --git a/src/server/game/Spells/SpellInfo.cpp b/src/server/game/Spells/SpellInfo.cpp index 3c6d3f6504e..4eaca9be938 100644 --- a/src/server/game/Spells/SpellInfo.cpp +++ b/src/server/game/Spells/SpellInfo.cpp @@ -4366,6 +4366,12 @@ float SpellInfo::CalcProcPPM(Unit* caster, int32 itemLevel) const ppm *= 1.0f + mod->Coeff; break; } + case SPELL_PPM_MOD_AURA: + { + if (caster->HasAura(mod->Param)) + ppm *= 1.0f + mod->Coeff; + break; + } default: break; } diff --git a/src/server/scripts/Spells/spell_shaman.cpp b/src/server/scripts/Spells/spell_shaman.cpp index 9a88a31425d..c8d37c85acd 100644 --- a/src/server/scripts/Spells/spell_shaman.cpp +++ b/src/server/scripts/Spells/spell_shaman.cpp @@ -1757,17 +1757,40 @@ class spell_sha_lava_surge : public AuraScript return ValidateSpellInfo({ SPELL_SHAMAN_LAVA_SURGE, SPELL_SHAMAN_IGNEOUS_POTENTIAL }); } - bool CheckProcChance(AuraEffect const* aurEff, ProcEventInfo const& /*eventInfo*/) const + bool CheckProcChance(AuraEffect const* aurEff, ProcEventInfo const& /*eventInfo*/) { - int32 procChance = aurEff->GetAmount(); + Unit* caster = GetTarget(); + float flameShocks = 0.0f; + auto work = [&, shaman = caster->GetGUID()](Unit const* target) + { + if (target->HasAuraEffect(SPELL_SHAMAN_FLAME_SHOCK, EFFECT_1, shaman)) + flameShocks += 1.0f; + }; + Trinity::UnitWorker worker(caster, work); + Cell::VisitAllObjects(caster, worker, 100.0f); + + // Proc uptime is not supposed to scale with the number of applied flame shocks + _normalizedTicks += 1.0f / flameShocks; + + // first 6 ticks after last proc fail to prevent overwriting + if (_normalizedTicks < 6.0f) + return false; + + float procChance = aurEff->GetAmount(); if (AuraEffect const* igneousPotential = GetTarget()->GetAuraEffect(SPELL_SHAMAN_IGNEOUS_POTENTIAL, EFFECT_0)) procChance += igneousPotential->GetAmount(); - return roll_chance_i(procChance); + float missChance = std::max(100 - procChance, 0.0f) / 100.0f; + + procChance = (1.0f - std::pow(missChance, _normalizedTicks)) * 100.0f; + + return roll_chance_f(procChance); } void HandleEffectProc(AuraEffect const* /*aurEff*/, ProcEventInfo const& /*eventInfo*/) { + _normalizedTicks = 0.0f; + PreventDefaultAction(); GetTarget()->CastSpell(GetTarget(), SPELL_SHAMAN_LAVA_SURGE, CastSpellExtraArgsInit{ .TriggerFlags = TRIGGERED_FULL_MASK }); } @@ -1777,6 +1800,8 @@ class spell_sha_lava_surge : public AuraScript DoCheckEffectProc += AuraCheckEffectProcFn(spell_sha_lava_surge::CheckProcChance, EFFECT_0, SPELL_AURA_DUMMY); OnEffectProc += AuraEffectProcFn(spell_sha_lava_surge::HandleEffectProc, EFFECT_0, SPELL_AURA_DUMMY); } + + float _normalizedTicks = 0.0f; }; // 77762 - Lava Surge |