aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rwxr-xr-xsrc/server/game/Entities/Item/Item.cpp12
-rwxr-xr-xsrc/server/game/Entities/Player/Player.cpp12
2 files changed, 17 insertions, 7 deletions
diff --git a/src/server/game/Entities/Item/Item.cpp b/src/server/game/Entities/Item/Item.cpp
index 2fc5ccca6ad..956add66f5b 100755
--- a/src/server/game/Entities/Item/Item.cpp
+++ b/src/server/game/Entities/Item/Item.cpp
@@ -308,6 +308,10 @@ void Item::UpdateDuration(Player* owner, uint32 diff)
void Item::SaveToDB(SQLTransaction& trans)
{
+ bool isInTransaction = !(trans.null());
+ if (!isInTransaction)
+ trans = CharacterDatabase.BeginTransaction();
+
uint32 guid = GetGUIDLow();
switch (uState)
{
@@ -368,13 +372,21 @@ void Item::SaveToDB(SQLTransaction& trans)
stmt->setUInt32(0, guid);
trans->Append(stmt);
}
+
+ if (!isInTransaction)
+ CharacterDatabase.CommitTransaction(trans);
+
delete this;
return;
}
case ITEM_UNCHANGED:
break;
}
+
SetState(ITEM_UNCHANGED);
+
+ if (!isInTransaction)
+ CharacterDatabase.CommitTransaction(trans);
}
bool Item::LoadFromDB(uint32 guid, uint64 owner_guid, Field* fields, uint32 entry)
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp
index 11d0802c444..d5ef4c403cf 100755
--- a/src/server/game/Entities/Player/Player.cpp
+++ b/src/server/game/Entities/Player/Player.cpp
@@ -17413,7 +17413,6 @@ void Player::_LoadMailedItems(Mail *mail)
if (!result)
return;
- SQLTransaction trans = CharacterDatabase.BeginTransaction();
do
{
Field* fields = result->Fetch();
@@ -17428,10 +17427,10 @@ void Player::_LoadMailedItems(Mail *mail)
if (!proto)
{
sLog->outError("Player %u has unknown item_template (ProtoType) in mailed items(GUID: %u template: %u) in mail (%u), deleted.", GetGUIDLow(), item_guid_low, item_template, mail->messageID);
- trans->PAppend("DELETE FROM mail_items WHERE item_guid = '%u'", item_guid_low);
+ CharacterDatabase.PExecute("DELETE FROM mail_items WHERE item_guid = '%u'", item_guid_low);
PreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_DEL_ITEM_INSTANCE);
stmt->setUInt32(0, item_guid_low);
- trans->Append(stmt);
+ CharacterDatabase.Execute(stmt);
continue;
}
@@ -17442,15 +17441,13 @@ void Player::_LoadMailedItems(Mail *mail)
sLog->outError("Player::_LoadMailedItems - Item in mail (%u) doesn't exist !!!! - item guid: %u, deleted from mail", mail->messageID, item_guid_low);
CharacterDatabase.PExecute("DELETE FROM mail_items WHERE item_guid = '%u'", item_guid_low);
item->FSetState(ITEM_REMOVED);
- item->SaveToDB(trans); // it also deletes item object !
+ item->SaveToDB(SQLTransaction(NULL)); // it also deletes item object !
continue;
}
AddMItem(item);
}
while (result->NextRow());
-
- CharacterDatabase.CommitTransaction(trans);
}
void Player::_LoadMailInit(PreparedQueryResult resultUnread, PreparedQueryResult resultDelivery)
@@ -17504,7 +17501,8 @@ void Player::_LoadMail()
_LoadMailedItems(m);
m_mail.push_back(m);
- } while (result->NextRow());
+ }
+ while (result->NextRow());
}
m_mailsLoaded = true;
}