diff options
Diffstat (limited to 'src')
8 files changed, 15 insertions, 16 deletions
diff --git a/src/server/game/AI/CreatureAI.cpp b/src/server/game/AI/CreatureAI.cpp index 87ad5851e39..4ef70b18529 100644 --- a/src/server/game/AI/CreatureAI.cpp +++ b/src/server/game/AI/CreatureAI.cpp @@ -265,13 +265,13 @@ int32 CreatureAI::VisualizeBoundary(uint32 duration, Unit* owner, bool fill) con std::unordered_set<coordinate> outOfBounds; Position startPosition = owner->GetPosition(); - if (!CheckBoundary(&startPosition)) + if (!IsInBoundary(&startPosition)) { // fall back to creature position startPosition = me->GetPosition(); - if (!CheckBoundary(&startPosition)) + if (!IsInBoundary(&startPosition)) { // fall back to creature home position startPosition = me->GetHomePosition(); - if (!CheckBoundary(&startPosition)) + if (!IsInBoundary(&startPosition)) return LANG_CREATURE_NO_INTERIOR_POINT_FOUND; } } @@ -294,7 +294,7 @@ int32 CreatureAI::VisualizeBoundary(uint32 duration, Unit* owner, bool fill) con if (alreadyChecked.find(next) == alreadyChecked.end()) // never check a coordinate twice { Position nextPos(startPosition.GetPositionX() + next.first*BOUNDARY_VISUALIZE_STEP_SIZE, startPosition.GetPositionY() + next.second*BOUNDARY_VISUALIZE_STEP_SIZE, startPosition.GetPositionZ()); - if (CheckBoundary(&nextPos)) + if (IsInBoundary(&nextPos)) Q.push(next); else { @@ -321,7 +321,7 @@ int32 CreatureAI::VisualizeBoundary(uint32 duration, Unit* owner, bool fill) con return boundsWarning ? LANG_CREATURE_MOVEMENT_MAYBE_UNBOUNDED : 0; } -bool CreatureAI::CheckBoundary(Position const* who) const +bool CreatureAI::IsInBoundary(Position const* who) const { if (!_boundary) return true; @@ -350,7 +350,7 @@ void CreatureAI::SetBoundary(CreatureBoundary const* boundary, bool negateBounda bool CreatureAI::CheckInRoom() { - if (CheckBoundary()) + if (IsInBoundary()) return true; else { diff --git a/src/server/game/AI/CreatureAI.h b/src/server/game/AI/CreatureAI.h index a20afd9653c..79b949b920f 100644 --- a/src/server/game/AI/CreatureAI.h +++ b/src/server/game/AI/CreatureAI.h @@ -57,8 +57,6 @@ class TC_GAME_API CreatureAI : public UnitAI Creature* DoSummon(uint32 entry, WorldObject* obj, float radius = 5.0f, uint32 despawnTime = 30000, TempSummonType summonType = TEMPSUMMON_CORPSE_TIMED_DESPAWN); Creature* DoSummonFlyer(uint32 entry, WorldObject* obj, float flightZ, float radius = 5.0f, uint32 despawnTime = 30000, TempSummonType summonType = TEMPSUMMON_CORPSE_TIMED_DESPAWN); - bool CheckBoundary(Position const* who = nullptr) const; - public: enum EvadeReason { @@ -219,6 +217,7 @@ class TC_GAME_API CreatureAI : public UnitAI void SetBoundary(CreatureBoundary const* boundary, bool negativeBoundaries = false); static bool IsInBounds(CreatureBoundary const& boundary, Position const* who); + bool IsInBoundary(Position const* who = nullptr) const; protected: virtual void MoveInLineOfSight(Unit* /*who*/); diff --git a/src/server/game/AI/ScriptedAI/ScriptedCreature.cpp b/src/server/game/AI/ScriptedAI/ScriptedCreature.cpp index d502e70fa7e..5042dcd6144 100644 --- a/src/server/game/AI/ScriptedAI/ScriptedCreature.cpp +++ b/src/server/game/AI/ScriptedAI/ScriptedCreature.cpp @@ -507,7 +507,7 @@ void BossAI::TeleportCheaters() for (auto const& pair : me->GetCombatManager().GetPvECombatRefs()) { Unit* target = pair.second->GetOther(me); - if (target->IsControlledByPlayer() && !CheckBoundary(target)) + if (target->IsControlledByPlayer() && !IsInBoundary(target)) target->NearTeleportTo(x, y, z, 0); } } @@ -546,7 +546,7 @@ void BossAI::UpdateAI(uint32 diff) bool BossAI::CanAIAttack(Unit const* target) const { - return CheckBoundary(target); + return IsInBoundary(target); } void BossAI::_DespawnAtEvade(Seconds delayToRespawn /*= 30s*/, Creature* who /*= nullptr*/) diff --git a/src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp b/src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp index 5d2f11f3d39..1356b00a181 100644 --- a/src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp +++ b/src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp @@ -768,7 +768,7 @@ class npc_halion_controller : public CreatureScript Map::PlayerList const& players = me->GetMap()->GetPlayers(); for (Map::PlayerList::const_iterator i = players.begin(); i != players.end(); ++i) if (Player* player = i->GetSource()) - if (player->IsAlive() && CheckBoundary(player) && !player->IsGameMaster()) + if (player->IsAlive() && IsInBoundary(player) && !player->IsGameMaster()) return; EnterEvadeMode(EVADE_REASON_NO_HOSTILES); diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_thorim.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_thorim.cpp index 499dd15b966..66f2eae6fe0 100644 --- a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_thorim.cpp +++ b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_thorim.cpp @@ -1226,7 +1226,7 @@ class npc_thorim_arena_phase : public CreatureScript if (_isInArena && HeightPositionCheck(true)(who)) return false; - return CheckBoundary(who); + return IsInBoundary(who); } void Reset() override @@ -1319,7 +1319,7 @@ struct npc_thorim_minibossAI : public ScriptedAI bool CanAIAttack(Unit const* who) const final override { - return CheckBoundary(who); + return IsInBoundary(who); } void JustSummoned(Creature* summon) final override diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp index 522e796a4ae..7dc1c678e3d 100644 --- a/src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp +++ b/src/server/scripts/Northrend/Ulduar/Ulduar/instance_ulduar.cpp @@ -1077,7 +1077,7 @@ class instance_ulduar : public InstanceMapScript void AddDoor(GameObject* door, bool add) override { // Leviathan doors are South except the one it uses to enter the room - // which is North and should not be used for boundary checks in BossAI::CheckBoundary() + // which is North and should not be used for boundary checks in BossAI::IsInBoundary() if (door->GetEntry() == GO_LEVIATHAN_DOOR && door->GetPositionX() > 400.f) { if (add) diff --git a/src/server/scripts/Outland/BlackTemple/boss_illidan.cpp b/src/server/scripts/Outland/BlackTemple/boss_illidan.cpp index 5bdbd406d67..b8891f61a93 100644 --- a/src/server/scripts/Outland/BlackTemple/boss_illidan.cpp +++ b/src/server/scripts/Outland/BlackTemple/boss_illidan.cpp @@ -685,7 +685,7 @@ struct boss_illidan_stormrage : public BossAI Map::PlayerList const& players = me->GetMap()->GetPlayers(); for (Map::PlayerList::const_iterator i = players.begin(); i != players.end(); ++i) if (Player* player = i->GetSource()) - if (player->IsAlive() && !player->IsGameMaster() && CheckBoundary(player)) + if (player->IsAlive() && !player->IsGameMaster() && IsInBoundary(player)) return; EnterEvadeMode(EVADE_REASON_NO_HOSTILES); diff --git a/src/server/scripts/Outland/BlackTemple/boss_shade_of_akama.cpp b/src/server/scripts/Outland/BlackTemple/boss_shade_of_akama.cpp index 524e4db50ed..36d04389514 100644 --- a/src/server/scripts/Outland/BlackTemple/boss_shade_of_akama.cpp +++ b/src/server/scripts/Outland/BlackTemple/boss_shade_of_akama.cpp @@ -288,7 +288,7 @@ struct boss_shade_of_akama : public BossAI Map::PlayerList const& players = me->GetMap()->GetPlayers(); for (Map::PlayerList::const_iterator i = players.begin(); i != players.end(); ++i) if (Player* player = i->GetSource()) - if (player->IsAlive() && !player->IsGameMaster() && CheckBoundary(player)) + if (player->IsAlive() && !player->IsGameMaster() && IsInBoundary(player)) return; EnterEvadeMode(EVADE_REASON_NO_HOSTILES); |