diff options
Diffstat (limited to 'src')
-rw-r--r-- | src/server/game/Entities/Creature/TemporarySummon.cpp | 9 | ||||
-rw-r--r-- | src/server/game/Entities/Creature/TemporarySummon.h | 1 | ||||
-rw-r--r-- | src/server/game/Entities/Player/Player.cpp | 4 | ||||
-rw-r--r-- | src/server/game/Entities/Unit/Unit.cpp | 6 |
4 files changed, 7 insertions, 13 deletions
diff --git a/src/server/game/Entities/Creature/TemporarySummon.cpp b/src/server/game/Entities/Creature/TemporarySummon.cpp index 6d6e72f9117..5572ff22f4a 100644 --- a/src/server/game/Entities/Creature/TemporarySummon.cpp +++ b/src/server/game/Entities/Creature/TemporarySummon.cpp @@ -450,12 +450,3 @@ void Puppet::Update(uint32 time) } } } - -void Puppet::RemoveFromWorld() -{ - if (!IsInWorld()) - return; - - RemoveCharmedBy(nullptr); - Minion::RemoveFromWorld(); -} diff --git a/src/server/game/Entities/Creature/TemporarySummon.h b/src/server/game/Entities/Creature/TemporarySummon.h index de44bda118e..24a90771236 100644 --- a/src/server/game/Entities/Creature/TemporarySummon.h +++ b/src/server/game/Entities/Creature/TemporarySummon.h @@ -123,7 +123,6 @@ class TC_GAME_API Puppet : public Minion void InitStats(uint32 duration) override; void InitSummon() override; void Update(uint32 time) override; - void RemoveFromWorld() override; }; class TC_GAME_API ForcedUnsummonDelayEvent : public BasicEvent diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index 378cadad747..949607d550d 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -23880,7 +23880,11 @@ void Player::SetClientControl(Unit* target, bool allowMove) { // still affected by some aura that shouldn't allow control, only allow on last such aura to be removed if (allowMove && target->HasUnitState(UNIT_STATE_CANT_CLIENT_CONTROL)) + { + // this should never happen, otherwise m_unitBeingMoved might be left dangling! + ASSERT(GetUnitBeingMoved() == target); return; + } WorldPacket data(SMSG_CLIENT_CONTROL_UPDATE, target->GetPackGUID().size()+1); data << target->GetPackGUID(); diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp index 4c36de9b22e..68411bcd0b3 100644 --- a/src/server/game/Entities/Unit/Unit.cpp +++ b/src/server/game/Entities/Unit/Unit.cpp @@ -11055,12 +11055,14 @@ void Unit::SetControlled(bool apply, UnitState state) if (HasUnitState(state)) return; + if (state & UNIT_STATE_CONTROLLED) + CastStop(); + AddUnitState(state); switch (state) { case UNIT_STATE_STUNNED: SetStunned(true); - CastStop(); break; case UNIT_STATE_ROOT: if (!HasUnitState(UNIT_STATE_STUNNED)) @@ -11073,7 +11075,6 @@ void Unit::SetControlled(bool apply, UnitState state) SendMeleeAttackStop(); // SendAutoRepeatCancel ? SetConfused(true); - CastStop(); } break; case UNIT_STATE_FLEEING: @@ -11083,7 +11084,6 @@ void Unit::SetControlled(bool apply, UnitState state) SendMeleeAttackStop(); // SendAutoRepeatCancel ? SetFeared(true); - CastStop(); } break; default: |