aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-17Core/SmartAI: Allow scripting GameObjects by spawn id tooariel-
(cherrypicked from 05d99c5f58256f2baa16268dd0c310e3d089a229)
2019-08-17DB/Conditions: fix Sablemane's Sleeping Powder exploitariel-
2019-08-17Core/Creature: redo some logical checks in _IsTargetAcceptableariel-
- Check against current creature victim, don't check potential victim attacking list. - Neutral creatures with aggressive reactstate were triggered to attack from MoveInLineOfSight because of this check - Prevents attack from a distance after right clicking an npc Closes #19235 (cherrypicked from 15a207fcac15d336b848f9759f75386e12b6a35f)
2019-08-17Core/Spells: fix some db errorsariel-
(cherrypicked from ebba8dcba87190cfdef55bd896a11d2d234cd754)
2019-08-17Core/Game: fix dynamic linkingariel-
(cherrypicked from 2a6fe27cade65482e2479629661b5208c37ef884)
2019-08-17Core/Misc: remove unneeded semicolonariel-
(cherrypicked from f612b1cb4801285cc1d9446cd91a07291ffc746e)
2019-08-17Core/Spell: disable proc for magnet auras, they're handled differentlyariel-
Closes #19208 (cherrypicked from 7072bf8c02175c8d1e0a0adc78239cdff9ac5ecd)
2019-08-17Core/Game: fix non-pch includeariel-
(cherrypicked from b902f0c1b06b9d2d53df51a7f532f7f11f75a855)
2019-08-17Make ObjectMgrs _mailId and _hiPetNumber atomic (#19129)xinef1
- They can be accessed from multiple threads simultaneously (cherrypicked from 3fe03392d792b4f7ddcc2326f215d9f459bef991)
2019-08-17Core/Database: Prepared statement parameter preallocation (#18999)ariel-
- Pass prepared statement size to the helper class to prevent runtime resizing. - Rename CheckValidIndex -> AssertValidIndex - Cached prepared size on the worker pool as it's shared among all connections - Cached query data only for each connection, done lookup in map instead of possibly creating a new element - Kill the prepared statement map, and store raw sql string on the MySQLPreparedStatement class (This info is only used for logging, and there is no need of keeping a second container just for it) (cherrypicked from affee140c6a8e1e9358be2aa0d0088ede218acaa)
2019-08-17Ensure that all actions are compared to fixed point in time (ie. world ↵xinef1
update start) (#18910) - Actions will not be dependent on processing moment - Increased GameObjects cooldown resolution to milliseconds, fixes arming time of traps to be exactly one second and not something from range (1000, 1999) - Created GameTime namespace and UpdateTime class and moved there some code out of world (cherrypicked from 7567cafec84080d26ea513242a1f540a823b8f9d)
2019-08-17Core/GameObject: regenerate GO loot if respawn time passed since last loot ↵xinef1
generation time and not all items were taken (#19101) (cherrypicked from 7011aabb56f061fc889ec42ce32b7605ceb35b53)
2019-08-17Corrected calculation for SPELL_AURA_PERIODIC_DAMAGE_PERCENT (#19060)xinef1
(cherrypicked from ce1108b8a28c1f69840bc161a06f08ee0a147753)
2019-08-17Remove auras interrupted by falling when we fall to the ground or water (#19115)xinef1
(cherrypicked from 9b284ab329b55b0c41f47d171573780205a3a81a)
2019-08-17Core/Scripts: Change null-check to assertariel-
- ToPlayer() should never be null in this context (cherrypicked from 12c680f9b1f1068099c3b19443d93d456690ac56)
2019-08-17Core/Scripts: Fixed crash in SindragosaKeader
Closes #19227 (cherrypicked from ecfb346d1af39305923db1f19a4568355c4d94e5)
2019-08-17Core/Misc: always output client cache version on loadingariel-
* Do same with hotfix (cherrypicked from bb553743afd04193822c09caa76753d33ac86098)
2019-08-17Core/Entities: spawned movementtype should override template movementtypeariel-
Core/SmartAI: pass the CreatureData pointer (if any) on updating template (cherrypicked from ff43a74822630c11851abae4cba35a6542e0c86a) Closes #19223
2019-08-17Core/Movement: Corrected all speed checks after ↵ariel-
23b6991273bac4ee9d7cf1b4ac3b9a92e0a7300e Ref issue #19210 (cherrypicked from 2e68736afcab26d0bb8e1408fa639d09d4772dfb)
2019-08-17Core/Scripts: implement Moss Covered Feetariel-
Closes #19022 (cherrypicked from f302b3d68d2c40a86f0c7be4df9b2fb625ba724f)
2019-08-17Dep: Use the anonymous namespace free definition of `boost::none`.Naios
* Fixes MSVC linking errors after the recent changes: "class boost::none_t const & const boost::`anonymous namespace' ::none" (?none@?A0x518851d0@boost@@3AEBVnone_t@2@EB) already defined in scripts_commands.lib... * Sets the required version of boost on windows to 1.66 according to the wiki. (cherrypicked from 3da60f84000bd7ffa5a1516839b84cdee4764448)
2019-08-17Core/Misc: Fix static analysis issuesjackpoz
(cherrypicked from 8f2bcd79da39ef9448938842de32b6f8572facdf)
2019-08-17Core/Misc: Fix static analysis issuesjackpoz
(cherrypicked from 69400719948fc32b3802a0ff6834b6261e4a0754)
2019-08-17Core/Misc: Fix static analysis issuesjackpoz
(cherrypicked from b375bab22592daaaa1fc387c4f6a1fb9564cbcc6)
2019-08-17Core/Scripts: kill a warningariel-
(cherrypicked from ace2a75197457720f40b61535e1f34aafab33c5f)
2019-08-17Core/Scripts: Thrusting Hodir's Spearariel-
- Everything is sniffed, enjoy this hell of a quest! Closes #12808 (cherrypicked from 01f5befcec19cbf519d6222f514f70ba9704f0ea)
2019-08-17Core/Unit: Correct speed calculus when affected by ↵Gustavo
SPELL_AURA_MOD_MINIMUM_SPEED (#18136) (cherrypicked from 4224259d83c336ef46fa627a8ba0015200a788eb)
2019-08-17Core/Dep: update zlib to 1.2.11ariel-
Changelog: Changes in 1.2.11 (15 Jan 2017) - Fix deflate stored bug when pulling last block from window - Permit immediate deflateParams changes before any deflate input Changes in 1.2.10 (2 Jan 2017) - Avoid warnings on snprintf() return value - Fix bug in deflate_stored() for zero-length input - Fix bug in gzwrite.c that produced corrupt gzip files - Remove files to be installed before copying them in Makefile.in - Add warnings when compiling with assembler code Changes in 1.2.9 (31 Dec 2016) - Fix contrib/minizip to permit unzipping with desktop API [Zouzou] - Improve contrib/blast to return unused bytes - Assure that gzoffset() is correct when appending - Improve compress() and uncompress() to support large lengths - Fix bug in test/example.c where error code not saved - Remedy Coverity warning [Randers-Pehrson] - Improve speed of gzprintf() in transparent mode - Fix inflateInit2() bug when windowBits is 16 or 32 - Change DEBUG macro to ZLIB_DEBUG - Avoid uninitialized access by gzclose_w() - Allow building zlib outside of the source directory - Fix bug that accepted invalid zlib header when windowBits is zero - Fix gzseek() problem on MinGW due to buggy _lseeki64 there - Loop on write() calls in gzwrite.c in case of non-blocking I/O - Add --warn (-w) option to ./configure for more compiler warnings - Reject a window size of 256 bytes if not using the zlib wrapper - Fix bug when level 0 used with Z_HUFFMAN or Z_RLE - Add --debug (-d) option to ./configure to define ZLIB_DEBUG - Fix bugs in creating a very large gzip header - Add uncompress2() function, which returns the input size used - Assure that deflateParams() will not switch functions mid-block - Dramatically speed up deflation for level 0 (storing) - Add gzfread(), duplicating the interface of fread() - Add gzfwrite(), duplicating the interface of fwrite() - Add deflateGetDictionary() function - Use snprintf() for later versions of Microsoft C - Fix *Init macros to use z_ prefix when requested - Replace as400 with os400 for OS/400 support [Monnerat] - Add crc32_z() and adler32_z() functions with size_t lengths - Update Visual Studio project files [AraHaan] (cherrypicked from d93901837101b369e298155133b5add43f50545b)
2019-08-17Core/Conditions: CONDITION_SOURCE_TYPE_QUEST_ACCEPT should not prevent ↵ariel-
completed question mark from showing (#18151 follow up) Closes #19188 (cherrypicked from 6c9bda6093ce7500e824a0409694a92fe49add6b)
2019-08-17Core/Entities: Fix null-dereference crashariel-
Closes #19191 (cherrypicked from d61e0f79c40681ce7675e878e0ec0bdc2294527f)
2019-08-17Core/Scripts: Fixed Illidan epic sounds again (#19184)Keader
(cherrypicked from bb3c964e7c0860d4448a065a2d1d37b52704da76)
2019-08-17Core/Spells: refactor spell_enchant_proc_data tableariel-
- Renamed fields to mimic those in spell_proc - Added Enchant proc attributes for controlling specific enchant features Ref #7789 (cherrypicked from f609e7a08b3b4d2d9642e5ec252e1eedad836f0f)
2019-08-17Core/Scripts: fix Nightfall proc chance and reduce it for victims with level ↵ariel-
above 60 Closes #15734 (cherrypicked from eac9c1f0b992fd3622fd7dd864b2acc2781ec778)
2019-08-17Core/Creature: Fix SetSpawnHealth so it cooperates with the colossal hack ↵treeston
that is Battleground::AddCreature. *puke* (cherrypicked from b3b4054eb44fdb9b0efe47d1a7ec3021b87a5fed)
2019-08-17Core/Spells: fix Hand of Justice proc chance and reduce it past level 60.ariel-
Ref #7789 (cherrypicked from f4ae639961542112dddcf627fc2e1f11967048a9)
2019-08-17Core/Spell: Added the possibility to explicitly disable auraEffect procs ↵ariel-
using attributes - Renamed IsProcTriggeredOnEvent to GetProcEffectMask, since long ago this function returned bool, new name should better reflect its use (cherrypicked from e7ccd8ea3fccad92af3553f544aad49be5d1a9ed)
2019-08-17QueryCache portfunjoker
partial port of: (ae9d01a3245c59a8a8d50516a79b79250337450d) (dd1aa64563bfb726e1132a135927a02fbb765454)
2019-08-17Properly stop attacking after player leaves ffa area (like Gurubashi Arena) ↵xinef1
(#18952) (cherrypicked from 4eae29d421e1d7a28aaa50d401cbbf09c50bd476)
2019-08-17DB/Loot: remove some incorrect drops of three quest reward itemsariel-
- Items reward of the Hakkari Urn, it must always contain the 3 items (previous had a very little chance of being less than 3) - Hakkari Urn is the reward from "Secret of the Circle (3447)" (cherrypicked from e9d527b70f84d28c7ed0a2d6d0270aa89230c472)
2019-08-17Core/Scripts: Fixed epic sounds on Illidan Fight (#19172)Keader
Thanks Kittnz for notice <3 (cherrypicked from 50973e9d6fbf7537ae8d90535b9dfa25e5ce69f6)
2019-08-17DB/Creature: Fix respawn time for some npcs added in a previous commitKillyana
(cherrypicked from 06667400867fe88b31d8ade4070ebb49119ecfcb)
2019-08-17DB/SAI: Zangen StonehoofDr-J
Remove part of script which rings bell at start of nights event when his nightly script activates as this should no longer be needed. (cherrypicked from d535b98b057f20012653af6af496d9f22f055a83)
2019-08-17Script/GO: Alliance Bell, Horde Bell and Karazhan Bell will now send a bell ↵Kittnz
sound on the start of each hour. (#19145) * Script/GO: Alliance Bell, Horde Bell and Karazhan Bell will now send a bell sound on the start of each hour. How many times it rings depence on the hour. * fix little things from pr comments * Added OnGameEvent * Fix braces * almost finished * fix enum * Add gameobjects to the game event Fix override for InitializeAI * enum squash * remove braces * Rename 9999_99_99_99_world.sql to 2017_02_19_01_world.sql (cherrypicked from 495339a2c7741d0ad56dfbb8756ad6e1e7d19b8b)
2019-08-17Add missing sql to previous commitShauren
(cherrypicked from 0bd0602948324621aa905cd26cc01088542caa08)
2019-08-17Core/SmartAI: Various fixes and extensions for smart scripts: (#18673)xinef1
- Possible crashes fixed - Memory leak fixed - Implemented checking of vehicle conditions - Extended eventphasemask to 12 bits (sql required to change DB field type) - SMART_EVENT_GOSSIP_HELLO - added possibility to detect for gameobject reportUse call - Renamed action SMART_ACTION_SET_FLY to SMART_ACTION_SET_DISABLE_GRAVITY (to reflect actual functionality) - Added targetsLimit to action SMART_ACTION_CAST and SMART_ACTION_INVOKER_CAST to limit max amount of targets (selected randomly) - Action SMART_ACTION_TALK corrected to always work as intended - Properly call GroupEventHappens in action SMART_ACTION_CALL_GROUPEVENTHAPPENS if invoker was charmed or owned by the player - Properly utilize followAngle in action SMART_ACTION_FOLLOW (db orientation should be in degrees), but keep backward compatibility - Added action SMART_ACTION_SET_CAN_FLY (119) 0/1 - Added action SMART_ACTION_REMOVE_AURAS_BY_TYPE (120) AuraType, can be used to exit vehicle for example - Added action SMART_ACTION_SET_SIGHT_DIST (121) sightDist - Added action SMART_ACTION_FLEE (122) fleeTime - Added action SMART_ACTION_ADD_THREAT (123) +threat, -threat - Added action SMART_ACTION_LOAD_EQUIPMENT (124) equipmentId - Added action SMART_ACTION_TRIGGER_RANDOM_TIMED_EVENT (125) minId, maxId - Added action SMART_ACTION_REMOVE_ALL_GAMEOBJECTS (126), removes all owned gameobjects - Added action SMART_ACTION_STOP_MOTION (127), stopMoving, movementExpired - Extended target SMART_TARGET_HOSTILE_SECOND_AGGRO with following parameters maxdist, playerOnly, powerType + 1 - Extended target SMART_TARGET_HOSTILE_LAST_AGGRO with following parameters maxdist, playerOnly, powerType + 1 - Extended target SMART_TARGET_HOSTILE_RANDOM with following parameters maxdist, playerOnly, powerType + 1 - Extended target SMART_TARGET_HOSTILE_RANDOM_NOT_TOP with following parameters maxdist, playerOnly, powerType + 1 - Extended target SMART_TARGET_THREAT_LIST with maxdist - Extended target SMART_TARGET_OWNER_OR_SUMMONER to be able to get charmer/owner of current owner - Added new target SMART_TARGET_FARTHEST with maxDist, playerOnly, isInLos restrictions - Added SpellHit hook to GameObjectAI and extended SmartGameObjectAI to call SMART_EVENT_SPELLHIT when gameobject is hit by spell - Call GameObjectAI Reset hook on gameobject respawn (for ex. to reset one time events in smart scripts) - Fixed some logic errors in code - SmartAI Escorts properly despawn escortee if no players are in range - Disable Evading while charming creature with SmartAI - Don't call SMART_EVENT_RESPAWN for dead units before they actually respawn - Don't call SMART_EVENT_RESPAWN for not spawned gameobjects - Properly call SMART_EVENT_RESPAWN for gameobject respawn - Allow action SMART_ACTION_SET_IN_COMBAT_WITH_ZONE to utilize targetlist - Allow action SMART_ACTION_CALL_FOR_HELP to utilize targetList - Allow action SMART_ACTION_SET_INVINCIBILITY_HP_LEVEL to utilize targetList - Allow action SMART_ACTION_SET_VISIBILITY to utilize targetList - Allow action SMART_ACTION_SET_ACTIVE to utilize targetList - Allow action SMART_ACTION_ATTACK_START to select random attack target instead of first on the list - Allow gameobjects to summon gameobjects with action SMART_ACTION_SUMMON_GO - Properly store action invokers for action SMART_ACTION_WP_START, if no player invokers are found, distance despawn check won't be used - Allow action SMART_ACTION_WP_RESUME to compensate for the state the unit actually is in (eg. combat) - Allow action SMART_ACTION_MOVE_TO_POS to select random of the avaiable targets, not only the first one. - Allow action SMART_ACTION_MOVE_TO_POS to utilize x, y, z parameters as an offset to calculated coordinates - Action SMART_ACTION_RESPAWN_TARGET should never modify respawntime of already spawned gameobjects, use dedicated function - Properly delete ontime events created by SMART_ACTION_CREATE_TIMED_EVENT - If action could not be started because conditions were not satisfied, do not recalculate the waittime to action repeattime, use smaller value to recheck more frequently - Allow target SMART_TARGET_CLOSEST_PLAYER to be used by gameobjects - Allow target SMART_TARGET_OWNER_OR_SUMMONER to be used by gameobjects - Fixed SMART_EVENT_COUNTER_SET to be only called for the id that was incremented - Changed the way counters work - Protect PhaseInc from surpassing maximum phase - Added loading checks for missing NON_REPEATABLE flag if no repeatmin, repeatmax is set - Added spell validation for SMART_ACTION_CROSS_CAST (cherrypicked from b0ae5fadd19fd172ec5154cde4f4fd14aa20ff88)
2019-08-17Revert "[3.3.5][master] Core/Movement: Smooth movement #13467 (#18020)"Riztazz
This reverts commit 05fb27dae4e8af859e01e5b9e52b082cba217657. (cherrypicked from a3c6880579f3326088ecbe5b8c08c4b75ed91a59)
2019-08-17Core/Misc: Minor change to racial wisp handling to make custom easier (or so ↵KobeSagami
i heard) (#22954)
2019-08-17Core/Spells: implement SPELL_AURA_OVERRIDE_AUTOATTACK_WITH_MELEE_SPELL (#23467)Ovah
2019-08-15Core/Items: Defined new item flagsShauren
2019-08-11Core: Updated allowed build to 8.2.0.31429Shauren