aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-01-19Merge pull request #11464 from Dehravor/ticket-memory-leakMachiavelli
Core/Tickets: Fix memory leak when malformed CMSG_GMTICKET_CREATE is received
2014-01-19Missing changes in 313b294d6b7b248738e30f8164ee4624a66ac5b5Vincent_Michael
2014-01-19Core/RBAC: Fix difference problems with 4.3.4Vincent_Michael
2014-01-19CoreCore/CrashHandler: Handle CRT asserts in Windows buildjackpoz
Handle CRT asserts in Windows crash handler instead of popping up a Abort/Retry/Ignore window
2014-01-19Misc/SQL: Rename SQL from fa2616fe4efa4651d48710c7458cd2d479e9338bDiscover-
2014-01-19Merge pull request #11469 from Dehravor/timetest-crashShauren
Core/Misc: Fix crash
2014-01-19Core/Creature: Fix compile and logic in previous pull request. Also ↵Discover-
implemented UNIT_NPC_FLAG_MAILBOX. Thanks @Shauren
2014-01-19Core/Misc: Fix crashDehravor
2014-01-19Merge pull request #11299 from Carbenium/MailboxCmdDiscover-
Core/Command: Add mailbox command
2014-01-19Core/CrashHandler: Fix issues on Windows crash handlerjackpoz
Fix few issues on WheatyExceptionReport: - fix NULL dereference exception in GetLogicalAddress() when TC assert in triggered ( *((volatile int*)NULL) = 0; ) - fix infinite loop in DumpTypeIndex() when dumping std types like std::string - fix FormatSymbolValue() pointing to wrong address when accessing local variable values - use portable types instead of x86 specific types, this fixes some wrong address issues on x86 platform - use bigger buffers to format symbols to avoid buffer overflows
2014-01-19Core/Commands: Using the '.gm vis off' command now instantly makes the GM ↵Discover-
invisible to non-GM players, instead of waiting until Player::UpdateObjectVisibility was called from a different method. Ref. #11467
2014-01-19Core/Misc: Split the calculating of the corpse reclaim delay and sending of ↵Discover-
SMSG_CORPSE_RECLAIM_DELAY in two different methods.
2014-01-19Merge pull request #10386 from Discover-/Health-FunnelDiscover-
Core/Spells: Health Funnel now always damages the warlock, even if it do...
2014-01-19Core/Misc: The timer that indicates how long it takes until the player can ↵Discover-
reclaim their corpse now starts counting down when the player releases its spirit instead of when they die. Fixes an issue where the 'Accept' button in the reclaim corpse window would already be clickable but have no effect (WorldSession::HandleReclaimCorpseOpcode::L754).
2014-01-19Core/Scripts: Fix the cleanup in 54dbf870b8fc1f0aef1ef95c8786303998762173.w1sht0l1v3
2014-01-19Core/Scripts: Fix kill credit for quest The Hunter and the Prince(13400).w1sht0l1v3
2014-01-18Core/Tickets: Fix memory leak when malformed CMSG_GMTICKET_CREATE is receivedDehravor
2014-01-18Core/Calendar: Add documentation regarding fix in previous commitMachiavelli
2014-01-18Merge pull request #11462 from Dehravor/add-event-memleaksMachiavelli
Core/Calendar: Fix memory leaks due to BytebufferException thrown
2014-01-18Core/Items: Fixed swapping equipment sets in combatShauren
2014-01-18Core/Calendar: Fix memory leak when guild announcement is createdDehravor
2014-01-18Core/Calendar: Fix memory leak when malformed CMSG_CALENDAR_ADD_EVENT is ↵Dehravor
received
2014-01-18Core/Spells: Fix proc for spells that should trigger on taken hotsBonitas
2014-01-18Core/Commands: The .setskill command is now usable even if the player ↵Discover-
doesn't already have the skill learned.
2014-01-17Merge branch 'master' of https://github.com/TrinityCore/TrinityCoreDiscover-
2014-01-17Core/Spells: Rename Spell::EffectSummonDeadPet with ↵Discover-
Spell::EffectResurrectPet and get rid of two TODO's that are already done.
2014-01-17Merge pull request #11397 from Dehravor/guild-view-offinoteMachiavelli
Core/Guild: Don't allow players to view officer notes without proper rights
2014-01-17Rename 2014_01_02_00_trinity_string.sql to 2014_01_17_00_trinity_string.sqlAokromes
2014-01-17Show Kick, Mute and Ban in worldZabustak
2014-01-17Core/Misc: When a player changes its faction its only removed from all its ↵Discover-
arena teams if cross-faction interaction is turned off.
2014-01-17Core/Entities: bg vehicle will also have charmer's faction (save faction ↵joschiwald
before charm and restore old faction after charm)
2014-01-16Core/Items: Fix an exploit where the player was able to send CMSG_SET_AMMO ↵Discover-
with items they didn't have in their bags. Only a visual bug (not sure if it gave bonuses too, which iirc do appear in later expansions).
2014-01-16Core/Misc: Fix an exploit where moving while consuming something that would ↵Discover-
fade when the player stands up would stay if the player started moving and using the effect at the same time. Thanks to @FrozenSoul and @jildor. Fixes #6271
2014-01-15Core/SAI: Fix assertion triggered in SmartScriptjackpoz
Remove assertion in SmartScript added in b8625f41bd6131e7fb3ff126780da18d5d2959fd and handle SmartScripts with GetBaseObject() returning NULL , like SmartTrigger . In this case SmartScript::mTargetStorage cannot be sanitized and might contain references to free'd WorldObjects if the script doesn't last a single Map::Update() call.
2014-01-15DB: update more creature templatesjoschiwald
2014-01-13Core/Instances: Fix memory leak in InstanceSaveMgrjackpoz
Fix memory leak in InstanceSaveMgr added in 1f170c99efec6c89b9a454a3aa17511341f61659 . Make InstanceSave::SetToDelete() private since it's not supposed to be used by anything other than InstanceSave or its friend class InstanceSaveMgr .
2014-01-13Core/Entities: Fix combat state setting when FFA PvP flag is setElron103
Description: Currently there is an issue, when you are in FFA areas, but you dont have PvP flag activated. You should get the PvP-In-Combat delay timer, but instead you just get the usual timer as if you would not fight in PvP. Reproduction: 1) Get two players in FFA area Gurubashi arena down in the battle area (.tele Gurubashi) 2) Fight each other 3) When stopping combat, the combat state will switch off immediately. But it is supposed to switch off after some delay, because it was a PvP fight. Closes #11103 Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
2014-01-13Core/Player: Fix compile error introduced in ##11377 mergeDuarte Duarte
2014-01-13Merge pull request #11377 from Yelvann/masterDuarte Duarte
Core/Instances: Fix exploit too much players in instances/raids
2014-01-12Core/SAI: Fix crash in SmartScriptjackpoz
Fix crash in SmartScript storing WorldObject* instead of guid as targets in SmartScript::mTargetStorage , used by SMART_TARGET_STORED target type , SMART_ESCORT_TARGETS and other escort related code. Fixes #11228 , #10157 . Valgrind log: Invalid read of size 4 at : Object::GetTypeId() const (Object.h:140) by : SmartScript::IsPlayer(WorldObject*) (SmartScript.h:73) by : SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:330) by : SmartScript::ProcessEvent(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2662) by : SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2226) by : SmartScript::ProcessTimedAction(SmartScriptHolder&, unsigned int const&, unsigned int const&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2238) by : SmartScript::ProcessEvent(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2685) by : SmartScript::UpdateTimer(SmartScriptHolder&, unsigned int) (SmartScript.cpp:3198) by : SmartScript::OnUpdate(unsigned int) (SmartScript.cpp:3244) by : SmartAI::UpdateAI(unsigned int) (SmartAI.cpp:331) by : Creature::Update(unsigned int) (Creature.cpp:544) by : void Trinity::ObjectUpdater::Visit<Creature>(GridRefManager<Creature>&) (GridNotifiers.cpp:340)
2014-01-12Spells: Fix Alcohol-Free Brewfest SamplerDarkBrain2580
Closes #10956 Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
2014-01-12Core/Movement: Add LOS check for fleeingmovement target point.zengwf
Prevents fleeing or feared units from going to upper floor ignoring walls/ceilings with mmaps on(and usually get stucked). Current implementation just randomly selects a distance and angle against the frighting unit, when in narrow circumstance such as underground caves, such targeting point would be at another floor. Closes #11300 Ref #9475 (needs fixed confirmation)
2014-01-11Merge pull request #11310 from Ric101/can_quest_rewardDuarte Duarte
Core/Players: On CanRewardQuest, use the same item dest vector for all potential rewards Solves issues where the player has enough bag space for each item individually, but not all of them together. Example to reproduce previous issue: Obtain Battle of the Crimson Watch (10781) Make sure you only have 1 slot available in your inventory Turn in the quest, watch as you don't receive one of the rewards
2014-01-11Merge pull request #11342 from Carbenium/SvalaDuarte Duarte
Scripting/Utgarde Pinnaccle: Fix visual during Svala's transformation
2014-01-12Scripts/NPCs: Remove core script for rogue trainers which was overriding db ↵Dr-J
conditions SAI and conditions for rogue trainers to provide elegant leter to rogues provided that is level 24 or higher, does not have elegant letter and does not have taken, rewarded or complete the quest which elegant letter starts Closes #11378 Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-01-12DB/Guild: Fix incorrect input length limitsDehravor
There is one incorrect field length related to guilds in the database, which can be used to cause an overflow client-side, by sending CMSG_GUILD_INFO_TEXT with long strings. The guild information has the same 500 characters client-side limit as the guild bank tab information, but on server-side it can be 65k characters long. A lengthy guild info makes the whole Guild panel unusable. Length of the other fields match the client's limits in the database: guild bank tab name (16), public note (31), officer note (31), motd (128), guild bank tab info (500). Closes #11395 Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-01-12Core&Conf: Small cosmetic fixesmthsena
Closes #11392 Signed-off-by: DDuarte <dnpd.dd@gmail.com>
2014-01-11Merge pull request #11426 from Dehravor/invalidate-playerDuarte Duarte
Core/Entities: Implement SMSG_INVALIDATE_PLAYER
2014-01-11Merge pull request #11427 from Dehravor/force-renameDuarte Duarte
Core/Entities: Don't allow to login while character is forced to rename
2014-01-11Core/Entities: Don't allow to login while character is forced to renameDehravor