aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-01-06DB/GameObject: Convert & update support for Shrine of the Eagle / Falcon / ↵offl
Hawk to SAI Closes #24647 (cherry picked from commit 0cfd63fd26312c8abb475cf36fcd164e65fc3eec)
2022-01-06DB/Creature: Convert Sayge to SAIoffl
Closes #24663 (cherry picked from commit 626aeb5817a42efc026e3623a65362eef355abb1)
2022-01-06Scripts/Misc: Fix issues reported by ASanjackpoz
(cherry picked from commit 013301088d862f634cd5b817cb3949c58454f924)
2022-01-06DB/GameObject: Convert & update support for Tablet of Madnessoffl
Closes #24670 (cherry picked from commit 9c1c34a79420b2513ee0009fcd84726c3ff95bfe)
2022-01-06Core/Creature: Allow to disable HP regen in Raids even if the target is ↵Giacomo Pozzoni
unreachable (#24646) (cherry picked from commit 247564a7ab7dc6f640bb8f4fd32c30ffdc9076d2)
2022-01-06DB/GameObject: Convert & update support for Jump-a-tron 4000 to DB scriptKillyana
Closes #24668 (cherry picked from commit 6b9a14ca940a2104a89cfadf07978a2759acb47a)
2022-01-06DB/Loot: Remove loot from creature Water Terroroffl
Closes #24671 (cherry picked from commit abd8140681c007a110a78ccb97a5677816bb94ba)
2022-01-06DB/Quest: Convert Escape from Umbrafen to SAIoffl
Closes #24648 (cherry picked from commit cfe6b651bc38239de58d6a3f95e8897bfb7d1869)
2022-01-06DB/Quest: Convert & update support for 'Hypercapacitor Gizmo' to SAIoffl
Closes #24640 (cherry picked from commit cc5bea023a0c43f1c58e2cd93267d9e339659442)
2022-01-06DB/Creature: Remove static spawns of Arcane Fiend & Amani Bear Mountoffl
Closes #24662 (cherry picked from commit 97319c7c19944fa4b5e461273ff7e8c389959c46)
2022-01-06DB/GameObject: Convert & update support for Fel & Bash'ir crystalforgesoffl
Closes #24643 (cherry picked from commit c3e4420a2b8584f97e49d7ae9a5b2f3140d50984)
2022-01-06DB/Quest: Convert support for 'Strength of One' to SAIoffl
Closes #24641 (cherry picked from commit 44aba5dcdf403797de777586bd7f10e9d76eaf53)
2022-01-06DB/Creature: Bogblossom Bunnyoffl
Closes #24623 (cherry picked from commit ea05844c59e77358c6ab1978a914e90e4b8dd21d)
2022-01-06Core/Quests: Add missing GO_DYNFLAG_LO_ACTIVATE to lootable chests related ↵Shauren
to quests but not having quest loot Closes #24474 (cherry picked from commit a26304478d9505713dfadb9b04a3bda4cef57545)
2022-01-06Core/Quests: Fixed gameobject sparkle state for lootable quest items by ↵Shauren
moving ItemAddedQuestCheck/ItemRemovedQuestCheck after item is added/removed This is neccessary so that GameObject::BuildValuesUpdate from BuildValuesUpdateBlockForPlayer picks up correct inventory state and sets GO_DYNFLAG_LO_ACTIVATE (cherry picked from commit 449bd9058bce87ade6831ba38d1a0b83b9cbfb18)
2022-01-06Scripts/ICC: Fixed duplicated call of reputation spellKeader
(cherry picked from commit 99c457c2709fc021b0441d488dc1710b284ee587)
2022-01-06Scripts/ICC: Fixed Deathbringer/Valithria reputation handler + codestyle fixesKeader
* Added correct reputation spell for both bosses * Fixed debuffs remove when deathbringer dies (it also fix recount) * Changed all DoCast(me, xxx) -> DoCastSelf(xx) * Removed old reputation hack in DB * Fixed my OCD with spells enum :) (cherry picked from commit d1e1b8753c491022055e255fd8c8b4ffbdd87bc9)
2022-01-06Scripts/RazorfenDowns: quest "Extinguishing the Idol" (#24658)NoName
(cherry picked from commit 868748007da3b70e96f10b4689065bd0b3f876c5)
2022-01-06Core/Objects: Add GOSummonType argument to SummonGameObject accepting XYZ ↵NoName
arguments instead of Position (#24655) (cherry picked from commit d2b88fbd503565a0289cbaa4bf7315f8c9cf5211)
2022-01-06DB/Quest: Finding the Survivorsoffl
Update the los event Ref #24636 (cherry picked from commit 2152293d888cb51ddddbdae09538814f8492a6d5)
2022-01-06DB/SAI: Fel Guard HoundKillyana
Ref #24638 (cherry picked from commit 2665fd5ab54b3040ab36bcba25b3929d5f11e8d4)
2022-01-06 DB/Quest: Convert & update support for 'Shizz Work' to SAIoffl
Closes #24638 (cherry picked from commit 049cba3ace198ec74a2014e233b33aafbf749a53)
2022-01-06DB/Quest: Convert & update support for 'Finding the Survivors' to SAIoffl
Closes #24636 (cherry picked from commit 2815db52a643bdfa397317b79d5b3f68995b343e)
2022-01-06DB/Creature: Convert & update support for Ashyen & Keleth to SAIoffl
Closes #24635 (cherry picked from commit a2068cade59a067f55d779735ba8bcf5c48f045f)
2022-01-05DB/Loot: Remove item Carved Ivory Bone from creatures lootoffl
Closes #24624 (cherry picked from commit 7b4b04653be041e53c51121a0cf80b33a5fd4de5)
2022-01-05DB/SAI: Fix event flags for "Discovering Your Roots" scriptoffl
Closes #24622 (cherry picked from commit 73f7a78a333a5b33325ae62bd1806a8d446e3c83)
2022-01-04MMAP: Build ADT floor just like WMO floor below liquid (#27503)killerwife
Fixes ocean floor pathfinding (cherry picked from commit 8a779268b601db28005a8348f3c21255718d4526)
2022-01-04Tools/MMAPs: Show an error when running mmaps_generator built in Debug mode ↵Giacomo Pozzoni
(#27412) * Tools/MMAPs: Show an error when running mmaps_generator built in Debug mode * Fix GCC build (cherry picked from commit 8c80f28581646af110c4d2b316209ef291a95587)
2022-01-04Core/Misc: Remove whitespacejackpoz
(cherry picked from commit 869fb748cd4f80b65b154fbd3cb9fa4ee8d64672)
2022-01-04Core/MMAPs: Reduce chances of breaking tile connectionsjackpoz
Reduce chances of breaking tile connections caused by floating point rounding issues. (cherry picked from commit e615e2ddefd2c18b6dec8e08fb3d17580b64ea99)
2022-01-04Vmap: Introduce skipping of antiportals and unreachable mogp (#26331)killerwife
* Vmap: Introduce skipping of antiportals and unreachable mogp * Reduce differences with master branch * Update VMAP and MMAP versions * Update MMAPs version Co-authored-by: jackpoz <giacomopoz@gmail.com> (cherry picked from commit d5f1fefe7f6772b11e9fbb052bfd36be9bda98e2)
2022-01-04MapExtraction: Fix water height redundancy algorithm ignoring "no water" ↵killerwife
(#26324) * MapExtraction: Fix water height redundancy algorithm ignoring "no water" * Update MMAP_VERSION * Change map version Co-authored-by: jackpoz <giacomopoz@gmail.com> (cherry picked from commit 00da074109e713280264761eedfbf6e5dc7ef912)
2022-01-04Core/Maps: Change .map file version from FourCC to uint32 (#26326)Giacomo Pozzoni
(cherry picked from commit 42877e75e2a67514dfeb185661e4f397b6eb044a)
2022-01-04Improve multithreading of mmaps_generator (#25625)Giacomo Pozzoni
* Build/Misc: Add a few *San CMake flags Add the following flags for the related tools: - MSAN for Memory Sanitizer - UBSAN for Undefined Behavior Sanitizer - TSAN for Thread Sanitizer * Remove unused parameter * Fix UBSan reported issue * Disable G3D buffer pools when using Thread Sanitizer as it has its custom locking mechanisms * Code cleanup * Move threads from maps to tiles * Move tile building logic to TileBuilder class * Fix memory leak in TileBuilder * Fix build * Store TileBuilder as raw pointer for now, it will be changed later on to use modern C++ constructs * Fix crash on shutdown * Revert pvs-studio change * Fix generating 1 single tile not closing the program (cherry picked from commit a4e93d779c9638bc0a61cb4405ef28cb935d1065)
2022-01-04Tools/mmaps_generator: Made loading vmaps by mmaps_generator threadsafeShauren
2022-01-04Core/MMAPs: Restore single slope angle of 55°jackpoz
Re-generating MMAPs IS required. Partially reverts 995a443da219ec773febd7dd29d18f3cefaa1f3b . Having 2 different slope angles of 55° and 85° created too many polygons to fit in the current mmtile structure. This caused some polygons to become disconnected from each other, creating the old "invisible walls" effect. Because of this and because of the performance hit when loading a mmtile caused by the increase of polygon numbers, this commit reverts the recent changes and sets by default the slope angle to 55°. Feel free to restore the previous behaviour by running .\mmaps_generator --maxAngle 85 --maxAngleNotSteep 55 , specifying the map id as number if a single map should have different slope values. This is the last commit that will change MMAPs version to force re-generating them. Any future change that will affect only the generation settings will be optional (but recommended). (cherry picked from commit 3947e4cb57d4c6adb78cd3cb52718bb88add91fc)
2022-01-04Core/MMAPs: Fix small steps being considered as NAV_AREA_GROUND_STEEPjackpoz
(cherry picked from commit 3ac1992afbeb1cd7669b300b8ee4131d39f35595)
2022-01-04Tools/MMapsGenerator: Add some more input parameters to improve mmaps load ↵Giacomo Pozzoni
performances (#25520) * Some research about mmaps load performances * Tools/MMapsGenerator: Add some more input parameters Add some more input parameters which affect the resulting mmaps: - --smallOutputSize: sets both walkableSlopeAngle and walkableSlopeAngleNotSteep to 55°, reducing by a lot the .mmtile size and the number of polys. A rcFilterLedgeSpans() call is included too to filter out some polys. Default to false. - --maxAngle: Restore this parameter removed some commits ago. Specifies the max walkable angle of a Creature when in combat. Default to 85 - --maxAngleNotSteep: Max walkable angle of a Player and of a Creature out of combat. Must be less or equal than --maxAngle. Default to 55. A performance profiling comparison highlighted that .mmtile load grows exponential with the number of polys. A small server with GridUnload enabled and without preloading all grids on startup will be more affected than a big server with GridUnload disabled and preloading grids on startup. (cherry picked from commit b6e205f7ef32f7b82644043d82a808e67cc9acb2)
2022-01-04Handle different slopes in mmaps (#24765)Giacomo Pozzoni
* Tools/MMAPs: Remove input argument --maxAngle Remove input argument --maxAngle . This should be just hardcoded in MapBuilder::GetMapSpecificConfig() so all settings are easily found in the same place instead of being spread around. * Tools/MMAPs: Add new area type NAV_AREA_GROUND_STEEP Add new area type NAV_AREA_GROUND_STEEP for ground with slope in the range (55, 70] . NAV_AREA_GROUND is used for ground with range [0, 55] . NAV_AREA_GROUND_STEEP takes priority over NAV_AREA_GROUND. * Tools/MMAPs: Fix NAV_GROUND_STEEP flag not being saved in the mmtile * Core/PathFinding: Implement NAV_GROUND_STEEP flag Implement NAV_GROUND_STEEP flag, used only by Creatures that are in combat or evading. * Distinguish between RC_WALKABLE_AREA and NAV_AREA_GROUND. * Allow mobs in combat to walk on steeps up to 80° * Allow mobs in combat to walk on steeps up to 85°. Disable rcFilterLedgeSpans() filter as it removed long steep spans. * Increase cost of steep spans to try making creatures walk around obstacles instead of walking on them * Revert last commit (cherry picked from commit 995a443da219ec773febd7dd29d18f3cefaa1f3b)
2022-01-04Tools/MMAPs: Output the time spent in a human readable formatjackpoz
(cherry picked from commit 6e34e07c48000e666ec15b26682eb15fb2f5f901)
2022-01-04DB/Creatures: corrected several movement template flight values for ↵Ovahlord
creatures all accross Northrend. No more raining Gargoyles, Frost Wyrms, Birds and other flying things (cherry picked from commit 8a9f80909387615fb7e22a0f8a042c3ad7a10cfc)
2022-01-04Core/Objects: fixed destination calculation for destination based spells ↵Ovahlord
casted by flying units * Additionally he PathGenerator will now check for realtime movement flags instead of creature based template data only so scripted flying movement and players will now correctly get their path calculated (cherry picked from commit fdcb7388a64bf61a691535933a9fbae0504b80cc)
2022-01-04Core/Commands: Fixed .npc add overwriting existing spawns when used on ↵Shauren
transports (cherry picked from commit 75ab3619bdec058dcc848ad134c6d5e838e8f6fb)
2022-01-04Fixes/3.3.5 aura infinite loop (#24631)Giacomo Pozzoni
* Core/Auras: Attempt to fix infinite loop with aura 18950 on map unload * Core/Auras: Log a detailed error and assert when failing to remove all auras after a few tries * Code cleanup * Fix build warnings * Fix more build warnings (cherry picked from commit bd2d60c2676a1d7e843a2a5673b8216bad0768c7)
2022-01-04DB/SAI: Black Morass - Infinite mobsoffl
Closes #4613 (cherry picked from commit 8ad0ab362ee3e8ff5563d0ea3383d3d32969d27e)
2022-01-04Removing a duplicate item combat spell handling causing poisons (and others) ↵joshwhedon
to proc twice. (#24627) https://github.com/TrinityCore/TrinityCore/issues/24608 (cherry picked from commit 4db77bc913a24ce7a14428a2936c836728ba4100)
2022-01-04Core/MMAPs: Adjust walkable climb and fix a lot of mmap raycast issues (#24539)Giacomo Pozzoni
* Core/MMAPs: Adjust walkable climb Adjust walkable climb as recast using walkableClimb also to find the poly from a position, giving priority to polys that are below the position but closer than walkableClimb. * Temporarily disable static collision (the whole check should be removed) * Core/Spells: removed deprecated mmap path check for TARGET_DEST_CASTER_FRONT_LEAP * Core/Objects: allow flying units to use the helper as well (flying units casting radius based spells) * Code refactor * Handle raycasts that end in a point with no height in the mmap mesh as PATHFIND_NOPATH * Walk back a bit from raycast hitpoints as sometime the 2D result point is outside of the polygons due to floating point errors. * Remove whitespace * Revert 4a197ba22af4eed01be632ea2dd7d103a963f043 as a raycast point path should have the Z retrieved with getPolyHeight(). Raycast will only return a 2-point path with Start and Hitpoint/End * Cleanup PathGenerator raycast case * Fix PathGenerator raycast broken if start and end are on same poly. Fix PathGenerator raycast broken if no wall is hit. Remove unused case of using raycast with an existing previous path (can be added back properly if needed). Remove forcing poly length to 2 when we actually have already the right number. * Use closestPointOnPolyBoundary on the second try of finding a point on poly for raycast. Note that in this case the mesh height is not used which might cause issues. The poly boundary height will be used instead. * Handle cases where getPolyHeight() fails because the point is on polygon border (and caused by floating point imprecision) * Add far from poly flags * Set PATHFIND_INCOMPLETE in raycast case if startFarFromPoly or endFarFromPoly * Fix blink close to walls with no valid polygon behind the wall * Require to re-extract mmaps Co-authored-by: Ovah <dreadkiller@gmx.de> (cherry picked from commit c0b75bf40da8b447a2f3533dabbfad9eba7c6ea1)
2022-01-04Further improve ChrRace DBC handling (#24508)HelloKitty
* Core/DBC: Added ChrRacesAllianceType for ChrRaces.dbc * Core/Character: Check ChrRace DBC playable in HandleCharCreateOpcode * Core/DBC: Implement ChrRacesFlags removing literals Cannot take credit for this enum, derived from documentation in https://wowdev.wiki/DB/ChrRaces * Core/Character: Check CHRRACES_FLAGS_NOT_PLAYABLE on creation * Core/DBC: Fix formatting of ChrRaces enums * Core/DBC: Use ChrRaces CreatureType instead of hardcoded humanoid assumption * Address enum style code changes (cherry picked from commit 43b595111dce03258c29fd926201660b9d3acb8d)
2022-01-04Scripts/Icecrown Citadel: Fixed Professor Putricide oozes not moving during ↵Shauren
their channel (cherry picked from commit 1d43003cfa29cee2c7921fdeaa5c1714d085c770)
2022-01-04Core/CreatureAI: Shambling Horror re-cast Enrage as soon as it is not stun ↵Metalaka
(#24618) (cherry picked from commit e2434e4f4726f9c99f9260607b78ece09b5df249)