aboutsummaryrefslogtreecommitdiff
path: root/src/server/game
AgeCommit message (Collapse)Author
2021-12-19Core/Creature: Remove empty spell ids from CreatureAddon.auras vectorGiacomo Pozzoni
Close #23969 (cherry picked from commit f20265feafbf28f722338649740bd11a9e48f2e7)
2021-12-19Core/Creature: Log an error for Creatures spawned with temporary aurasjackpoz
The errors still need to be addressed. Close #23225 (cherry picked from commit 54f94567649c78d146f4087cc874e4d0cbcff28b)
2021-12-19Core/Log: Gameobjects may have faction template id = 0Killyana
Ref https://github.com/TrinityCore/TrinityCore/pull/22922 (cherry picked from commit 8b03fe95061f870efbe5352530c25a0175c4d8ee)
2021-12-19TabsKillyana
(cherry picked from commit d8e12d826c300704d027970a93c5943798be8186)
2021-12-19Core/Spell: Reset threat to zero when the hunter use Feign DeathTreeston
Closes #23874 (cherry picked from commit d4b00df78191bb0e6b79bc99e6ca7a2bf8091eba)
2021-12-19Core/AI: add another helper for "ScriptedAI::ForceCombatStop"ccrs
(cherry picked from commit 3842ab2781e4ca518d98d4f50566e42eeced18bf)
2021-12-19Core/GameObjects: Skip LoS checks for traps (#23936)Giacomo Pozzoni
* Core/GameObjects: Skip LoS checks for traps * Core/GameObjects: Fix spells cast by traps missing always * Scripts/Spells: Fix WSG heal buff not healing The WSG green heal buff is now cast by a GameObject so the spell target should be used to calculate the healing, not the GameObject. (cherry picked from commit 909941e1b44250b0fa646d363af817f40ca48355)
2021-12-19Fixed pets repositioning themselves after every cast (#23923)Ovah
(cherry picked from commit 4ddf7f59761df525e6ab5ef99175258a1d86101d)
2021-12-18Core/Spells: add spell fix to Trained Rock Falcon (#23896)Trond B. Krokli
fixed by sirikfoll (cherry picked from commit 42f1861f3023af2eff66dc64e78164f3c480337e)
2021-12-18Core/PacketIO: Restrict CMSG_STANDSTATECHANGE to only allow the same stand ↵Shauren
states that client can send by itself (cherry picked from commit 267bdde3232566e210659df47dc7580e676e9ee5)
2021-12-18Scripts/ScarletMonastery: instance script cleanup (#23889)ccrs
Adapt InstanceScript into newer structure and style Adapt existing boss scripts into newer structure and style Improve existing boss related definitions Should make each boss more functionally reliable, but nothing new has been added (cherry picked from commit 06c6b30ed484850228c57313dc2c024c38e2055f)
2021-12-18Core/Movement: prevent any Initialize queue till AddToWorld is signaledccrs
(cherry picked from commit c9c6871659bf2be52b4656bc641df5211fcb928f)
2021-12-18Core/Movement: d033032 followupccrs
now THATS a typo... sorry folks (cherry picked from commit bc9a9ad7e1226573493e3cb10885365322fdbbbf)
2021-12-18Core/Movement: d033032 followupccrs
ty jackpoz (cherry picked from commit 5d056f37c74b652b3a3372d6aa88ac5e183f9d98)
2021-12-18Core/AI: 06443e3 followupccrs
(cherry picked from commit bb9af06cd4ff80f078fcb6ae4871c74a1a174bcc)
2021-12-18Core/AI: add missing public tag & correct alignmentccrs
(cherry picked from commit fe7c2c377288339a2ba95e2bba226b815d79ba55)
2021-12-18Core/Movement: d033032 followupccrs
ty jackpoz (cherry picked from commit bc507209a706cddb33a0a14bffc94d4db50ddce6)
2021-12-18Core/AI: 06443e3 followupccrs
cause its not "that" horrible (cherry picked from commit a71c5f4c7f35b074397abfcc9b925e80720f8c75)
2021-12-18Core/Movement: delay movement update in MotionMaster until its owner signals ↵ccrs
AddToWorld ref #23199 closes #23876 (cherry picked from commit d033032d33cff5dae76000f8432d78746cda9e06)
2021-12-18Core/Totem: Change log level of a logAokromes
To much spam of people doing quests with totem-like creatures (cherry picked from commit 69b7958ebcebbf52e95323f4578cfbffe51635d6)
2021-12-18Core/GameObject: Fix battleground flags not showing burning animationjackpoz
Fix battleground flags not displaying the typical burning animation when they "despawn" (they don't actually despawn, they just change state) (cherry picked from commit 90bb10aa3a490fc701e6f98b32310687af80dea5)
2021-12-18Core/Misc: Fix C++17 build errorsjackpoz
(cherry picked from commit 30823f9b79b4ad16f96e90692a900f68a7f63c0a)
2021-12-18Core/Defines: define UNIT_FLAG_SWIMMING (#23630)ForesterDev
(cherry picked from commit c03c88d0c02c5dda9f14dec1ed151ca30a92118e)
2021-12-18Core/Achievements: fixed bug with counting honorless units for achievement ↵ForesterDev
type ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL (#23844) * Core/Achievements: fixed bug with counting honorless units for achievement type ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL * Remove codestyle changes * Remove codestyle changes (cherry picked from commit f4be5446293e9896fe8e1cd9db8dc739af848cae)
2021-12-18Core/AI: Add new method to force creatures around to stop combatjackpoz
(cherry picked from commit 06443e38e761ed8ac7ce803c39bbbc7263983479)
2021-12-18Core/Taxis: teleport players to the destination taxi node location instead ↵Ovah
of their current ground position (#23835) * Core/Taxis: teleport players to the destination taxi node location instead of straight to their current ground position * fixed a typo (cherry picked from commit 7fcb77ecd12c42b8a468e8f932948c99c249a458)
2021-12-18Core/LFG: Fix re-queueing while in a dungeon (#23862)Giacomo Pozzoni
Fix an issue that wouldn't allow to re-queue after joining a dungeon, having 1 member leave/get kicked, queue, leave, queue. In this case a message "One or more dungeons was not valid" would be displayed because LFG would try to queue the group as "continue dungeon" but the current group was not marked as "in dungeon" state anymore. (cherry picked from commit abcad7cda5375478f475bb9624c578169e84c559)
2021-12-18Core/LFG: Remove Dungeon Cooldown when getting kickedjackpoz
(cherry picked from commit ada4e431ae77cf56e6f5e4441b494dd25d6b3fb9)
2021-12-18Core/Misc: Fix issues reported by static analysisjackpoz
Fix issues reported by Coverity Scan (cherry picked from commit 88317a4ec8a4fae2f914fb699e8fb0fff1da3205)
2021-12-18Scripts/Forge of Souls: Fixed spell Soul Sickness (#23843)Keader
(cherry picked from commit 34ee2effc89dc5bb34b4873dbfed6081ea8cb685)
2021-12-18Core/Pet: Fix guardians low damage (#23840)Giacomo Pozzoni
Fix guardians low damage for unhandled cases in Guardian::InitStatsForLevel() (cherry picked from commit b3b8ec811daab65d4b94cad950a460240b02390b)
2021-12-18Core/Movement: fixed taxi pathings getting finalized earlier than intended ↵Ovah
(#23830) * Core/Movement: fixed taxi pathings getting finalized earlier than intended Since we handle the intial starting point of a spline properly now the update logic was still expecting the old handling which resulted in incrementing the current node index earlier than intended * apply a missing change (cherry picked from commit c1e3d79a4fb5b7b1a9bca36ecd16b9bb902ced92)
2021-12-18Core/Misc: Fix static analysis issuesGiacomo Pozzoni
Fix static analysis issues reported by Coverity (cherry picked from commit ca8953a0ec8356345147b2bbc7bbdf0fa97cd625)
2021-12-18Core/Misc: Fix static analysis issueGiacomo Pozzoni
Fix static analysis issue (cherry picked from commit ed087546635331e4cff4e97772a9f9978f4b1833)
2021-12-18Fix inconsistent NPC aggro on spell miss (#23816)tarwyn
(cherry picked from commit c8dc9fdc418d9703893e21603b7593b015f08fea)
2021-12-18Core/Movement: provide an extra spline path vertex for taxi pathings … ↵Ovah
(#23817) * Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost. * Update FlightPathMovementGenerator.cpp (cherry picked from commit cf3277c641bd877b9fa1939da5da7cde1778561b)
2021-12-18Core/Map: Move a log from ERROR to WARNjackpoz
Move "Could not load MMAP" log from ERROR to WARN as 99% of times is a false positive (cherry picked from commit 42ab6010f862e530517e2acd347ef6230bcf1c3b)
2021-12-18Core/Calendar: Add some additional validation when creating events (#23797)Giacomo Pozzoni
* Core/Calendar: Add some additional validation when creating events Allow only 30 player events and 100 guild events to be created. Don't allow to create guild events if player is not in guild. Send some more error messages to the client (not blizzlike errors but better than nothing). * Core/Calendar: Add some additional validation/checks Add guild id check in GetPlayerEvents(). Change error message in HandleCalendarCopyEvent() to be the same as in HandleCalendarAddEvent() when creating an event in the past. * Core/Calendar: Add some additional validation/checks Reduce the number of CMSG_CALENDAR_ADD_EVENT packets a seconds allowed from 10 to 3. * Core/Calendar: Add some additional validation/checks Implement 5 seconds cooldown between the creation of calendar events * Core/Calendar: Add some additional validation/checks Don't allow to copy events of a different player/guild * Core/Calendar: Implement automatic deletion of old events Implement automatic deletion of events older than 1 month (30 days). Fix debug assertion triggered when deleting a character with calendar events. Avoid double std::set lookup when deleting events when deleting a character. NB: The whole CalendarMgr/CalendarHandler code should be checked line by line for bugs/crashes/exploits. (cherry picked from commit fb059722fdb18a94d47b3f44a5b2d7f183bf5a29)
2021-12-18Core/Movement: Fix LoS issue of NPCs chasing targetsjackpoz
Add Line of Sight checks to ChaseMovementGenerator::Update(), fixing to ChaseMovementGenerator not reaching a point with valid LoS to the target. Fix re-implements 8927a042536d4671e94ad901e9209efcf78ffa2c after 2a84562dc85516f432bb1e5de9add23c28b26ce4 partially removed it. Fix #23724 (cherry picked from commit 215a6cee24896f2def2a5af390c089ac1d947e65)
2021-12-18Core/MovementGenerator: 680e1cbd6cf7c52abe104fb87d8fa6dba83fb633 follow-upjackpoz
(cherry picked from commit 7c0b31b8b52903ec233ad863597965594196a8e8)
2021-12-18Core/MovementGenerator: Fix crash in taxi pathsjackpoz
Fix a crash in taxi paths happening when joining a battleground/dungeon while on a taxi path after second last node but close to last node, then leaving/finishing the battleground. (cherry picked from commit 680e1cbd6cf7c52abe104fb87d8fa6dba83fb633)
2021-12-18Core/Misc: Fix parry-haste mechanic. (#23773)Gildor
* Should check victim that do a parry instead of the unit that deal the damage (Wrong implementation of this commit: 4a46fee03ef204289bbd96e8e1e07117b3bebd9f ) Closes #23754 (cherry picked from commit f8d7b260476c69e09ab0329cb7cd6c277f5473a7)
2021-12-18Scripts/Outland: Fix npc_ancestral_wolf not starting waypoint (#23763)Artamedes
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons * fix nopch (cherry picked from commit 0b3a9e2a2b2537e7224d103947ad6028c6d2e5fe)
2021-12-18Core/Handlers: Handle CMSG_REQUEST_PET_INFO - this fixes when you /reload ↵Artamedes
and the pet bar disappears (#23762) (cherry picked from commit 6ebe1afeeccb847702c12e522bddaa7b5694dc38)
2021-12-18Core/Creature: Fix another pet assertjackpoz
Fix an assert triggered when dismissing a Warlock pet while it's casting a spell (cherry picked from commit 4074cb0f01d106c69546c3cb944d6fcf92ade456)
2021-12-18[3.3.5] Fix spell_area not checking for zoneID for quests (#23719)AlιAѕѕaѕѕιN
* Fix spell_area not checking for zoneID for quests * Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8 * Fix spell_area handle same spell with the same quests Also fix not checking for quest_end at all. * Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d * Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7 * Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d (cherry picked from commit 92d83c3c2eaba3f5b58dc98472318872f3a54706)
2021-12-18Core/Misc: Fix linux buildjackpoz
(cherry picked from commit c4cce31a13b2e98538f015ecf289856c73f13037)
2021-12-18Core/MMaps: Fix mobs evading when target is out of MMap meshesjackpoz
Fix mobs evading when target is out of MMap meshes causes by an overzealous check added in c602220e02bed1ad76c9e60064eeec5fd97bfe80 when trying to fix an infinite loop in Recast. If the target is outside of the MMap mesh (for example very close to a wall which is an un-walkable area with current TrinityCore settings and that might be changed in the future) Detour will not be able to find the height of the poly and getPolyHeight() will return DT_FAILURE | DT_INVALID_PARAM . Most of the time this is ok and can be ignored and it's still better than having the Unit evade. Fix #23613 (cherry picked from commit 5a980226497605b18f1855fa39f340c10ee9dd53)
2021-12-18Core/Map: Kill zoneId from RespawnInfo, all it did was significantly slow ↵Shauren
down startup to make one gm command faster (cherry picked from commit 3a4216fd979eb2a7667b0861a770e9af4f242eab)
2021-12-18Core/Spells: Fixed some issues with Drain SoulKeader
Issue 1: Drain soul was always negative, but effect2 need be positive. Issue 2: Drain soul was interrupted if someone in your group die. Caused by negative effects proccing in creature. Issue 3: Since effect2 is positive, it was down-ranking in low level targets and should never happens (fixed before by ariel, transforming everything in negative in 2c8a6fb771a42169a1817149ab0a2a19912ebea7 but it's wrong) (cherry picked from commit 43c08b176115505b76c027667047f9a5bfcc4e11)