aboutsummaryrefslogtreecommitdiff
path: root/src/server
AgeCommit message (Collapse)Author
2020-08-17Core/Spells: Fix summoning warlock pets in case that pet has never been ↵Shauren
summoned before
2020-08-17Core/Spells: Fix summoning SUMMON_PET type petsShauren
Closes #25265
2020-08-17Core/ChatCommands: Move Trinity::ChatCommands::Variant from boost::variant ↵Treeston
to std::variant (for real this time)
2020-08-17revert 1aeb7a0 and f9e7dbd until I can work around GCC being sillyTreeston
2020-08-17How did this even build in VS???? (don't kill me shauren) (f9e7dbd follow-up)Treeston
2020-08-17Core/ChatCommands: Move Trinity::ChatCommands::Variant from boost::variant ↵Treeston
to std::variant, which means we no longer need visitors
2020-08-17Core/ChatCommands: Add support for std::array-type arguments (#25261)Peter Keresztes Schmidt
2020-08-16Core/Pets: Pet management refactoring (#25191)Shauren
* Core/Pets: Pet management refactoring * Preload basic pet data on character login with async query * Load additional pet data (declined names/auras/spells/cooldowns) using async query after we are sure pet loading will succeed * Remove all select queries related to pet stable/unstable * Remove all silent pet deletions except explicit UI-triggered abandons * Fixed displaying stable master content when current pet is not summoned * Allow to stable/swap unsummoned current pet Closes #3610 Closes #21266
2020-08-16Core/ChatCommands: Do not parse partial strings for numeric paramters (PR ↵Peter Keresztes Schmidt
#25259) Check if integral/floating point type arguments were parsed successfully. std::stoull will happily parse floating point strings until the decimal separator and return the value. Make sure for all parsing methods that we actually parsed the whole token. This allows to use handler arguments like Variant<uint32, float> which will be populated with the right type depending on the token value (e.g "10" vs "10.0").
2020-08-16Core/SAI: Spell casts that cannot be executed because the unit is currently ↵Giacomo Pozzoni
casting another spell will be retried asap with priority over other events (#25238) * Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events * Core/SAI: Re-sort the events only when needed * Fix some priority reset and wrong mEventSortingRequired handling * Code cleanup. Sort only events loaded from db (not stored events, not timed action list). * Code cleanup. Raise priority of failed casts so they are retried before other spells * Keep priority of the action fails and is rescheduled on next update * Don't try recasting a spell in SMART_ACTION_CAST if there are multiple targets and at least 1 was successful
2020-08-16Core/ChatCommands: Honor exact matches during enum arg parsing (PR #25255)Peter Keresztes Schmidt
2020-08-16Scripts/Commands: Use enum type arg for HandleDebugAnimCommand (PR #25256)Peter Keresztes Schmidt
* Core/Shared: Make Emote enum smart * Scripts/Commands: Use enum type arg for HandleDebugAnimCommand
2020-08-16Core/Warden: Fix for LUA_STR_CHECK (#25247)scizzydo
The check above is what I use to actually get a real result for LUA_STR_CHECK, which when I used variables that would have a string to them it actually fails the check. When checking for items like a function if it exists of course it won't work... In addition, fixing the Unk2 to Unk3 causes people to be able to adjust the address of the check to the address 0x00419210 to make warden perform the FrameScript__Execute to run lua on the client. This seems to be the big request like in https://github.com/TrinityCore/TrinityCore/issues/23035
2020-08-16Core/ChatCommands: Add support for enum type arguments (PR #25242)Peter Keresztes Schmidt
2020-08-15Core/Unit: Make HandleEmoteCommand typesafe (#25249)Peter Keresztes Schmidt
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter * Scripts/HoR: Fix wrong emote during escape event * Core/Unit: Make improve type safety of HandleEmoteCommand Change argument type to the expected enum type Emote * Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE UNIT_NPC_EMOTESTATE is no flag field
2020-08-15Core/Spells: Mark constructors of Spell/AuraScript handlers as explicit (#25248)Peter Keresztes Schmidt
Mostly to make clang-tidy happier
2020-08-15Core/PacketIO: Update SMSG_QUESTGIVER_QUEST_DETAILS (#25232)Peter Keresztes Schmidt
* Core/PacketIO: Update SMSG_QUESTGIVER_QUEST_DETAILS * Core/PacketIO: Name RewardFactionFlags field of QuestInfo struct
2020-08-15Script/Quest: The Light of Dawn (#25243)Aokromes
remove incorrect check, source: https://www.wowhead.com/spell=53606/the-light-of-dawn Flags Can be used while dead https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=1495830 https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=374127
2020-08-13Core/AI: Remove code that removed UNIT_DYNFLAG_LOOTABLE from possessed units ↵Giacomo Pozzoni
(#25229) * Core/AI: Remove code that removed UNIT_DYNFLAG_LOOTABLE from possessed units * Update PassiveAI.cpp Restored logic that removes loot flag while being possessed * Restored logic that removes loot flag while being possessed
2020-08-12Scripts/Naxxramas: Adjust Frogger event timer (#25214)Gildor
* Scripts/Naxxramas: Adjust Frogger event timer Co-authored-by: Carbenium <carbenium@outlook.com>
2020-08-12Script/Quest: fix (More) Torch Catching (#24907)Rothend
* Script/Quest: fix (More) Torch Catching. Closes #24893 Co-authored-by: Carbenium <carbenium@outlook.com>
2020-08-11Core/Warden: Warden refactors (PR #25235)Treeston
2020-08-09Core/SAI: Fix creatures casting with flag SMARTCAST_COMBAT_MOVE not ↵Giacomo Pozzoni
switching to melee when the school of the spell they are trying to cast gets silenced (and other cases of spell failure) (#25226) * Core/SAI: Fix creatures casting with flag SMARTCAST_COMBAT_MOVE not switching to melee when the school of the spell they are trying to cast gets silenced (and other cases of spell failure) * Core/SAI: Retry casting after 500ms if a cast failed Fixes #24914
2020-08-09Core/Misc: Code cleanupjackpoz
2020-08-08Scripts/Command: Fix .mmap loc always printing command usagejackpoz
2020-08-08Core/Warden: Fix Warden reporting false positive checksjackpoz
Issue introduced in 210176fd915cf4ba16f428d3c1a249a71f4aa7a7
2020-08-08Game/ActionHouse: Fixed some clothes chests not showing in AH (#25150)Keader
2020-08-08Scripts/BlackwingLair: Suppression Device Room (PR #25199)Jinnaix
Co-authored-by: offl <11556157+offl@users.noreply.github.com> Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com> Co-authored-by: Treeston <treeston.mmoc@gmail.com>
2020-08-07Core/CrashHandler: #ifdef cleanup to make VS not choke when parsing, fixed ↵Shauren
file being all red in editor
2020-08-07Core/Units: add new functionality for units to block or enable combat ↵Ovah
interactions (#25168) * Core/Units: add new functionality for units to block or enable combat entirely via helper to reflect what CREATURE_DIFFICULTYFLAGS_IGNORE_COMBAT and client AI functions imply * yeah... * Nuke Creature::IsCombatDisallowed helper as its unused by now * no combat extra flag may now be changed on transforms if the transformed entry does not have the flag
2020-08-07Core/Updater: Fix detection of the mysql binary when a directory is given as ↵Carbenium
path This ensures that we never pass a directory path StartProcess which results in a crash. Closes #25216
2020-08-06Core/PacketIO: Name previously unknown fields in lfg packetsShauren
2020-08-06Core/Misc: Code cleanupjackpoz
2020-08-06Core/Packets: updated CMSG_LFG_JOIN and CMSG_LFG_LEAVE to new packet handlingOvahlord
(cherry picked from commit 6abeb365842c506f2151e01e87e2981ee7ff0a7e) # Conflicts: # src/server/game/Handlers/LFGHandler.cpp # src/server/game/Server/Packets/AllPackets.h # src/server/game/Server/WorldSession.h # src/server/game/Server/WorldSocket.cpp
2020-08-06Core/Unit: Creatures' minions now engage in combat if their controller is ↵Jinnaix
attacked (PR #25219) Closes #24340
2020-08-06Core/Object: Deduplicate some checksTreeston
2020-08-06Core/Battlegrounds: Fix error messages in Isle of Conquestjackpoz
Fixes #24032
2020-08-06Core/SAI: Fix creatures casting spells while moving with flag ↵jackpoz
SMARTCAST_COMBAT_MOVE Fixes #24019
2020-08-06Scripts/Comamnds: Improve ".debug objectcount" command (#25208)Giacomo Pozzoni
* Scripts/Comamnds: Improve ".debug objectcount" command Include the top 5 most common creatures in the map * Use C++ features to copy data * Fix build warnings * Update src/server/scripts/Commands/cs_debug.cpp Co-authored-by: Shauren <shauren.trinity@gmail.com> * Update src/server/scripts/Commands/cs_debug.cpp Co-authored-by: Shauren <shauren.trinity@gmail.com> * Update src/server/scripts/Commands/cs_debug.cpp Co-authored-by: Shauren <shauren.trinity@gmail.com> * Move CreatureCountWorker out of function and use template for unhandled cases * Code cleanup Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-08-06Core/Authserver: Deprecation of sha_pass_hash (PR #25138)Treeston
see also #25157
2020-08-05Scripts/Kologarn: Apply CREATURE_FLAG_EXTRA_NO_COMBAT on ↵jackpoz
NPC_ARM_SWEEP_STALKER and NPC_RUBBLE_STALKER
2020-08-05Scripts/Naxxramas: Frogger event improvements (#25202)Gildor
* Scripts/Naxxramas: Frogger event improvements * Prevent Living Poison accumulation * Now Living Poison cast Explode * check for a nearby player * move event to the frogger trigger's AI * Initialize and removing unnecessary things * applying suggestions * remove unnecessary header * Rename 9999_99_99_99_world.sql to 2020_08_05_00_world.sql
2020-08-05Scripts/World: updated Training Dummy script to modern model and removed ↵Ovahlord
pointless GameTime shenanigans
2020-08-04Scripts/AzjolNerub: Fix potential error in pound spell scriptCarbenium
Cast damage spell in AfterEffectApply instead OnEffectHitTarget. This avoids the scenario where we try to apply an aura to a potential dead target. Ref #21856
2020-08-04Core/Common: Move old-style pointer+size HexStr methods to Trinity::Impl ↵Treeston
where they can't hurt anyone
2020-08-04Core/Misc: Fix compile errors found with msvc /permissive-Shauren
2020-08-04Core/Metric: Require WITH_DETAILED_METRICS CMake flag for MMaps metricjackpoz
2020-08-04Core/Misc: Fix static analysis issues (#25194)Giacomo Pozzoni
2020-08-03Scripts/Outland: Convert 'Captain Tyralius' to SAI (#25188)Trond B. Krokli
Closes #24676
2020-08-03Core/DB: Split `accounts`.`session_key` into `session_key_auth` (3.3.5) and ↵Treeston
`session_key_bnet` (master), so the branches will no longer break each other's realm switching.