aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2021-12-02Core/Misc: standarize a couple logsccrs
(cherry picked from commit aee26eb46727171593ef7cc1d2652a7847dc88fc)
2021-12-02Core/Pet: Change assert to error logjackpoz
Change assert added in 43dec9e4d0b6f7da3c2051624742e9fb8a9bcb31 to error log since charmed creatures lose their AI until next map update (cherry picked from commit 70fcdc687d1227a796c03f6353fc8dbfc4f4aea3) (cherry picked from commit f45ebe71b0d8f6e3008514324a58a92c0db3810e)
2021-12-02Core/CrashHandler: Remove sensitive data from crashlogsjackpoz
(cherry picked from commit 25bcb1a0b2d9326519d9226dfe968caf26bb4e2d) (cherry picked from commit 37478c5ac1efb8e4f19ffc94f444e160600c7b27)
2021-12-02Core/Misc: Fix some GCC 8 warningsjackpoz
(cherry picked from commit 26b6cb0584b50a2540e977cac8fa040c82fe7bb4)
2021-12-02Core/MMaps: Revert PATHFIND_INCOMPLETE handling change in ↵jackpoz
ChaseMovementGenerator in 386b5a6fd948b4866cbd9a8a9892e8777922e9c9 since the current hp reset code in Creature::Update() will reset the hp of bosses as soon as CanNotReachTarget() is true. In case of boss mechanics like Abub'Rekhan at Naxx where the boss throws the player in the air, a PATHFIND_INCOMPLETE path is returned. The code in Creature::Update() should be modified to wait a few seconds before resetting the hp. PATHFIND_NOPATH / PATHFIND_INCOMPLETE don't really mean that the Creature can't attack the player anyway either. (cherry picked from commit d910ffd77949f422bd08f12079866962fb53c4dc)
2021-12-02Core/Scripts: Rename recent GameObject spell overloads to fix GCC warningsjackpoz
Rename recent GameObject spell overloads (they used to accept only Unit as parameters) to fix GCC warnings about partial function override. (cherry picked from commit e3a9a9bfb2cba3fc1f6ed616b07fb0ea88de461f)
2021-12-02Scripts/Commands: Add .debug asan commandsjackpoz
Add ".debug asan memoryleak" and ".debug asan outofbounds" commands to trigger Address Sanitizer warnings at runtime (or other dynamic analysis tools) (cherry picked from commit 71d15ea25be3e86646faaa3266617a0b8177972f)
2021-12-02Shared/Metric: Fix a rare memory leakjackpoz
Fix a memory leak in Metric happening only when enabling/disabling Metric from configs at runtime, leaking the metric added between last SendBatch() call and the ScheduleSend() call in the same function. The only way to reproduce this is to actually freeze the thread calling SendBatch(), disable metric, reload config, unfreeze the thread. (cherry picked from commit 0d1ff7446dce7b0641f49ac55a008669838612cd)
2021-12-02Scripts/Guards: Fix infinite loop in npc_air_force_botsjackpoz
Fix infinite loop in npc_air_force_bots happening when aura 38067 was removed, triggering MoveInLineOfSight() that would add back the aura. Only 1 aura add/remove for guard for player is allowed now. (cherry picked from commit 844e7ee9262a5ba035ac9e8a6ffc298fb97fd3a9)
2021-12-02Core/Commands: Fix .cheat god command letting you diejackpoz
Fix .cheat god command still letting you die with Area Aura like Slime near Thaddius, broken since 777b287dff8bce806849a26d59fe40f864c385ed (cherry picked from commit f26f716714fefa2af4c6e3eea263206682d45236)
2021-12-02Core/Maps: Fix crash caused by setActive(false) called after DespawnOrUnsummon()jackpoz
Fix crash caused by WorldObject::setActive(false) called after WorldObject::DespawnOrUnsummon() happening because the WorldObject would be set as not active but then Map::RemoveFromActiveHelper() would not be called because of not being in world anymore. Whenever setActive() gets desync'd with what Map actually contains a rare crash would happen since Map only reads a few values of the active WorldObject, making it hard to reproduce. If this happens again some ASSERT calls should be added (or a check in Map::RemoveFromMap() could be added about if the WorldObject is in Map::m_activeNonPlayers container). (cherry picked from commit 1c833f28e471e3787f1d328e44af5f065ad9ca8c)
2021-12-02Core: Restore reset in EscortAI::InitializeAI (#23197)Killyana
Closes #23008 (cherry picked from commit 56b65329e5dc2fb04d5b1d6068d957490146ee89)
2021-12-02Core/Object: Range check (#23179)Jozef Dúc
* Should solve #23062. All credits to @xvwyh * Remove unused variables * Remove unused variable * Cast int32 to uint32 * Remove G3D headers from core header file * Change door distance * Update GameObject.cpp Add newline * Update GameObject.h Indentation (cherry picked from commit 32e1de39a26628dcb64bc21ad415afb2ad938925)
2021-12-02Core/GameObject: Code cleanupjackpoz
(cherry picked from commit 16a154c4e87ff1ff89323a8960bf601e6c18589b)
2021-12-02Core/GameObject: Remove summoned gobs properly from the map without ↵Killyana
effecting other cases Ref https://github.com/TrinityCore/TrinityCore/commit/0e8e3828f48120629b642d0de1db704fd0bb86cb Ref #23115 (cherry picked from commit 9db64666dc30b1f8cad904bf8aeea1c9daf41c95)
2021-12-02Scripts/Commands: add some missing checks for .guild create command (#23201)ForesterDev
* Core/Conditions: implement CONDITION_GAMEMASTER * Scripts/Commands: add some missing checks for .guild create command (cherry picked from commit ae8750716f63ddc41f21bb38ceafe949d7260f0e)
2021-12-02Scripts/Trial of the Crusader: Fixed Resilience will Fix achievementKeader
Broken by 2362e9c79410c689afc10266b94f7e78c88bbddc (cherry picked from commit f163c2f96a28e799ec0bc881c7e5f4091719a59b)
2021-12-02Core/GameObject: Delete summoned gobs and DestroyForNearbyPlayers gobs ↵Killyana
spawned with negative spawn time once the gob is deactivated (cherry picked from commit 0e8e3828f48120629b642d0de1db704fd0bb86cb) (cherry picked from commit 65afe47580e84a006eb6ce506623d3719ae5bc9b) (cherry picked from commit 21667f97cbd519dbef1650cd29d53f26443441f3)
2021-12-02Scripts/Scarlet Enclave: Unworthy Initiate (#23195)Sorikoff
(cherry picked from commit 4468a538ff9bd73ed008864391b0ee4fb3172b9f)
2021-12-02Scripts: Minor improvements to recently migrated scripts (#23189)Sorikoff
Ref: 2cfaeb14004cfbb5500855472ad89ab9238df13d (cherry picked from commit 90d4254a875de7ea4e6aaed7a39effb6b2a73abf)
2021-12-02Scripts/Spells: Fixed a console error inspell_dru_lifebloomKeader
Closes #23192 (cherry picked from commit 961bc9d829e18004e3071837a67f5acdfdd7dd2c)
2021-12-02Core/conf: conf.dist typo & grammar corrections (#23190)Trond B. Krokli
- Typo and spelling corrections - Grammar corrections, English grammar - Minor adjustments in example code readability - Capitalization adjustments to keep consistency with existing idioms, phrases and concepts (cherry picked from commit f9b1e4a03259c39af0d24e63f877455944b8af2e)
2021-12-01Core/Calendar: Improve calendar timezone handlingjackpoz
Improve calendar timezone handling by at least creating events with the correct time if both client and server are in the same timezone. There is currently no information received from the client about in which timezone it is. (cherry picked from commit b33934f6ce9b0227597c712dd6a76b7ed49deea3)
2021-11-30Core/SmartScripts: Implement SMART_ACTION_PLAY_CINEMATICAokromes
By Malcrom (cherry picked from commit 63aa5d1e3559f580551544b71fb7dd63d6b54b60)
2021-11-30Core/Database: Delete gameobject_addon data when deleting a GameObject from ↵jackpoz
the database Close #23076 (cherry picked from commit f88a5b12bd7511331ea27975fe26bfc98d92d20d)
2021-11-30Spell/Script: Kill logs spam for spell_ioc_parachute_icKillyana
Closes #23163 (cherry picked from commit c318b3e16d482654112c528d100edddaf6d4e0fe)
2021-11-30Core/Movement: replace multiset::find with std::find in MotionMasterccrs
same reasoning as 11de6b5 Container's find uses the defined custom comparator (cherry picked from commit 6e011c974d55135f56df7802699c05fc95ee7873)
2021-11-30Core/Movement: implement and use new remove method in MotionMasterccrs
All erases within MotionMaster are now done by itr. Previous impl used value erase which uses the custom comparator which does not identify elements uniquely --> wrong values were deleted ref #23187#discussion_r275791179 (cherry picked from commit 11de6b5f866e087307a719b931be8c51b984c54e)
2021-11-30Scripts/Spells: Migrate Some Scripted Spells to Scripts (#23185)Sorikoff
* Migrate spells to scripts * Simplify code * I need to sleep * Update chapter1.cpp * Use actual damage * No need in null check here (cherry picked from commit 2cfaeb14004cfbb5500855472ad89ab9238df13d)
2021-11-30Core/Movement: Add time synchronisation (#18189)Chaouki Dhib
(cherry picked from commit 975f1e364a6a68be2beca261a64ea8aecc16f6f6)
2021-11-30Core/Social: Separated checks for friend and ignored limits (#23181)ForesterDev
(cherry picked from commit 2a6eef76e24bcc266050237df0bf296e4cce4bae)
2021-11-30Core/GameObjects: Defined more GameObjectFlags and GameObjectDynamicLowFlagsShauren
2021-11-29COre/Misc: GCC warning fixShauren
2021-11-28Warning fixes (log format in a809932f5017c98092a02694e86e276add03f8b9)Shauren
2021-11-28Core/Spells: Implemented spell effect 254 (SPELL_EFFECT_JUMP_CHARGE)Shauren
2021-11-27Core/Movement: Implement initializing parabolic splines using jump gravity ↵Shauren
instead of max parabolic height
2021-11-27Core/MMaps: Fix crash added in 386b5a6fd948b4866cbd9a8a9892e8777922e9c9jackpoz
(cherry picked from commit 17bb608a5e77345948a8c4f28d78e2cba5302505)
2021-11-27Core/MMaps: Simplify d182e5f7e73e614185f4470429467befd6e03981 and handle ↵jackpoz
PATHFIND_INCOMPLETE in ChaseMovementGenerator as "cannot reach the target" (cherry picked from commit 386b5a6fd948b4866cbd9a8a9892e8777922e9c9)
2021-11-27Core/MMaps: Fallback to shortcut for flying units if Detour returned an ↵jackpoz
incomplete path. Fallback to shortcut for flying units if Detour returned an incomplete path. This is needed when a flying unit should fly to the floor below to reach the target, but since Recastnavigation doesn't support "jumping down" the unit would not find a path to the target. (cherry picked from commit d182e5f7e73e614185f4470429467befd6e03981)
2021-11-27Core/Database: Close the MySQL connection only after getting the last error codeGiacomo Pozzoni
(cherry picked from commit 3230ca74d21517204bb785e9ec799d995295ad28)
2021-11-27Core/Creatures: Filter out trainer spells that belong to a skill that can ↵Jozef Dúc
never be learned by a player with given class and race combination (#23176) Closes #23172 (cherry picked from commit f221fcdd4b91e27c69a38dc665621797af0640c9)
2021-11-27Core support for breadcrumb quests (#23157)PolarCookie
* Breadcrumb quests support in core * To Winterspring! & Starfall * translating ZenoX92's list, part 1 * Carendin Summons is Blood Elf only * Breadcrumb to an exclusive group * translating ZenoX92's list, part 2 * class quests * breadcrumb trails * better prevquest check * less harsh error warnings * minor optimization * Rename 9999_99_99_99_world.sql to 2019_04_10_00_world.sql (cherry picked from commit 5ed77113b637c49e99a610b00f385c51da67c3bf)
2021-11-26Core/Spell: Move a log to categoryAokromes
(cherry picked from commit 1374658d727d37b34f60ce4891b5160bef5d28f8)
2021-11-26Core/Movement: Fix some undermap issues with random movement/fear/blink (#22937)Jeremy
* Core/Movement: - Only move to point if there is a path that is not a shortcut (which will make the unit move through terrain) - Added new function to check if there is a vmap floor without search distance - Units that can fly, are underground but far above the vmap floor will stay underground (bronze drakes in tanaris) - Don't remove PATHFIND_SHORTCUT from path type in some cases * Core/Object: Ignore UpdateAllowedPositionZ for flying units. - This will make flying units go through mountains instead of going to the top and back to the bottom to reach you. * Core/Object: Revert some changes and let MovePositionToFirstCollision deal with a position without ground * Missing groundZ change for objects on transport * use CanFly instead of IsFlying (cherry picked from commit 9fcbd8f15d249070aabc25d48df86681e8ec3d11)
2021-11-26Core: VehicleJoinEvent crash fix (#23136)PolarCookie
(cherry picked from commit 73e3fdc8b4545cca52b66032a5f2465183d14c71)
2021-11-26Core/Objects: use the actual collision height of players and creatures to ↵Ovah
get more accurate liquid status results (#23070) (cherry picked from commit b9e9ccf93c63c3b27d7a6f9eced0beb4e14af40e)
2021-11-26Core/GameEventMgr: Log error if loading GO/Creature into event that is part ↵r00ty-tc
of pool - Only warn, still load the GO/Creature - These should be added to game_event_pool by pool ID instead (cherry picked from commit 8bb88657f823b3e5446e250a48a2846abb10f023)
2021-11-26Core: Remove wrong emotes played in combatKillyana
Ref #23152 (cherry picked from commit c52eb49f71606b6b07b9edf279606713292ec92c)
2021-11-26Core/Scripts: Fix Blood summon position (#23088)Gustavo
* Core/Scripts: Fix Blood summon position Updates #13162 (cherry picked from commit cc3293c0023b36434747190103a1f0ffee0f8488)
2021-11-26Core/Misc: Warning fixes (/W4) (#23149)Gustavo
* Core/Misc: Warning fixes (/W4) (cherry picked from commit 50f122de778bca324d0f4c81f1e8eb30b90a7314)