diff options
author | Gultask <100873791+Gultask@users.noreply.github.com> | 2023-01-25 11:35:35 -0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-01-25 11:35:35 -0300 |
commit | fdfb866c54589ec5812e5df36b36b24c04eeeb0d (patch) | |
tree | 4c96467248d2584712368e432897e51140c78e83 /apps/compiler/includes/functions.sh | |
parent | 3202158af1e2875162eaeb828a5fd78e7702b091 (diff) |
fix(DB/Creature): Rework Old Tarren Mill in Old Hillsbrad Foothills (#14659)
<!-- First of all, THANK YOU for your contribution. -->
## Changes Proposed:
- Implement Tarren Mill Fishermen
- Remove wrong spawn point for Phil (should be one of the pentagram
children instead)
- Fix waypoints and add emotes for Jay Lemieux & Julie Honeywell
- Rebuild guard spawns, remove custom guards and custom waypoints
- Implement the Tarren Mill Horsehand (Bessy and Young Blanchy event)
- Corrects waypoints for Tarren Mill Peasants in the orchard.
- Fix equip template for Tarren Mill Peasant (18644)
- Adds spawns of Tarren Mill Horse and Tarren Mill Horsehand
- Corrects Young Blanchy position
- Fix unit_flags for Tarren Mill Horse and Tarren Mill Peasant (sniffed)
- Implement the Orchard events (Peasants will periodically gather apples
and drop off sacks of apples at a nearby cart)
## Issues Addressed:
<!-- If your fix has a relating issue, link it below -->
- Closes
## SOURCE:
<!-- If you can, include a source that can strengthen your claim -->
Retail sniffs mostly
Classic sniffs for Spell IDs
## Tests Performed:
<!-- Does it build without errors? Did you test in-game? What did you
test? On which OS did you test? Describe any other tests performed -->
- Tested ingame
-
## How to Test the Changes:
<!-- Describe in a detailed step-by-step order how to test the changes
-->
1. `.go c 83518`
2. observe all 👁️
## Known Issues and TODO List:
<!-- Is there anything else left to do after this PR? -->
- [ ] The Tarren Mill Horsehand phases through the wall due to his
waypoints. He does not pathfind properly to the next waypoint so he
phases instead. This is sniffed data and possibly a core issue.
- [ ] The spell cast by Tarren Mill Peasants is **not** sniffed.
<!-- If you intend to contribute repeatedly to our project, it is a good
idea to join our discord channel. We set ranks for our contributors and
give them access to special resources or knowledge:
https://discord.com/invite/DasJqPba)
Do not remove the instructions below about testing, they will help users
to test your PR -->
## How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as **[WAITING TO BE
TESTED]**.
You can help by testing PRs and writing your feedback here on the PR's
page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
**REMEMBER**: when testing a PR that changes something **generic** (i.e.
a part of code that handles more than one specific thing), the tester
should not only check that the PR does its job (e.g. fixing spell XXX)
but **especially** check that the PR does not cause any regression (i.e.
introducing new bugs).
**For example**: if a PR fixes spell X by changing a part of code that
handles spells X, Y, and Z, we should not only test X, but **we should
test Y and Z as well**.
Diffstat (limited to 'apps/compiler/includes/functions.sh')
0 files changed, 0 insertions, 0 deletions