diff options
| author | Francesco Borzì <borzifrancesco@gmail.com> | 2021-03-26 18:07:24 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-26 18:07:24 +0100 |
| commit | 7067696f83c6ccb8c4f9ecc316ccf9be70693c03 (patch) | |
| tree | 8e463fcaaebcb573fac22a657021a07e83b32bff /pull_request_template.md | |
| parent | b4242735749ca6ff4d7e370cc0d41105f5856f60 (diff) | |
docs: update PR template (#5015)
Diffstat (limited to 'pull_request_template.md')
| -rw-r--r-- | pull_request_template.md | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/pull_request_template.md b/pull_request_template.md index b9e8bfa793..2e3cc991f0 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -62,3 +62,7 @@ When a PR is ready to be tested, it will be marked as **[WAITING TO BE TESTED]** You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here: http://www.azerothcore.org/wiki/How-to-test-a-PR + +**REMEMBER**: when testing a PR that changes something **generic** (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but **especially** check that the PR does not cause any regression (i.e. introducing new bugs). + +**For example**: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but **we should test Y and Z as well**. |