diff options
author | Barbz <BarbzYHOOL@users.noreply.github.com> | 2018-07-09 16:46:32 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-07-09 16:46:32 +0200 |
commit | cc886b18a15d784c7db52ad995aabc09da391e02 (patch) | |
tree | 1acdcaed37c739aee2c60607a398258cd14031cc /pull_request_template.md | |
parent | 7a5ed0c5bbcb62e0f26e8b8718b28b0bef8488e1 (diff) |
Github: pull_request_template made easier to read
Deleted pointless comments and made it easier to read
Diffstat (limited to 'pull_request_template.md')
-rw-r--r-- | pull_request_template.md | 54 |
1 files changed, 22 insertions, 32 deletions
diff --git a/pull_request_template.md b/pull_request_template.md index 47097cf778..abe46d3840 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,62 +1,52 @@ <!-- First of all, THANK YOU for your contribution. -<!-- ---------------------------------------------- --> -<!-- Please fill this template unless your PR is very simple/straightforward. -<!-- Do not forget to have a look at our Pull Request tutorial: -<!-- https://github.com/azerothcore/azerothcore-wotlk/wiki/Contribute#how-to-create-a-pull-request -<!-- ---------------------------------------------- --> -<!-- If you intend to contribute more than once, you should really join us on our discord channel! -<!-- The link is on our site http://azerothcore.org/ or in the readme https://github.com/azerothcore/azerothcore-wotlk etc... -<!-- We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! --> + Please fill this template unless your PR is very simple/straightforward. + Do not forget to have a look at our Pull Request tutorial: https://github.com/azerothcore/azerothcore-wotlk/wiki/Contribute#how-to-create-a-pull-request +--> <!-- WRITE A RELEVANT TITLE --> -**Changes proposed:** +**CHANGES PROPOSED:** - - -**Issues addressed:** +**ISSUES ADDRESSED:** +<!-- If the issue doesn't exist, describe it and how to reproduce it, please. If the issue already exists, just paste the link to the issue you close, like this: Closes https://github.com/azerothcore/azerothcore-wotlk/issues/967 --> -<!-- Just paste the link to the issue you close, like this: -<!-- Closes https://github.com/azerothcore/azerothcore-wotlk/issues/967 --> Closes -**Tests performed:** +**TESTS PERFORMED:** +<!-- Does it build without errors? Did you test in-game? What did you test? Did you do all these tests on Linux, Mac or Windows? Other tests performed --> -<!-- Does it build without errors? -<!-- Did you test in-game? -<!-- What did you test? -<!-- Did you do all these tests on Linux, Mac or Windows? -<!-- Other tests performed --> -**How to test the changes:** +**HOW TO TEST THE CHANGES:** +<!-- We need to confirm the changes first, so try to make the work easy for testers, please: + - Which commands to use? Which NPC to teleport to? + - Do we need to enable debug flags on Cmake? + - Do we need to look at the console? etc... + - Other steps +--> -<!-- Describe how to test the fix after applying the Pull Request. If needed describe how to test the issue before applying the <!-- Pull Request (for example, if the issue has not been reported before). -<!-- - Which commands to use? Which NPC to teleport to? -<!-- - Do we need to have debug flags on Cmake? -<!-- - Do we need to look at the console? etc... -<!-- - We need to confirm the changes first, so try to make the work easy for testers, please. --> -**Known issues and TODO list:** - +**KNOWN ISSUES AND TODO LIST:** <!-- This is a TODO list with checkboxes to tick --> + - [ ] - [ ] -<!-- OPTIONAL - If your Pull Request is not targeting the Master branch then remove the comments and specify the Target Branch -<!-- **Target branch(es):** ----- 1.x/2.x etc. --> +**Target branch(es):** +Master -<!-- NOTE: -<!-- ----- -<!-- You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). --> +<!-- NOTE: You no longer need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). --> +<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel! + The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! --> |