diff options
| author | Francesco Borzì <borzifrancesco@gmail.com> | 2019-08-03 08:26:42 +0200 |
|---|---|---|
| committer | Stoabrogga <38475780+Stoabrogga@users.noreply.github.com> | 2019-08-03 08:26:42 +0200 |
| commit | d45cd730b213a9121e5dab6d0a8b3ad9bc75c037 (patch) | |
| tree | 5d2b0821224a8c6efa2a2ae662e7f251869830b5 /pull_request_template.md | |
| parent | a35725712e0443d8002afa59f74c1f4ae4177c43 (diff) | |
chore: improved pull_request_template.md (#2166)
Diffstat (limited to 'pull_request_template.md')
| -rw-r--r-- | pull_request_template.md | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/pull_request_template.md b/pull_request_template.md index e5d9bd7e99..6a87d90b33 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -13,7 +13,7 @@ - -###### ISSUES ADDRESSED: +##### ISSUES ADDRESSED: <!-- If the issue doesn't exist, describe it and how to reproduce it, please. If the issue already exists, just paste the link to the issue you close, like this: Closes https://github.com/azerothcore/azerothcore-wotlk/issues/967 --> Closes @@ -30,6 +30,13 @@ Closes - Do we need to enable debug flags on Cmake? - Do we need to look at the console? etc... - Other steps + +***** IMPORTANT: ***** +The people who are going to test PRs are not necessarily coders, +so they might have no idea about what the code changes can affect. +For this reason the developer should at least explain what aspects +of the game can be affected by the changes, especially when doing +C++ changes on generic parts of the code. --> @@ -52,9 +59,9 @@ Master The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! --> - <!-- Do not remove the instructions below about testing, they will help users to test your PR --> +<!-- Do not remove the instructions below about testing, they will help users to test your PR --> - ## How to test AzerothCore PRs +## How to test AzerothCore PRs When a PR is ready to be tested, it will be marked as **[WAITING TO BE TESTED]**. |