Core/Spell: Fixed some negative spells showing as positive

Closes #22840
Revert 9ecce33192 and 7611242530
Update #22757

(cherry picked from commit a0de602d38)
This commit is contained in:
Keader
2019-01-05 11:26:29 -03:00
committed by Shauren
parent 5cb05d1a40
commit 33a2d627dd

View File

@@ -4358,7 +4358,6 @@ bool _isPositiveEffectImpl(SpellInfo const* spellInfo, SpellEffectInfo const& ef
case 64412: // Phase Punch, Algalon the Observer, Ulduar
case 72410: // Rune of Blood, Saurfang, Icecrown Citadel
case 71204: // Touch of Insignificance, Lady Deathwhisper, Icecrown Citadel
case 70853: // Malleable Goo, Professor Putricide, Icecrown Citadel
return false;
case 24732: // Bat Costume
case 30877: // Tag Murloc
@@ -4565,7 +4564,8 @@ bool _isPositiveEffectImpl(SpellInfo const* spellInfo, SpellEffectInfo const& ef
case SPELL_AURA_MOD_ATTACK_POWER:
case SPELL_AURA_MOD_RANGED_ATTACK_POWER:
case SPELL_AURA_MOD_DAMAGE_PERCENT_DONE:
if (!_isPositiveTarget(effect) && bp < 0)
case SPELL_AURA_MOD_SPEED_SLOW_ALL:
if (!_isPositiveTarget(effect) || bp < 0)
return false;
break;
case SPELL_AURA_MOD_DAMAGE_TAKEN: // dependent from basepoint sign (positive -> negative)