Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.
(cherry picked from commit 2170541a51)
Code style follow-up, I blame Notepad++.
(cherry picked from commit 7860da0de6)
(cherry picked from commit 6d00d3f283)
Merge remote-tracking branch 'Treeston/3.3.5-splinechains' into 3.3.5 (PR #17946)
(cherry picked from commit 20f483967f)
Core/Movement: Add a convenience default ctor to SplineChainResumeInfo, and fix PCH build in some configurations (zzz why do we even keep Appveyor and Travis around).
(cherry picked from commit 4fa646c0b2)
PCH build fix. Again.
(( Alright, you made me waste 20 minutes of my life on a full nonPCH rebuild of the core now. ))
(( I hope you're happy. ))
(cherry picked from commit 4a1a460241)
* Appeasing the Great Rainstone/Gods like Shiny Things update so sai actually works on sholazar guardians so sai runs on charmed creature, also rescript glinting dirt as previous had stopped working
* Teleport This! Charmed flags are needed here so that credit spell is cast when payer uses controlled npc to blow up teleporter.
* Updates to blueleaf tubers as previous fix stopped working due to negative respawn time on spell focus objects
(cherry picked from commit ebc0190d3b)
This is what the script changes should have been in PR #17746
(also updates issue #14719 with a correct solution).
- remove OnGossipHello() to use DB conditions
- replace OnGossipSelect() with sGossipSelect()
- focus script on the confirming gossip option
- let the other gossip menus be handled in DB
(cherry picked from commit a475033c76)
- Fix next quest for The Taunka and the Tauren.
- Fix requirements for Patience is a Virtue that We Don't Need, Taken by the Scourge and the three versions of The Defense of Warsong Hold.
(cherry picked from commit fd6cf2bca6)
- To Dragon's Fall requires completion of Wanted: Magister Keldonus, Wanted: Gigantaur and Wanted: Dreadtalon.
- Black Blood of Yogg-Saron, Marked for Death: High Cultist Zangus and Containing the Rot require completion of Agmar's Hammer.
- Strengthen the Ancients requires completion of The Focus on the Beach.
- Message from the West requires completion of Hellscream's Champion.
- Only one between A Tauren Among Taunka and The Taunka and the Tauren can be completed.
(cherry picked from commit b90afa8857)
- Victory Nears... requires Agmar's Hammer.
- Strength of Icemist requires From the Depths of Azjol-Nerub.
- Only one between To Venomspite! and Imbeciles Abound! can be completed.
(cherry picked from commit e07f68a032)
- Add missing texts and re-number the group ids.
- Do not allow players to attack the creatures spawned in the end event.
- A Score to Settle requires completion of this quest.
(cherry picked from commit c1129af75b)
The timed action lists for this script now need event flags so they run while charmed and so that Karsius actually gets summoned.
(cherry picked from commit 79578eab40)
Rename 2016_09_14_03_world.sql to 2016_09_14_03_world.sql
(cherry picked from commit 6913286cb9)
SMART_TARGET_INVOKER_PARTY or SMART_ACTION_CALL_GROUPEVENTHAPPENS should instead be used to achieve this functionality.
(cherry picked from commit 6586885bca)
Use ConditionTypeOrReference 45 (PetType in PetDefines.h):
- Show gossip menu 4783 option id 1 if Pet Type is hunter pet
( follow-up to PR #17746 / commit 03bafe3 )
(cherry picked from commit 9d7cd93e0d)
