Commit Graph

12804 Commits

Author SHA1 Message Date
Gustavo
044110d423 Core/Entities: add extra use of UPDATETYPE_CREATE_OBJECT2 (#20955)
(cherry picked from commit 51c4196acf)
2021-03-15 20:17:31 +01:00
ariel-
794a3e4388 Core/Auras: fixed off by one error in counting SPELL_ATTR5_START_PERIODIC_AT_APPLY ticks
- Made SpellInfo::GetMaxTicks and AuraEffect::GetTotalTicks return the same number without mods (dumped arbitrary default return value of 6 and arbitrary 30 sec limit)
- They should be streamlined whenever SPELL_AURA_48 is implemented

(cherry picked from commit 7dff0e3246)
2021-03-15 20:17:31 +01:00
ariel-
44c8ccadd7 Core/Auras: periodics refactor part 5: ported periodic trigger spell auras to scripts
(cherry picked from commit a36e804ae4)
2021-03-15 20:17:31 +01:00
ariel-
d9b145615d Core/Auras: periodics refactor part 4: ported periodic dummy auras to scripts
(cherry picked from commit 193bd3b452)
2021-03-15 20:17:31 +01:00
ariel-
97e869e8b3 Core/Auras: periodics refactor part 3: move more switch hacks to scripts
- Incidentally fixed some spells which were supposed to be removed by proc instead of healing to full

(cherry picked from commit 16e20711d2)
2021-03-15 20:17:31 +01:00
ariel-
fd786c03a3 Core/Auras: periodics refactor part 2: Move UpdatePeriodic to AuraScripts
(cherry picked from commit 0510bf7afe)
2021-03-15 20:17:31 +01:00
ariel-
5f9e0d92d5 Core/Auras: periodics refactor part 1:
- Don't skip ticks if diff is greater than amplitude
- Fixed spells without ampltude in DBC

(cherry picked from commit 5d91beb1db)
2021-03-15 20:17:31 +01:00
Golrag
fe362cf2c9 Core/Entities: Some changes to LoS z checking & MotionMaster::MoveJumpTo (PR #20970)
- Use Midsection height for LoS checking.
- Changed MotionMaster::MoveJumpTo to use correct z. This change also makes sure the _owner will jump towards the given angle. Instead of jumping to a unintended angle if the first one is not in LoS.

(cherry picked from commit 95456ab5d8)
2021-03-15 20:17:31 +01:00
Shauren
16135b5096 Core/Spells: Changed channel triggered spells to inherit positive/negative status from main spells
Closes #18259
Closes #21041

(cherry picked from commit 6122006b0c)
2021-03-15 20:17:31 +01:00
ariel-
88ae43fa51 Core/Misc: minor typo and codestyle fixes
- Replace NULL uses in new code with nullptr
- Fix wrong (accumulated) load time log when loading calendar invites
- Make Creature::CanRegenerateHealth const as its just a getter
- Mark OnlyOnceAreaTriggerScript::OnTrigger as final in case someone wants to override that (you are supposed to use protected _OnTrigger hook)

(cherry picked from commit 78a1c687a2)
2021-03-15 20:17:31 +01:00
Meji
72f99531b7 Core/Players: Update the location of the cinematic camera only if there is an active cinematic (#26215) 2021-03-15 00:06:26 +01:00
Shauren
41c342113f Fix build 2021-03-14 15:41:02 +01:00
Jeremy
2d84912ce9 Core/GameObjects: Add GameObjectPlaySpellVisual (#26044) 2021-03-14 15:40:42 +01:00
Shauren
08e017b351 Core/AdventureMap: Handle CMSG_ADVENTURE_MAP_START_QUEST 2021-03-14 14:46:07 +01:00
Shauren
da77b300f4 Core/Spells: Small refactor to ServersideSpellName to make private parts actually private 2021-03-14 14:45:01 +01:00
Shauren
56438d0cdd Core/Players: Remove error log from Player::GetQuestObjectiveData as that function is now used with quest objectives retrieved by their id, not from quest 2021-03-14 14:44:16 +01:00
Shauren
d0246e5835 Core/AdventureJournal: Check if player can access adventure journal with ChrClassUIDisplay.db2 2021-03-14 13:07:29 +01:00
Shauren
c15cf8b424 Core/AdventureJournal: Fix broken hotfix database structure from 3addbe7dd4 2021-03-14 01:05:32 +01:00
Osleyder85
3addbe7dd4 Core/AdventureJournal: Handle CMSG_ADVENTURE_JOURNAL_OPEN_QUEST and CMSG_ADVENTURE_JOURNAL_UPDATE_SUGGESTIONS
Merges #26000
2021-03-14 00:21:31 +01:00
Shauren
7cc70e29ae Core/Criteria: Implemented CRITERIA_ADDITIONAL_CONDITION_COMPLETED_QUEST_OBJECTIVE 2021-03-13 22:32:48 +01:00
Shauren
deed58f080 Core/Spells: Check if serverside spells don't overwrite db2 spells 2021-03-12 22:25:47 +01:00
Shauren
2bd70b41eb Core/Spells: Restore serverside spells fuinctionality 2021-03-12 21:59:10 +01:00
Shauren
efdca47aff Core/Auras: Remove m_effIndex member of AuraEffect and always take it from SpellEffectInfo 2021-03-11 10:32:03 +01:00
Ovah
0aa3a0b0b9 fixed build 2021-03-09 17:06:34 +01:00
Ovah
e77100c923 Core/PacketIO: corrected setting the NowDead field in SMSG_ATTACK_STOP
This fixes a weird facing behavior for creatures which caused them to face to their spawn position when dying instead of facing their current victim's orientation
2021-03-09 17:02:23 +01:00
Shauren
c1a5672944 Scripts/Spells: Minor travel form corrections
* Added missing visuals when changing forms
* Prevent entering flight forms when in combat
2021-03-08 23:58:40 +01:00
Shauren
39652f9445 Core/Conversations: Fill more updatefields with correct data 2021-03-08 20:30:32 +01:00
Shauren
d80593061f Core/PacketIO: Fix structure for SelectedAzeriteEssences and name unknown conversation fields 2021-03-08 00:11:29 +01:00
Matan Shukry
c019d4f10c Core/SAI: Don't require BaseObject when creating conversation from smart scripts (#26209) 2021-03-07 11:17:04 +01:00
Shauren
b4aa698acb Core/Auras: Convert most rules from Aura::CanBeSaved to a custom spell attribute 2021-03-06 23:47:30 +01:00
Matan Shukry
16f95f9d32 Core/Auras: Don't save druid various flight forms to db (#26206) 2021-03-06 23:09:47 +01:00
Shauren
af1b3301c9 Core/Maps: Remove unused code 2021-03-06 22:17:12 +01:00
Matan Shukry
1b4c4d2164 Core/SAI: Implement quest source for SAI (#26170) 2021-03-06 14:20:39 +01:00
Traesh
56e9560661 Core/Spells Handle auras 328 & 396 (SPELL_AURA_TRIGGER_SPELL_ON_POWER_*) 2021-03-05 23:25:51 +01:00
Robingad
1d7590072c Core/Spells: Take SPELLMOD_CRIT_DAMAGE_BONUS into account also for healing spells (#26151) 2021-03-05 22:08:32 +01:00
Matan Shukry
49b47047b8 Core/Spells: Implemented SPELL_AURA_ALLOW_TALENT_SWAPPING (#26205) 2021-03-05 21:53:42 +01:00
Matan Shukry
818c19ec4b Core/Movement: Add trace log message with packet content to movement opcode handler 2021-03-05 00:28:07 +01:00
Matan Shukry
931a3871f8 Core/Movement: Don't rely on client for water state detection 2021-03-05 00:28:07 +01:00
Matan Shukry
a37eb18008 Core/Movement: Allow entering water from flying mounts and druid flight form 2021-03-05 00:28:07 +01:00
Matan Shukry
1086007f98 Scripts/Spells: Fixed various paladin spell scripts and removed outdated ones 2021-03-04 22:46:44 +01:00
Shauren
ea63cd882c Core/Spells: Moved power cost RequiredAuraSpellID condition checking to make sure all overloads of SpellInfo::CalcPowerCost take it into account 2021-03-04 22:46:44 +01:00
Shauren
0960308cfc Core/Spells: Add Spell::HasPowerTypeCost to check which power types a spell uses 2021-03-04 22:46:44 +01:00
Shauren
36496c7172 Core/PacketIO: Fix suppressing building SMSG_UPDATE_OBJECT packets 2021-03-04 20:47:54 +01:00
Shauren
34768c5b44 Core/Spells: Implemented SPELL_EFFECT_PLAY_SCENE_SCRIPT_PACKAGE and SPELL_EFFECT_CREATE_PRIVATE_CONVERSATION 2021-03-04 20:31:08 +01:00
Shauren
a05fc3ded5 Core/Spells: Updated spell effect type definitions to match latest client version 2021-03-04 20:30:50 +01:00
jackpoz
55931b0d92 Core/SmartScripts: Code cleanup
(cherry picked from commit f555a67bf8)
2021-03-04 18:17:08 +01:00
Killyana
77ee6dca45 Core/SAI: Add event_parm5 "player only" for EVENT_OOC_LOS and EVENT_IC_LOS
Closes #21497

(cherry picked from commit 5ad38c31b0)
2021-03-04 18:15:55 +01:00
MaxtorCoder
c0f5f7d4ef Core/AuctionHouse: Fix overflow in item ordering. (#26196) 2021-03-03 15:15:08 +01:00
Shauren
0e3666bfbc Core/Spells: Fixed calculation spell optional power cost when any modifiers are applied 2021-03-02 23:14:50 +01:00
Shauren
624881bef5 Core/Spells: Refactor Player::ApplySpellMod to take SpellInfo argument instead of just spell id 2021-03-02 21:32:48 +01:00