Commit Graph

1057 Commits

Author SHA1 Message Date
Shocker
08be716ef8 Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_* 2012-02-03 19:02:17 +02:00
Subv2112
9b524b43fa Core/Spells: Spells with SPELL_AURA_PERIODIC_MANA_LEECH should skip unit target checking if the Targets are area targets, they are filled/validated later
Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-31 20:27:22 -05:00
Souler
75992143c1 Scripts/Spells: Fix Argent Tournament mount spells:
* Break-Shield
 * Charge
 * Defend (visual)
 * Mounted duel
 * Faction Pennants when riding argent tournament mounts
Closes #4917.
2012-01-30 00:21:42 +01:00
Subv2112
3d4f55723c Core/SAI: Linked events should be executed after the event that linked them is executed.
Core/SAI: Allow SMART_EVENT_GO_STATE_CHANGED to use ActionInvoker target

Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-22 20:36:01 -05:00
Vlad
0f383e9cdd Core/Movement: properly set mover for possess/vehicles 2012-01-20 05:11:52 +03:00
QAston
b754f7c91d Core/Auras: Add some documentation to new proc system code to avoid confusion. 2012-01-17 21:35:27 +01:00
Machiavelli
dbbac0bdaa Core/Movement: Implement spline movement subsystem.
Spline movement controls movements of server-side controlled units (monster movement, taxi movement, etc).
Proper implementation of effects such as charge, jump, cyclic movement will rely on it.
However, need improve our states system before.

Technical changes:

* Added linear, catmullrom and bezier3 splines which based on client's algorthims. They can be reused for proper transport position interpolation.
* Precission increased. There are no more position desync issues since client's position calculation formulas used.
* Now possible to move by paths with multiple points, send whole path to client.

--
Original author of research and implementation: SilverIce. Massive kudos.
Original port for Trinity (ref #4629) Chaplain and Venugh
With the following incremental fixes during my review:

- Restore flightmaster end grid pre-loading
- Fix uninitialized Creature::m_path_id
- Add missing trinity_string entries for .movegens command
- Fix a bug in WaypointMovementGenerator that would trigger unexpected pausing at waypoints for various amounts of time

Known issues:
- Errors like WaypointMovementGenerator::LoadPath creature XXX (Entry: YYYYY GUID: ZZZZZZ) doesn't have waypoint path id: 0.
This is caused by bad DB data. This commit didn't "break" it.

Do not forget to re-run CMake before compiling.
2012-01-14 15:36:07 +01:00
QAston
798677ca54 Merge pull request #4800 from Chaplain/cleanup
Core/Spells: Fix issue in CAST_FLAG_ADJUST_MISSILE handling. Thx rsa (R2) for pointing.
2012-01-14 04:43:08 -08:00
Chaplain
a535e451a8 Core/Spells: Fix issue in CAST_FLAG_ADJUST_MISSILE handling. Thx rsa (R2) for pointing. 2012-01-13 19:18:13 +03:00
Subv2112
f7276a95de Scripts/Achievements: Fixed achievement Shocking! on 10-man and 25-man
closes #4751

Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-09 20:36:56 -05:00
Emo Norfik
6cb4950489 Scripts/Utgarde Pinnacle:
- Re-write Svala Sorrowgrave
- Scripted achievement The Incredible Hulk.

This script was writen basing on work and data:
- Original TC script.
- Albis fix for Arthas sounds and texts https://github.com/TrinityCore/TrinityCore/issues/4002 .
- Ric event start fix.
- Recorded encounters uploaded on YouTube.
- Data found on ScriptDev2 forums.
- Iov's custom SD2 repo and Svalas's script https://github.com/Iov/scriptdev2 .
Also thx to:
- ZxBiohazardZx for pointing how to fix looting problem when boss is killed when flying.
- Aokromes for confirmig how many times event "Ritual of the Sword" is performed.

- Mini event with Arthas.
- Call Flames: timers of cast and time between "Ball of Flame" (48246) can be wrong (based on videos).
- Ritual of the Sword works  and is performed once at 50% hp but:
  a) Still need retail data for teleport position of Svala floating above player.
  b) Need fully fixed spell Ritual of the Sword (48276), the triggering of spell Ritual Strike - Trigger Missile (48331) part was hardcoded.
- Spell Paralyze (48278) used by Ritual Channeler: fixed stacking and selection to ritual player only.
- Achievement "The Incredible Hulk": works but often Scourge Hulk don't get initial dmg from spell Ritual Strike (spell 48277 Effect #1 Value: 6650 to 7350).
- Looting problems when Svala was killed in air (require vmaps and option "vmap.enableHeight = 1" enabled in "worldserver.conf").
- Moved script_texts to creature_text.

It require option "vmap.enableHeight = 1" to work properly.
2012-01-08 23:07:31 +00:00
Chaplain
67808ba453 Core/Spells: Fix CAST_FLAG_UNKNOWN_18.
*rename CAST_FLAG_UNKNOWN_18 -> CAST_FLAG_ADJUST_MISSILE
*implement handling in Spell::SendSpellGo()
2012-01-08 18:50:25 +03:00
Kaelima
e457649170 Merge pull request #4714 from elecyb/mover
Core-Vehicles: Change player mover when add/remove passenger (thanks Sub...
2012-01-08 06:41:02 -08:00
elecyb
fc4b033715 Core-Vehicles: Change player mover when add/remove passenger (thanks Subv)
Core-Misc: Restore correct mover for victim of possesion spell.

Closes #4704, #4707
2012-01-08 03:56:33 -03:00
Machiavelli
1dc6f6a2da Merge pull request #4646 from elecyb/crash1
Core/PacketIO: Fix crash and exploit caused when client sends tampered m...
2012-01-07 03:58:42 -08:00
Kaelima
a79ea3dcdf Merge pull request #4672 from Subv/fix004
Fixed gossip menu displaying for gameobjects with type GAMEOBJECT_TYPE_QUESTGIVER
2012-01-06 06:37:20 -08:00
Shocker
e0bafc73f8 Merge pull request #4649 from Souler/fix_simon_game
Scripts/Quest: An Apexis Relic and The Relic's Emanation and Guardian of the Monument
2012-01-05 19:14:23 -08:00
Subv2112
d3b1c51b6e Core/Gossips: Fixed gossip menu displaying for gameobjects with type GAMEOBJECT_TYPE_QUESTGIVER, closes #4488
Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-05 21:41:17 -05:00
Souler
2d8a6fdf15 Scripts/Quests: An Apexis Relic, The Relic's Emanation and Guardian of the Monument. 2012-01-06 01:19:07 +01:00
elecyb
7d7bb8363d Core/PacketIO: Fix crash and exploit caused when client sends tampered mover guids
Closes: #4056
2012-01-05 18:34:56 -03:00
Shocker
2fac227480 Merge pull request #4405 from Warpten/feral
Core/Spells: Fix Druid's T10 Feral 4P Bonus
2012-01-04 13:50:17 -08:00
Shocker
08bcbc89b0 Merge pull request #4229 from devilcoredev/fix_002
Core/Spells: Fix the spell immunity system to be effect-dependent
2012-01-04 13:41:51 -08:00
Shocker
00e1de4c0a Merge pull request #3478 from Havenard/fix0011
Core/Spells: Fix Divine Storm
2012-01-04 13:35:29 -08:00
kandera
34c437e973 [Core/Spells] Fix Blood Tap (finally fixes full spell)
ignore removal of aura provided by Souler thanks!
2012-01-04 11:50:31 -05:00
zwerg
5884f4be31 Core/Spells: Add barfing to Spell::EffectInebriate.
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2012-01-03 13:15:33 +01:00
kiper
8299627ed9 Update headers for 2012. HAPPY NEW YEAR!!! 2012-01-01 00:32:13 +01:00
QAston
afc18461d7 Core/SpellScripts: Add BeforeCast, OnCast and AfterCast hooks to SpellScripts. 2011-12-31 13:11:12 +01:00
Shocker
f283a7b116 Merge pull request #4475 from Svannon/fix-fishingcone
Core/Fishing: Reduce the fishing cast cone to 35 degrees from each side of the facing instead of 70. Make the overall cone 70 degrees instead of 140
2011-12-25 12:16:10 -08:00
Nay
0d98ecc6c1 Merge pull request #4463 from Warpten/stings
Core/Spells: Fixed Improved Stings Rank 2 Dispel resist chance
2011-12-24 15:09:52 -08:00
Svannon
3405e0811d [Fishing] Reduce the Fishing cast cone to 35 degrees from each side of the facing instead of 70. Make the overall cone 70 degrees instead of 140. 2011-12-24 12:41:22 -07:00
QAston
15bd8f3cd5 Core/Spells: Fix logic in AnyDeadUnitSpellTargetInRangeCheck - spells using this should now correctly check target requirements. This is an alternative fix to #4112. 2011-12-24 08:40:30 +01:00
Kapoeira
c89c007f9f Core/Spells: Fixed Improved Stings Rank 2 Dispel resist chance (crazy targeting typo) 2011-12-23 19:49:59 -05:00
QAston
eecc4b58a7 Core/Spells: Use better check for target type in Spell::EffectSendEvent - SpellEffect::GetProvidedTargetMask() is much more accurate than hardcoded dbc index. 2011-12-23 23:52:22 +01:00
kaelima
398299084e Corrected some logic in my recent commits.
- ff2dbfc381 thanks LihO
- 6ccf95af4c thanks frostmourne
2011-12-22 18:48:06 +01:00
kaelima
ff2dbfc381 Core/Spells: Fix two signed / unsigned warnings from f8a13b401d 2011-12-22 13:22:18 +01:00
kaelima
f8a13b401d Core/Spells:
- Fix channeling spells with infinite duration (-1)
- Allowed SPELL_FAILED_EQUIPPED_ITEM_CLASS_MAINHAND and SPELL_FAILED_EQUIPPED_ITEM_CLASS_OFFHAND in SendCastResult (more reasons todo)
2011-12-22 00:38:01 +01:00
kaelima
4b0acb7432 Core/Spells: Force Invisibility (mage) to leave combat. 2011-12-21 02:16:06 +01:00
kaelima
2f2b84f6e5 Core/Spells: Fix some possible crashes in HandleAuraDummy, caster can be null for auras. 2011-12-21 02:12:46 +01:00
megamage
8cf2062c1f Update grid system. Try to fix some crashes and transport passengers (now they are despawned after a while). 2011-12-20 17:07:09 -05:00
Kapoeira
a3e8ca30b7 Core/Spells: Fix Druid's T10 Feral 4P Bonus. 2011-12-19 23:29:04 -05:00
Machiavelli
6c03bf9535 Core/Misc: Some random meaningless Engrish to English conversion in a method name because Discovered is too lazy to do it himself. 2011-12-19 22:06:29 +01:00
nelegalno
133c3304d8 DB/Quest: Fix quest The Black Knight's Orders
Closes #1832
Closes #3206
Closes #1299
Closes #1700
Closes #4347
2011-12-18 23:44:15 +00:00
Shocker
d1bb5b21af Merge pull request #4356 from kandera/fix_TotT
Core/Spells: Fix correct targeting for Tricks of the Trade
2011-12-16 10:38:33 -08:00
kandera
c961d3fdb5 Core/Spells: Fix correct targeting for Tricks of the Trade 2011-12-16 11:56:02 -05:00
kaelima
d10b0b74bd Fix code style and compile from 7e1c556536 2011-12-16 17:19:05 +01:00
Kaelima
970878f677 Merge pull request #4355 from kandera/fix_master_poisoner
Core/Spells: Envenom (Fix buff duration from master poisoner. aura was b...
2011-12-16 08:16:40 -08:00
kandera
7e1c556536 Core/Spells: Envenom (Fix buff duration from master poisoner. aura was being considered negative due to the damage effect. aura should be considered positive) 2011-12-16 11:04:52 -05:00
Machiavelli
7e94cae867 Merge pull request #4260 from wilds/fix_charge
Core/Spells: fix charge and chargedest effect through textures
2011-12-16 04:10:24 -08:00
kaelima
929ad95525 Core/Spells: Fixed Envenom damage
- The players AP should stack with combo points, not deadly poison stack.
+ some cleanup
Thanks @Cepox (and some others at google code issue tracker)

Closes #2929
2011-12-16 08:15:55 +01:00
Alexander
7f114b8ab7 Core/Spells: Fix second part of talent Nurturing Instinct 2011-12-16 13:44:40 +07:00