Commit Graph

14125 Commits

Author SHA1 Message Date
Treeston
0b722e23cf Entities/Unit: fix an unrelated check from doing nothing because somebody didn't understand how type-casting works 2019-08-01 01:27:10 +02:00
Treeston
a8b1b9a3c6 Entities/Unit: Add a missing underflow check to prevent really really low damage from underflowing when paired with flat damage modifiers. Closes #23655. 2019-08-01 01:27:10 +02:00
Shauren
6f7ab81725 Core/AuctionHouse: Fixed auction deposit calculation
Closes #23656
2019-08-01 00:17:06 +02:00
jackpoz
d9ae19d974 Core/GameEvent: Fix OnGameEvent() hook not being called on Creature/GameObject spawned by the event itself
Hook broken since it was added in 1b2c413933
2019-07-31 21:09:35 +02:00
Shauren
713dd276a7 Core/PacketIO: Fixed structure of SMSG_AUCTION_COMMAND_RESULT 2019-07-31 20:33:47 +02:00
Giacomo Pozzoni
c3619f42a5 Core/PetAI: Change an assert to a TC_LOG_ERROR 2019-07-31 16:15:01 +02:00
Treeston
7fa990edc6 Scripts/ICC: Prevent Professor Putricide from displaying weird behavior during the Rotface/Festergut encounters as a result of his boss boundary 2019-07-31 16:02:29 +02:00
ForesterDev
1506af08ad Core/RBAC: Fix changing security level (#23662)
(cherry picked from commit 0bae7d6918)
2019-07-31 14:19:10 +02:00
Treeston
9c603ea87f Core/Combat: Properly unset engagement flag on death. 2019-07-31 13:17:32 +02:00
Treeston
5378fc4500 Core/Misc: Add even more RBAC/Language values I need for #23633. 2019-07-31 03:20:12 +02:00
Treeston
cb690fc705 Core/Misc: Add RBAC/Language values I need for #23633. 2019-07-31 00:16:00 +02:00
Giacomo Pozzoni
22f258edcc Core/SAI: Attempt to fix a crash 2019-07-30 16:33:24 +02:00
Treeston
b2b7ae8898 Contrib/Misc: There, build fix. 19d71fb follow-up. 2019-07-30 12:04:26 +02:00
Treeston
19d71fb206 Contrib/Misc: Allow enumutils_describe.py to better deal with commented-out enum lines 2019-07-30 11:42:08 +02:00
Treeston
00b10c6b34 missing include e813200 follow-up 2019-07-29 21:47:12 +02:00
Treeston
e813200e5e Core/Misc: Kick a Totem error log upstairs one stack frame to give it access to various debug info and make Aokromes happy. 2019-07-29 21:37:15 +02:00
Giacomo Pozzoni
30a4aca266 Scripts/Blood Furnace: Fix infinite loop in Broggok encounter
Fix infinite loop in Broggok encounter caused by https://github.com/TrinityCore/TrinityCore/pull/23300
2019-07-29 08:22:58 +02:00
Treeston
163f44c1b0 Core/AI: No longer do strange things when told to enter evade mode while there's no need to do so, typically by terrible legacy code. 2019-07-29 00:14:10 +02:00
Treeston
55ec3bd73f Core/Threat: Properly update offline states even if all threat references are offline. Closes #23639. 2019-07-28 22:24:34 +02:00
Treeston
c3dd67dfbb Core/AI: PetAI now properly signals engagement state. Closes #23640. 2019-07-28 22:05:50 +02:00
jackpoz
9b292f4369 Core/Spells: Fix infinite loop
Fix an infinite loop caused by a mix of item 25498 and liquid damage
2019-07-28 17:13:48 +02:00
Shauren
73c1d666fa Core/Entities: Fixed crash happening when deleting a creature/gameobject on respawn timer from db
Closes #23590
2019-07-26 19:55:02 +02:00
Wyrserth
2cb1e7b18d Script/CullingOfStratholme: add out-of-combat texts to Postmaster Malown and fix Arthas' attack animation when he kills the two civilians for the RP event. 2019-07-25 16:21:48 +02:00
Gildor
75a5192c31 Spells/Priest: Fix Power Infusion, shouldn't stack with Arcane Power (Mage) (#23619)
* Spells/Priest: Fix Power Infusion, shouldn't stack with Arcane Power (Mage)

* delete unnecessary comments

* make @Aokromes happy ;)

* update group_id

* Rename 9999_99_99_99_world_335.sql to 2019_07_25_00_world_335.sql
2019-07-25 14:44:56 +02:00
Gildor
6d2cd7f687 Core/Arenas: Remove doors in RL, NA and BE when arena has begun (#23606) 2019-07-25 12:55:42 +02:00
ForesterDev
0c317498a5 Scripts/Defines: cleanup some magic numbers in factions (#23631) 2019-07-25 12:54:49 +02:00
ForesterDev
b9756de7e5 Core/PacketIO: Updated SMSG_OVERRIDE_LIGHT (#23635)
* Core/PacketIO: Updated SMSG_OVERRIDE_LIGHT

(cherry picked from commit 4c94108ba9)

# Conflicts:
#	src/server/game/Maps/Map.cpp
#	src/server/game/Server/Packets/MiscPackets.cpp
#	src/server/game/Server/Packets/MiscPackets.h
#	src/server/game/Server/Protocol/Opcodes.cpp
2019-07-25 11:08:31 +02:00
ForesterDev
adbb8da025 Core/PacketIO: updated totem packets (#23634)
(cherry picked from commit 5c813f6f02)

# Conflicts:
#	src/server/game/Entities/Totem/Totem.cpp
#	src/server/game/Handlers/SpellHandler.cpp
#	src/server/game/Server/Protocol/Opcodes.cpp
#	src/server/game/Server/WorldSession.h
2019-07-25 10:32:31 +02:00
ForesterDev
915f8a9d2c Core/Totems: update select display for shaman totems (#23583)
(cherry picked from commit 8ca6a20e73)

# Conflicts:
#	src/server/game/Entities/Totem/Totem.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Entities/Unit/Unit.h
#	src/server/game/Spells/SpellMgr.cpp
#	src/server/game/Spells/SpellMgr.h
#	src/server/game/World/World.cpp
2019-07-24 23:53:31 +02:00
Wyrserth
e2e37ec839 Core/Creature: fix mistake in Creature::GetAttackDistance().
Thanks Azelen for the heads-up!
2019-07-24 20:13:13 +02:00
Giacomo Pozzoni
e68ebd3339 Core/Misc: Replace some abs() with std::abs()
Always prefer std:: math function compared to C ones, as done in 7fe7f30521
2019-07-24 13:44:55 +02:00
Keader
4c2f7df4f3 Core/Spells: Added spellgroup support to HandleModCastingSpeed (#23592)
And fixed stack of Power Infusion, Bloodlust, Icy veins and Heroism.
2019-07-24 08:31:34 -03:00
Kelno
ef3ee63d88 Core/OPvP: Remove dangling line after 84b7b2e (PR #23625) 2019-07-22 12:05:36 +02:00
Wyrserth
bf8741c53d Script/ScarletEnclave: remove Eye of Acherus control and speed auras from player when the Eye of Acherus is dismissed. 2019-07-21 23:40:15 +02:00
Treeston
51cf1c7136 != and == are not the same thing. 2019-07-21 22:25:04 +02:00
Treeston
81fcd2e2d5 oops, that wasn't supposed to remain there (0e7c66c follow-up) 2019-07-21 20:28:23 +02:00
Shauren
211b2fa354 Core/Conditions: Reserve master branch condition types 2019-07-21 20:06:32 +02:00
jackpoz
2bac44c7d0 Core/Spline: Fix crash
Fix crash when calling MoveSpline::ToString() on an empty spline
2019-07-21 16:21:43 +02:00
Treeston
c4c739fea5 remove unnecessary check, 37f6982 follow-up 2019-07-21 15:49:42 +02:00
Shauren
adc82b78f7 Core/Conditions: Synchronize condition types between branches 2019-07-21 13:20:24 +02:00
Gildor
81d402446f Spell/Mage: Fixed duplicate / erroneous ID of the spell Consumption (#23618) 2019-07-21 12:03:20 +02:00
Treeston
49b04c0fdd Core/AI: No longer override chase movement with follow movement if the creature engages before JustAppeared has had a chance to fire. 2019-07-21 03:59:43 +02:00
Wyrserth
e5615402cc Core/Instance: remove wrong raid-only restriction in the logic that kicks offline players out of instances when the instance is reset. 2019-07-21 02:57:04 +02:00
Treeston
0e7c66cb4c Core/AI: Finally move the "is creature engaged" flag to be a property of the creature AI, where it honestly always belonged. Fixes #17981 and #23602 for real this time. 2019-07-21 01:50:52 +02:00
Wyrserth
b8d86bba99 Script/SethekkHalls: fix gossip text and quest event for NPC Lakka in Sethekk Halls. 2019-07-20 21:02:23 +02:00
Giacomo Pozzoni
aeddd417c4 Core/Misc: Handle timezones for hour-specific events specifieds in worldserver.conf (#23540)
* Core/Misc: Handle timezones for hour-specific events specifieds in worldserver.conf

* Handle Respawn.RestartQuietTime too

* Handle XP.Boost.Daymask too

* Core/Misc: Code cleanup

* Core/Misc: Code cleanup

* Update Util.cpp

* Update boosted_xp.cpp
2019-07-19 21:24:56 +02:00
Treeston
c0f8e8535a build fix after d1dc0e2 2019-07-19 20:37:22 +02:00
ccrs
ba8d3254c2 Core/Player: d1dc0e2 followup
build error going to be fixed soon..ish
2019-07-19 18:52:07 +02:00
ccrs
0e3e4353a1 Core/SmartAI: add missing movement generator type check on SmartAI::SetCombatMove
ref #21562
2019-07-19 16:07:00 +02:00
ccrs
c8cb866db0 Core/SmartAI: allow more Unit::ResumeMovement calls on JustReachedHome()
Since ResumeMovement also works on other MOTION_SLOT_DEFAULT generators (like RandomMG)
2019-07-19 15:52:35 +02:00