Commit Graph

22427 Commits

Author SHA1 Message Date
Killyana
75bc0f6771 Script: Remove npc_avatar_of_martyred converted to SAI
Ref 5924e038d6
2020-06-20 20:35:36 +02:00
jackpoz
54e30d4eba Scripts/VioletHold: Limit the number of current summons before the waves start 2020-06-20 14:12:47 +02:00
Giacomo Pozzoni
4e1dbd1cf8 Log number of Creatures and GameObject per map (#24809)
* Shared/Metric: Allow to specify tags in metrics

* Core/Metric: Log number of Creatures and GameObject per map

* Apply feedback

* Codestyle changes

* Codestyle changes

* Remove whitespace

* Update Grafana dashboards to v7.0.3

* Fix missing filter on realm

* Include Creatures and Gameobjects in Maps dashboard

* Show instances with a different color
2020-06-20 00:04:01 +02:00
Gildor
56d60ee00c Core/Spells: Fix Shadowstep (Rogue), remove 4yd forced radius (#24838) 2020-06-19 22:59:43 +02:00
Gildor
7d88891983 Core/Spells: SPELL_AURA_MOD_ATTACK_POWER_PCT should be negative if TargetType or Basepoints are negative (#24837) 2020-06-19 22:58:41 +02:00
Gildor
18692ad20c Core/Unit: SPELL_INTERRUPT_FLAG_ABORT_ON_DMG should only affect player spells (#24836) 2020-06-19 22:56:46 +02:00
ipriver
dc467ee0f6 Additional cmake entry for configs
Closes #24812

Co-authored-by: Carbenium <carbenium@outlook.com>
2020-06-19 15:06:03 +02:00
Ovahlord
c50bb00ac7 Core/Players: do not update position data on character creation
Retail does not have a zone id for newly created character until their first login so we do the same as well. This will drastically improve performance on character creations as we no longer unnecessarily load grids and map data.
2020-06-18 05:23:25 +02:00
Killyana
8b5549c0f1 Creature/Scripts: Remove deprecated scripts
Ref bd609caf09
2020-06-17 23:43:34 +02:00
Giacomo Pozzoni
995a443da2 Handle different slopes in mmaps (#24765)
* Tools/MMAPs: Remove input argument --maxAngle

Remove input argument --maxAngle . This should be just hardcoded in MapBuilder::GetMapSpecificConfig() so all settings are easily found in the same place instead of being spread around.

* Tools/MMAPs: Add new area type NAV_AREA_GROUND_STEEP

Add new area type NAV_AREA_GROUND_STEEP for ground with slope in the range (55, 70] .
NAV_AREA_GROUND is used for ground with range [0, 55] .
NAV_AREA_GROUND_STEEP takes priority over NAV_AREA_GROUND.

* Tools/MMAPs: Fix NAV_GROUND_STEEP flag not being saved in the mmtile

* Core/PathFinding: Implement NAV_GROUND_STEEP flag

Implement NAV_GROUND_STEEP flag, used only by Creatures that are in combat or evading.

* Distinguish between RC_WALKABLE_AREA and NAV_AREA_GROUND.

* Allow mobs in combat to walk on steeps up to 80°

* Allow mobs in combat to walk on steeps up to 85°.
Disable rcFilterLedgeSpans() filter as it removed long steep spans.

* Increase cost of steep spans to try making creatures walk around obstacles instead of walking on them

* Revert last commit
2020-06-17 22:20:26 +02:00
Max Drosdo.www
1e9c84a3ea Worldserver/CLI: console printf fix (#24802)
* Remove extra cli printf call for non-Windows systems

* Codestyle changes

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-06-17 22:14:27 +02:00
Rothend
e7a714f66c Core/SmartAI: allow AreaTrigger SAI scripts to use the player triggering it as base object for actions and targeting (#24817)
* Core/SmartAI: allow AreaTrigger SAI scripts to use the player triggering it as base object for actions and targeting.

Closes #23669
Closes #24791
Closes #24792
Closes #24793

* Apply suggested changes.

* Initialize atPlayer in the constructor

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-06-17 22:06:56 +02:00
Rothend
c4caae9b6d Script/Spell: properly round damage of Seal of Righteousness (on-hit proc). (#24821) 2020-06-17 19:28:05 +02:00
Peter Keresztes Schmidt
418c3b1fd5 game/AI: Convert SelectAggroTarget to enum class (#24818)
* game/AI: Convert SelectAggroTarget to enum class

* game/AI: Rename SelectAggroTarget to SelectTargetMethod
2020-06-16 23:08:56 +02:00
Ovahlord
152ea60116 Core/SAI: implement SMART_ACTION_ATTACK_STOP
Unlike SMART_ACTION_AUTO_ATTACK, this action is actually stopping the entire attack procedure, rather than just hack-disabling auto-attacks. Keep in mind that this action requires a passive react state to prevent a immediate AttackStart ai reaction
2020-06-14 22:51:42 +02:00
offl
a117450ce9 DB/Instance: Convert some Uldaman scripts to DB
Closes #24744
2020-06-14 19:16:55 +02:00
offl
8bccb258ba DB/Quest: Convert & update support for 'All Along the Watchtowers' to SAI
Closes #24732
2020-06-14 18:26:35 +02:00
offl
d70eb96c85 DB/Quest: Convert & update support for WP Scourge cauldrons quests to SAI
Closes #24730
2020-06-14 18:12:17 +02:00
offl
e47f302fc9 DB/Quest: Convert & update support for 'Escape from the Catacombs' to SAI
Closes #24728
2020-06-14 17:52:12 +02:00
jackpoz
cd37a17103 Scripts/Commands: Add .debug objectcount <optional map id> chat command
Add .debug objectcount <optional map id> chat command to show the number of Creatures and GameObjects
2020-06-14 15:41:01 +02:00
Shauren
988fe4c86c Core/Misc: Add .Size() to TypeUnorderedMapContainer for stats/debugging
(cherry picked from commit d53a2dea5f)
2020-06-14 15:10:16 +02:00
Shauren
6a1cb348c7 Core/DBLayer: Fix build using TRINITY_DEBUG
(cherry picked from commit d6d67a9766)
2020-06-13 21:25:42 +02:00
Shauren
dacb1e5802 Core/Spells: Prevent manual cancelling of channelled spells that have SPELL_ATTR0_CANT_CANCEL 2020-06-12 18:48:45 +02:00
Keader
f2f4fc921e kill white space in last commit 2020-06-09 09:57:47 -03:00
Keader
be48fbc32a Scripts/ShadowfangKeep: Fixed a crash in spellscript 2020-06-09 09:52:44 -03:00
Gildor
aeb41e67a9 Scripts/Naxxramas: Fix Kel'thuzad evade mode when he dies (#24763) 2020-06-07 12:55:38 +02:00
ForesterDev
e3b232fe0e Core/AI: refactor SpellHit and SpellHitTarget. (#24691)
* Core/AI: refactor SpellHit and SpellHitTarget.

- now caster/target is WorldObject instead of Unit
- remove SpellHitByGameObject / SpellHitTargetGameObject (handled by SpellHit / SpellHitTarget)
- rename parameters in scripts according parent methods

* Restore logic in Algalon script

* Changed check for REMORSELESS_WINTER hit to avoid dublicate call, because it has TARGET_UNIT_CASTER for effects 0/1 and TARGET_GAMEOBJECT_SRC_AREA for effect 2

* Fix build after merge
2020-06-07 10:22:13 +02:00
Gildor
1181b636c0 Scripts/Naxxramas: Noth the Plaguebringer improvements (#24724) 2020-06-06 14:22:19 +02:00
jackpoz
6e34e07c48 Tools/MMAPs: Output the time spent in a human readable format 2020-06-05 19:58:02 +02:00
Keader
d81a9e5bc3 Core/Misc: Fixed resistance calculate for Mutated Transformation and Twilight Bloodbolt (#24717)
Ref: 9f7b464a6a
- Implemented a new SpellScript hook that allow control Resistance/Absorb amount of a damage spell.
2020-06-03 22:05:08 -03:00
jackpoz
adc7cd3cee Core/Misc: Fix static analysis issues reported by Coverity Scan 2020-06-03 20:49:31 +02:00
Gildor
90e00c3e2a Core/Spells: Fix ammo consumption (#24736) 2020-06-02 20:34:44 +02:00
Shauren
0e9eb8e7f5 Core/PacketIO: Validate AddonInfo size
Closes #24734
2020-06-01 23:43:38 +02:00
Ovah
43ef610fe0 Core/Units: flight and hover checks will now consider movement template data as well as manually set flight states
- manually set flight states via auras and scripts will no longer be ignored
- restored movement template consideration when generating pathings
- renamed IsLevitating to IsGravityDisabled to reflect the referenced movement flag's name
2020-06-01 15:58:31 +02:00
jackpoz
48c5c0d7a2 Core/Misc: Fix Clang 10 build warnings 2020-05-31 15:52:28 +02:00
Giacomo Pozzoni
8c09b6e58b Cherry-pick some cmake commits (#24720)
* Build system: Support  new in cmake 3.17 Ninja Multi-Config generator

(cherry picked from commit 369b618d4f)

* Build system: Fixed PCH with MSVC & Ninja generator

(cherry picked from commit d669f46b6d)

* Core: Fix clang 10 warnings

(cherry picked from commit 7272508cb4)

# Conflicts:
#	src/common/Utilities/Util.h
#	src/server/bnetserver/REST/LoginRESTService.cpp
#	src/server/game/Entities/Object/Position.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Guilds/GuildFinderMgr.h
#	src/server/game/Movement/Spline/MoveSplineFlag.h
#	src/server/shared/Dynamic/LinkedList.h

* Build system: Set -Wno-deprecated-copy only for clang 10

(cherry picked from commit 7fdeb259ba)

* Core/Misc: GCC build and warning fixes

(cherry picked from commit 4d69cc1c56)

# Conflicts:
#	src/common/Utilities/Util.cpp
#	src/server/database/Database/MySQLConnection.cpp
#	src/server/game/Battlefield/Zones/BattlefieldTB.cpp
#	src/server/game/DataStores/M2Stores.cpp
#	src/server/game/DungeonFinding/LFGMgr.cpp
#	src/server/game/DungeonFinding/LFGPlayerData.cpp
#	src/server/game/Entities/GameObject/GameObject.cpp
#	src/server/game/Entities/Item/Item.cpp
#	src/server/game/Entities/Object/Updates/UpdateFields.h
#	src/server/game/Entities/Player/Player.cpp
#	src/server/game/Entities/Player/RestMgr.cpp
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Handlers/PetHandler.cpp
#	src/server/game/Server/Packets/GuildPackets.h
#	src/server/game/Spells/Auras/SpellAuraEffects.cpp
#	src/server/game/Spells/Auras/SpellAuras.cpp
#	src/server/game/Spells/Spell.cpp
#	src/server/game/Spells/SpellInfo.cpp
#	src/server/game/Spells/SpellMgr.cpp
#	src/server/scripts/Argus/AntorusTheBurningThrone/boss_garothi_worldbreaker.cpp
#	src/server/scripts/Kalimdor/HallsOfOrigination/instance_halls_of_origination.cpp
#	src/server/scripts/Northrend/IcecrownCitadel/instance_icecrown_citadel.cpp
#	src/server/scripts/Northrend/Ulduar/Ulduar/boss_mimiron.cpp
#	src/server/scripts/Northrend/zone_sholazar_basin.cpp
#	src/server/scripts/Outland/BlackTemple/instance_black_temple.cpp
#	src/server/scripts/Outland/GruulsLair/instance_gruuls_lair.cpp
#	src/server/scripts/Outland/HellfireCitadel/BloodFurnace/instance_blood_furnace.cpp
#	src/server/scripts/Outland/HellfireCitadel/ShatteredHalls/shattered_halls.cpp
#	src/tools/vmap4_extractor/gameobject_extract.cpp
#	src/tools/vmap4_extractor/model.cpp
#	src/tools/vmap4_extractor/vec3d.h

* Build system: Print found git version when warning about it being too old

(cherry picked from commit 1ae72db201)

* Build system: Removed hard requirement on BOOST_ROOT being set as environment variable, it can now be also passed as command line argument to cmake and fix compile warning with boost 1.73

(cherry picked from commit 161944b764)

# Conflicts:
#	dep/boost/CMakeLists.txt

* Remove some code that was already removed from 335 and then cherry-picked into master

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-05-31 14:17:26 +02:00
Keader
a72197911e Scripts/Ulduar: Codestyle fix
* Making jackpoz happy xD
2020-05-30 13:13:02 -03:00
Giacomo Pozzoni
141ada19b0 Cherry pick some db commits (#24713)
* Core/DBLayer: Implement async transaction completion callbacks

(cherry picked from commit 0f0ca3a919)

# Conflicts:
#	src/server/bnetserver/REST/LoginRESTService.cpp
#	src/server/bnetserver/Server/Session.cpp
#	src/server/bnetserver/Server/Session.h
#	src/server/database/Database/Transaction.cpp
#	src/server/game/Handlers/CharacterHandler.cpp
#	src/server/game/Handlers/SpellHandler.cpp
#	src/server/game/Server/WorldSession.cpp
#	src/server/game/Server/WorldSocket.cpp
#	src/server/game/Server/WorldSocket.h

* Core/Misc: Fixed char enum packet sometimes not showing newly created character when client latency is too low

(cherry picked from commit fc9d2e728e)

# Conflicts:
#	src/server/game/Handlers/CharacterHandler.cpp

* Fix no-pch build

* Core/Player: Wait for correct transaction on character creation

(cherry picked from commit 01c68b2aa2)

# Conflicts:
#	src/server/game/Entities/Player/Player.cpp

* Fix warning

* Remove unused login transaction

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2020-05-30 17:43:54 +02:00
Keader
00bc6e7d54 Scripts/BloodFurnace: Fixed Broggok stopping work after wipe
By: Rushor
2020-05-30 11:57:30 -03:00
Keader
05eeaade3e Scripts/Ulduar: Fixed XT002 Heart health regeneration 2020-05-30 11:47:43 -03:00
offl
9ebf7b1272 DB/SAI: Convert & update support for Forest Frog to SAI
Closes #24714
2020-05-30 16:37:59 +02:00
Keader
456aaf2cea Scripts/Pet: Fixed Mirror Image trying attacking invalid targets 2020-05-30 11:31:53 -03:00
Gildor
6c1a874e57 Scripts/Trial Of The Crusader: Fixed Anub'arak Pursuing Spikes movement (#24715) 2020-05-30 08:50:33 -03:00
ForesterDev
f7ac6296b6 Core/PacketIO: Create BankHandler & update bank opcodes to new packet class (#24695)
* Core/PacketIO: Create BankHandler & update bank opcodes to new packet class

(cherry picked from commit 478e86c074)

* fix nopch build

* Update SMSG_BUY_BANK_SLOT_RESULT

* fix naming

* fix copypaste error

Co-authored-by: Luzifix <luzifix19@gmail.com>
2020-05-29 18:26:53 +02:00
Shauren
f0060496f9 Core/Networking: Switch to intrusive variant of MPSC queue to halve the number of memory allocations for packet sending (#24659) 2020-05-29 18:17:24 +02:00
Paraciusz
5b7b21c362 Core/PacketIO: Fixed the problem of not displaying random properties of equipment when inspecting other player equipment. (#24696) 2020-05-26 14:53:35 +02:00
Gildor
3ab970aa47 Scripts/Ulduar: Fix Flame Leviathan movement (#24673) 2020-05-26 13:20:38 +02:00
offl
e48c415156 DB/Quest: Convert & update support for 'Mark V is Alive!' to SAI
Closes #24686
2020-05-26 00:01:54 +02:00
offl
1316ca482d DB/Quest: Convert & update support for 'When the Cows Come Home' to SAI
Closes #24685
2020-05-25 23:32:50 +02:00
offl
0e7cabd7f1 DB/Quest: Convert & update support for 'Cuergo's Gold' to SAI
Closes #24675
2020-05-25 23:10:12 +02:00