Commit Graph

31185 Commits

Author SHA1 Message Date
ariel-
175bc752e8 Core/Unit: fix chain cc's not being diminished properly
Logic fail in 9b0fa51022 (now diminishing info is always initialized)

(cherry picked from commit 2f03d502f3)
2017-10-15 16:59:55 +02:00
ariel-
54c0a01062 Core/Spells: moved handling of SPELL_ATTR0_CU_DONT_BREAK_STEALTH inside proc system.
Fixes additional issues with spells that shouldn't be breaking stealth and had this attribute

(cherry picked from commit bea0c01964)
2017-10-15 16:59:54 +02:00
SnapperRy
662c98456d DB/Quest: remove wrong repeatable flag from some quests.
(cherry picked from commit de22843bcb)
2017-10-15 16:22:32 +02:00
Keader
bc9b3b4928 Scripts/Trial of the Crusader: Fixed crash in Snobold Vassal script (#18124)
Closes #18122

(cherry picked from commit cdc5a36dbb)
2017-10-15 16:18:21 +02:00
ariel-
dc6eef8027 Core/Unit: prematurely abort GetFactionTemplateEntry instead of returning a null pointer
Factions should never be invalid for players/spawned creatures anyways

Ref #18113

(cherry picked from commit 5f580c9d3d)
2017-10-15 16:16:06 +02:00
Killyana
66e756b52a DB/SAI: Duggan Wildhammer
By Staleness89
Closes #18112

(cherry picked from commit 3ab164f4ad)
2017-10-15 16:15:17 +02:00
SnapperRy
25c7849262 Script/Spell: remove cosmetic effect for Water Bucket item at login if it expired after the player logged out.
(cherry picked from commit 16cfd59f5b)

Add forgotten override.
(cherry picked from commit c6f94ba42e)

Fix non-PCH build.
(cherry picked from commit 02cea9c0ba)
2017-10-15 16:13:44 +02:00
SnapperRy
1283e21726 DB/Spell: fix cosmetic effect triggered when a Water Barrel is used.
(cherry picked from commit e78cb6ac5c)
2017-10-15 16:12:30 +02:00
Ivan Bakula
08c45b48c5 Core/Arena: Fix lag caused by arena distribution (#17989)
Avoid queueing unneeded queries to save arena teams and arena team members data if nothing was changed during that week.

(cherry picked from commit 3f3dee8049)
2017-10-15 16:11:11 +02:00
Kittnz
227dc49f5a DB/GameObject: Change position of the Candy Bucket in Bor'gorok Outpost
Updates #18104

(cherry picked from commit f1cced96b3)
2017-10-15 16:08:52 +02:00
SnapperRy
b3dedb11fe DB/Quest: Stinking Up Southshore should not be repeatable.
(cherry picked from commit 005e5537ea)
2017-10-15 16:05:07 +02:00
ariel-
1350989628 Core/Spell: do positivity spell checks only against actually hitted effects instead of the whole spell
Closes #18097

(cherry picked from commit 5c1dfce168)
2017-10-15 16:02:40 +02:00
Killyana
2ecc372658 DB: Add some Npcs/Gobs related to Hallow's End
(cherry picked from commit 0285486603)
2017-10-15 16:02:09 +02:00
SnapperRy
be1a3884bc DB/Quest: Hallow's End Treats for Spoops! should not be repeatable.
Also the item Hallow's End Pumpkin Treat should only be available from vendor after turning in that quest.

(cherry picked from commit 489e5b60db)
2017-10-15 15:22:28 +02:00
Killyana
595bd609fc DB/GameObjects: Remove Apple Bob duplicate spawns
(cherry picked from commit f3dcdc4e64)
2017-10-15 14:39:39 +02:00
SnapperRy
c784e3a26a DB/Creature: assign core script to creature Magister Aledis.
Forgotten in 94c41c9.

(cherry picked from commit 50011d7e2d)
2017-10-15 14:37:13 +02:00
Ovah
020825902c Core/AI: implemented AI hook for interrupting spells (#20610) 2017-10-13 22:17:04 +02:00
Shauren
644af37f96 Core/Realms: Made realmlist threadsafe 2017-10-11 22:42:03 +02:00
Shauren
b09bd8d702 Core/Bnet: Fixed uninitialized value 2017-10-10 23:08:54 +02:00
Shauren
1292a987f1 Core/Mails: Fixed mail_items entries being left in database after deleting expired mails
Closes #20194
Closes #20461

(cherry picked from commit 1f3cf8bcf4)
2017-10-09 21:23:52 +02:00
Roc13x
a6d1b34472 Core/Creature: Refactor and improve vendor items (#20328)
* Implement item bonuses in vendors.
* Implement the PlayerConditionID and IgnoreFiltering DB columns.
* Fix loading referenced vendor items
* Allow adding bonuses in .npc add item command
2017-10-09 21:03:25 +02:00
Shauren
6d07f55c00 Tools/Patcher: Changed -launcherlogin patch for mac 2017-10-08 11:15:53 +02:00
Aokromes
513b2768dc Update RBAC.h 2017-10-08 10:21:37 +02:00
Štefan Lazový
c8974a91a6 Core/DataStores: Implemented [] operator on DB2Storage (#20494) 2017-10-07 22:48:05 +02:00
Gacko
b34f5f9eab Fix non-PCH build. 2017-10-04 19:30:25 +02:00
joschiwald
e6f8821bd0 Dropped obsolete code added in 2d75d8071b 2017-10-03 22:15:41 +02:00
ariel-
88ae5f6068 Core/Unit: Change aura proc pair container to vector
(cherry picked from commit 34f734c890)
2017-10-03 21:14:28 +02:00
ariel-
93973b87b1 Core/Spell: clear auras of channeled spells if channeling is cancelled due to invalid targets (dead or w/e)
Closes #14859
Closes #15186

(cherry picked from commit 2d0fb356de)
2017-10-03 21:14:28 +02:00
ariel-
caf47b846f Core/Spells: mark Arcane Missiles aura as negative. Was downranking the spell when targetting low level mobs due to effect 1 flagged as possitive.
Closes #12152

(cherry picked from commit 2b9f807fd9)
2017-10-03 21:14:28 +02:00
ariel-
702d823179 DB/Spell: some proc fixes
- Glyph of Totem of Wrath should proc from triggered casts (fixes aura not applied when summoning through Call of the xx spells)
- Fix Deadly brew not proccing at all
- Fix Light's Beacon not healing with Holy Shock

by xjose93

(cherry picked from commit c6d77e0286)
2017-10-03 21:14:27 +02:00
ariel-
efaa33b599 Core/SpellMgr: some changes in default proc generation. Fix an issue of stealth breaking with positive and/or healing spells
(cherry picked from commit 531904afff)
2017-10-03 21:14:27 +02:00
Shauren
e9d3d2c3a2 Warning fix 2017-10-03 21:04:58 +02:00
ariel-
2d75d8071b Core/Globals: compute aura diminishing return info at startup and cache it
Core/Entities: Save diminish return on an array instead of a linked list

(cherry picked from commit 9b0fa51022)
2017-10-03 20:53:49 +02:00
Shauren
4d5eacd3af Core/Bnet: Added support for -launcherlogin logins (external client launcher required) 2017-10-03 18:03:57 +02:00
joschiwald
0b36d80115 Fixed build 2017-10-03 17:57:59 +02:00
ariel-
6505747f50 Core/AuctionHouseBot: ahbot characters subsystem shake-up
Bonus: fix moar static analysis issues
(cherry picked from commit f4a10571f7)
2017-10-03 17:56:42 +02:00
SnapperRy
8a4bfe94f9 Core/Spell: allow SPELL_EFFECT_QUEST_COMPLETE to set a quest to rewarded only if that quest is used as internal flag by the server (has flag 1024 - QUEST_FLAGS_TRACKING).
(cherry picked from commit 551a8ff8ae)
2017-10-03 17:48:10 +02:00
SnapperRy
f0ddceeff4 Core/Quest: show DIALOG_STATUS_AVAILABLE instead of DIALOG_STATUS_REWARD for non-repeatable autocomplete quests.
(cherry picked from commit 7666296f54)
2017-10-03 17:47:19 +02:00
SnapperRy
6df51159c4 Core/Quest: send correct packet when a quest cannot be rewarded for item-related errors.
(cherry picked from commit c067fe544d)
2017-10-03 17:46:17 +02:00
SnapperRy
0794904f52 DB/SAI: improve timers and remove wrong text from Viera Sunwhisper.
(cherry picked from commit 5c7c8202ec)
2017-10-03 17:42:53 +02:00
joschiwald
3cba023e99 Fixed nonpch build 2017-10-03 17:39:37 +02:00
treeston
03a2f0d56a Entities/Creature: Fix an edge case issue where creatures would re-acquire target after respawn if they despawned while spell focusing.
Instance/AzjolNerub: Fix Anub'arak wall and add sequence break info. Fixes and closes #18013.

(cherry picked from commit 0d725e1336)
2017-10-03 17:35:19 +02:00
SnapperRy
c37d6a737a Core/Text: allow GENDER_NONE to use FemaleText in broadcast_text if not empty.
Otherwise it would only use MaleText, which breaks cases where female NPCs change model to one that has no gender.

(cherry picked from commit b541310578)

# Conflicts:
#	src/server/game/Globals/ObjectMgr.h
2017-10-03 17:34:49 +02:00
SnapperRy
ab15413aad DB/Conditions: show correct gossip for Baron Revilgaz if event Pirates' Day is not running.
Also fix small typo in npc_text.
(cherry picked from commit 8aa798a9b0)

DB/Gossip: Wizlo Bearingshiner.
(cherry picked from commit 718d3e88c4)
2017-10-03 17:33:23 +02:00
SnapperRy
2ecd46c58f DB/Misc: fix gossip text for Noth the Plaguebringer and remove wrong quest turn-in from the same npc.
(cherry picked from commit bc78bfdea2)
2017-10-03 17:28:27 +02:00
SnapperRy
2e79e206af Script/Quest: Arelion's Mistress.
(cherry picked from commit 94c41c92b3)

Fix warning.

Also, the quest's name is Arelion's Secret, not Arelion's Mistress.
(cherry picked from commit 79acb9fa71)
2017-10-03 17:26:23 +02:00
SnapperRy
5c7b821e17 Core/Quest: do not set a quest to failed if it's rewarded or has no status at all (not taken).
(cherry picked from commit 97fd0c1b1a)
2017-10-03 17:22:48 +02:00
treeston
f1929df956 Scripts/AzjolNerub: Make pulling Anub'arak a bit cleaner.
(cherry picked from commit 59cbea00bc)
2017-10-03 17:21:41 +02:00
treeston
10e8b61f90 Fix _DespawnAtEvade for other creatures to actually respawn said other creatures.
Also fix add aggro for Hadronox.
Fixes and closes #18012.

(cherry picked from commit 1ecdea5374)
2017-10-03 17:21:23 +02:00
SnapperRy
527c5081f9 DB/SAI: prevent Dawnblade Hawkrider's SAI from targeting players.
Players will not be randomly attacked while in Isle of Quel'Danas anymore.

(cherry picked from commit dfb23cf0be)
2017-10-03 17:20:21 +02:00