Commit Graph

37401 Commits

Author SHA1 Message Date
Chaouki Dhib
17c4d8f6d9 Core/Spells: fix wrong distance calculations in AoE spells [Needs testing] (#16290)
Core/Spells: Fix wrong distance calculations in AoE spells.
Pull request #16290 by chaodhib.
God bless, finally.

(cherry picked from commit a1f2f30c14)
2022-02-16 04:49:24 +01:00
ariel-
4ad1d377fe Core/Entities: virtualize CheckAttackFitToAuraRequirement
- Should've been like this to begin with

(cherry picked from commit 21d95a1d76)
2022-02-16 04:49:24 +01:00
ariel-
70ecdd1511 Core/Aura: fix SPELL_AURA_MOD_TOTAL_STAT_PERCENTAGE unapply case for dead players
Closes #19276

(cherry picked from commit e1083794cd)
2022-02-16 04:49:24 +01:00
ariel-
827fcb652a Core/Entities: Fix null-dereference crash
Closes #19191

(cherry picked from commit d61e0f79c4)
2022-02-16 04:49:24 +01:00
ariel-
b8d1bab8de Core/Spells: refactor spell_enchant_proc_data table
- Renamed fields to mimic those in spell_proc
- Added Enchant proc attributes for controlling specific enchant features

Ref #7789

(cherry picked from commit f609e7a08b)
2022-02-16 04:49:24 +01:00
ariel-
5e57ad6fa8 Core/Scripts: fix Nightfall proc chance and reduce it for victims with level above 60
Closes #15734

missing code
(cherry picked from commit eac9c1f0b9)
2022-02-16 04:49:24 +01:00
xinef1
a627ea354a Properly stop attacking after player leaves ffa area (like Gurubashi Arena) (#18952)
(cherry picked from commit 4eae29d421)
2022-02-16 04:49:24 +01:00
xinef1
716487fefc Corrected points per level calculation for some spells (#19105)
(cherry picked from commit 9142c778dd)
2022-02-16 04:49:24 +01:00
xinef1
df9738aaa9 Core/Misc: Fixed player corpse looting, added player corpse loot and some more (#19122)
* Fixed corpse looting in wintergrasp
Added corpse loot for wintergrasp quests and To the Looter Go the Spoils (1166) achievement
Don't generate money for loot if no loot mode is available
Simplified few things

(cherry picked from commit 2412886ef6)
2022-02-16 04:49:24 +01:00
xinef1
f431459063 Core/Creatures: Various fixes for creatures, regarding combat conditions, despawning, and few others (#18998)
* Made some changes to kiting mechanics, simplified code and made taunt auras prolong combat no matter the distance from the spawn
Unified some creature despawning code, removed some brutal direct calls in scripts
Don't play death anim on forced despawn
Removed some redundant visibility changes on creature despawn
Fixed possible problem with pet initializing template info from difficulty greater than normal
Properly keep UNIT_FLAG_IN_COMBAT on UpdateEntry call
Moved RegenerateMana function to general Regenerate(Power) function
Fixed increased health regeneration from polymorph for pets
Implemented CREATURE_TYPE_FLAG_GHOST_VISIBLE, those creatures will be properly seen when player is dead also
Removed hackfix from Gaeriyan and Franclorn Forgewright, fixed properly
Simplified ForcedRespawnTime code in ForcedDespawn
Do not allow to assist unit while evading or when enemy is evading
Do not allow to attack other units when evading or when the unit is evading
Corrected distance checking code before creature is allowed to evade, should fix some common problems
Properly return summon position for summoned creatures as their respawn position
Properly stop all moving units on gossip hello, no matter their npc flags

(cherry picked from commit e1f14215d8)
2022-02-16 04:49:24 +01:00
Ovahlord
5a2cdf2d68 DB/Creatures: corrected the base armor value for Cataclysm raid bosses 2022-02-12 20:26:35 +01:00
Ovahlord
0d5a854b49 Core/Spells: corrected the spell range entry for Furious Attack's triggered healing reduction debuff 2022-02-07 16:08:02 +01:00
Ovahlord
bea6e6dcea fixed build 2022-02-05 07:22:16 +01:00
Ovahlord
f2d651f6a9 Core/Units: no longer normalize melee basic attacks of feral druids 2022-02-05 00:00:55 +01:00
Ovahlord
07eb4454be Core/Packets: enabled and added packet class for SMSG_UPDATE_DUNGEON_ENCOUNTER_FOR_LOOT 2022-02-03 01:44:22 +01:00
Ovahlord
e5666d81bc Scripts/DS: documented map object event data for Spine of Deathwing and Warmaster Blackhorn 2022-02-03 01:29:20 +01:00
Ovahlord
b12ae523cd Core/Packets: enable and added packet structure for SMSG_MAP_OBJ_EVENTS 2022-02-03 01:12:41 +01:00
Ovahlord
4db2d16f2e Core/Packets: corrected initial bytebuffer size for loot response packet 2022-02-03 00:43:12 +01:00
Ovahlord
ca35e20c55 Core/Packets: enabled and added packet structure for SMSG_LOOT_CONTENTS 2022-02-03 00:37:59 +01:00
Ovahlord
2087c0521e Scripts/Firelands: ensure that Ragnaros' orientation is up to date before casting Splitting Blow as the facing spline takes one tick to finalize 2022-02-02 17:59:25 +01:00
Ovahlord
2157ab4510 fixed build 2022-02-02 17:49:14 +01:00
Shauren
73bae7c5e5 Core/Spells: Correct implementation of SPELL_ATTR2_TRIGGERED_CAN_TRIGGER_PROC, SPELL_ATTR3_TRIGGERED_CAN_TRIGGER_PROC_2, SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED and rename them (SPELL_ATTR2_ACTIVE_THREAT, SPELL_ATTR3_NOT_A_PROC, SPELL_ATTR3_CAN_PROC_FROM_PROCS) 2022-02-02 17:45:23 +01:00
Gildor
ffb22996b1 Revert "Core/Spells: Force Invisibility (mage) to leave combat." (#27701)
This reverts commit 4b0acb7432.

Co-authored-by: kaelima <kaelima@live.se>
# Conflicts:
#	src/server/game/Spells/Auras/SpellAuras.cpp
2022-02-02 17:42:52 +01:00
Ovahlord
f63d798ed7 Scripts/Firelands: implement Ragnaros encounter 2022-02-02 17:40:54 +01:00
Ovah
135e8833d7 Core/Objects: added a missing member initialization which sometimes resulted in objects being invisible clientside
How did CI not notice that?
2022-02-02 17:33:07 +01:00
Ovahlord
f1acf8d5e8 Scripts/Gilneas: applied modern scripting standards on chapter 1 scripts 2022-02-02 16:24:42 +01:00
Shauren
f2b4f2208e Core/Objects: ported master branch handling for properly destroying objects via out of range and destroy object opcode
# Conflicts:
#	src/server/game/Entities/Creature/Creature.cpp
2022-02-02 16:24:42 +01:00
funjoker
284b2a23eb Core/Misc: Format fix 2022-01-28 22:32:59 +01:00
funjoker
e7eac8823f Fix AdditionalRequirement item checkup 2022-01-28 22:32:59 +01:00
funjoker
25f48ead05 Remove code from incorrect merge 2022-01-28 22:32:59 +01:00
funjoker
f50458d654 Fix build, cherrypick mistakes and start up 2022-01-28 22:32:59 +01:00
ariel-
4ecfc62438 Core/Achievement: fix bad lookup of ACHIEVEMENT_CRITERIA_DATA_TYPE_S_EQUIPPED_ITEM item
Closes #19064

(cherry picked from commit 70c4a37544)
2022-01-28 22:32:59 +01:00
funjoker
eb21768138 Core/Misc: Fix cherry-pick mistakes 2022-01-28 22:32:59 +01:00
ariel-
35b5eaed8f Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts
Closes #19334

(cherry picked from commit 9cfa7c752e)
2022-01-28 22:32:59 +01:00
ariel-
8aa53f2df7 Core/Achievements: port realm first achievement handling from master
veeeery partial cherry-pick of c75fcbe20b

(cherry picked from commit 4596c17dae)
2022-01-28 22:32:59 +01:00
Xinef
62a7c88ef6 Core/Achievements: Optimized resetting achievement criteria by condition and changed the functionality to properly reset all possible criteria with given condition
Closes #18905

(cherry picked from commit 7c7b877c3f)
2022-01-28 22:32:59 +01:00
Xinef
dc15ba1193 Core/Achievements: Greatly optimize achievement system by splitting large types by miscvalue
Closes #18633

(cherry picked from commit 9b44ed9cda)
2022-01-28 22:32:59 +01:00
Ovahlord
0d2a56473a Scripts/Achievements: fixed "You'll Feel Right as Rain" 2022-01-28 22:28:28 +01:00
Shauren
f4c39d1aa9 Build: Disable Visual Studio 2022 MSBuild resource manager to make compile take only as much time as it does in Visual Studio 2019 2022-01-28 21:14:47 +01:00
Ovah
2f99af8d70 Core/Achievements: properly handle ACHIEVEMENT_CRITERIA_TYPE_LEARN_SKILL_LEVEL 2022-01-27 19:00:49 +01:00
Ovahlord
04983ce882 Core/Packets: converted SMSG_CRITERIA_UPDATE to packet class 2022-01-24 02:34:54 +01:00
Ovahlord
292887a0c2 Core/Datastores: corrected a member type in AchievementCriteriaEntry 2022-01-24 02:04:29 +01:00
Ovahlord
03328fe84e Core/Achievements: ported criteria asset union refactor 2022-01-23 22:32:59 +01:00
Ovahlord
2bef0ce3f6 Core/Spells: fixed logic for selecting a channel focus target 2022-01-23 12:44:08 +01:00
xinef1
9da4acce08 Core/Spells: Remade trajectory target selection (#19048)
* Remade trajectory target selection
* Added possibility to apply conditions to trajectory spells
* Properly recalculate delay time if CMSG_UPDATE_PROJECTILE_POSITION is received

(cherry picked from commit c6060dd0c5)
2022-01-22 22:29:20 +01:00
xinef1
a07f73c846 Core/Achievements: Mountain o' Mounts and similar achievement will be properly awarded when you have required amount of mounts, not earlier (#19002)
(cherry picked from commit 8646e72f18)
2022-01-22 21:03:06 +01:00
ariel-
29166a1d0a Core/Util: avoid one useless copy when adding stuff into a HookList
(cherry picked from commit 077b5aec9e)
2022-01-22 20:27:51 +01:00
Keader
3681f356d6 Core/Spell: Fixed range issues with some quest spells
Closes #17815

(cherry picked from commit 6f7310a259)
2022-01-22 19:04:34 +01:00
Ovahlord
3c88782b87 Core/Movement: no longer copy movement status returned in ack messages and stricly rely on server side status 2022-01-22 17:25:26 +01:00
Ovahlord
ba4df11ab8 Core/Items: handle ITEM_MOD_EXTRA_ARMOR
closes #323
2022-01-21 23:12:16 +01:00